Re: [PATCH 1/9] cgroup: fix css leaks on online_css() failure

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/9] cgroup: fix css leaks on online_css() failure
Date: Tue, 3 Sep 2013 16:06:56 -0400	[thread overview]
Message-ID: <20130903200656.GD27092@mtj.dyndns.org> (raw)
In-Reply-To: <52245DE0.1010701-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Hello,

On Mon, Sep 02, 2013 at 05:44:00PM +0800, Li Zefan wrote:
> Now cgroup_destroy_locked() is called:
> 
> 	for_each_root_subsys(cgrp->root, ss)
> 		kill_css(cgroup_css(cgrp, ss));

Oops, yes, later in the series, for_each_css() is introduced and
replaces for_each_root_subsys() usages solving the above problem.  I
should have put those patches before this one.  Will re-sequence the
patches.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)

From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] cgroup: fix css leaks on online_css() failure
Date: Tue, 3 Sep 2013 16:06:56 -0400	[thread overview]
Message-ID: <20130903200656.GD27092@mtj.dyndns.org> (raw)
In-Reply-To: <52245DE0.1010701@huawei.com>

Hello,

On Mon, Sep 02, 2013 at 05:44:00PM +0800, Li Zefan wrote:
> Now cgroup_destroy_locked() is called:
> 
> 	for_each_root_subsys(cgrp->root, ss)
> 		kill_css(cgroup_css(cgrp, ss));

Oops, yes, later in the series, for_each_css() is introduced and
replaces for_each_root_subsys() usages solving the above problem.  I
should have put those patches before this one.  Will re-sequence the
patches.

Thanks.

-- 
tejun

next prev parent reply	other threads:[~2013-09-03 20:06 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 21:03 [PATCHSET cgroup/for-3.12] cgroup: factor out css creation into create_css() Tejun Heo
2013-08-28 21:03 ` Tejun Heo
     [not found] ` <1377723829-22814-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-28 21:03   ` [PATCH 1/9] cgroup: fix css leaks on online_css() failure Tejun Heo
2013-08-28 21:03     ` Tejun Heo
2013-09-02  9:44     ` Li Zefan
     [not found]       ` <52245DE0.1010701-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-09-03 20:06         ` Tejun Heo
2013-09-03 20:06         ` Tejun Heo [this message]
2013-09-03 20:06           ` Tejun Heo
     [not found]     ` <1377723829-22814-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-03 20:51       ` [PATCH v2 " Tejun Heo
2013-09-03 20:51         ` Tejun Heo
2013-08-28 21:03   ` [PATCH 2/9] cgroup: css iterations and css_from_dir() are safe under cgroup_mutex Tejun Heo
2013-08-28 21:03     ` Tejun Heo
     [not found]     ` <1377723829-22814-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-31 13:56       ` [PATCH v2 " Tejun Heo
2013-08-31 13:56         ` Tejun Heo
2013-08-28 21:03   ` [PATCH 3/9] cgroup: make for_each_subsys() useable under cgroup_root_mutex Tejun Heo
2013-08-28 21:03     ` Tejun Heo
     [not found]     ` <1377723829-22814-4-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-08-31 13:59       ` [PATCH v2 " Tejun Heo
2013-08-31 13:59       ` Tejun Heo
2013-08-31 13:59         ` Tejun Heo
2013-08-28 21:03   ` [PATCH 4/9] cgroup: move css_id commit from cgroup_populate_dir() to online_css() Tejun Heo
2013-08-28 21:03     ` Tejun Heo
2013-08-28 21:03   ` [PATCH 5/9] cgroup: reorder operations in cgroup_create() Tejun Heo
2013-08-28 21:03     ` Tejun Heo
2013-08-28 21:03   ` [PATCH 6/9] cgroup: combine css handling loops " Tejun Heo
2013-08-28 21:03     ` Tejun Heo
2013-08-28 21:03   ` [PATCH 7/9] cgroup: factor out cgroup_subsys_state creation into create_css() Tejun Heo
2013-08-28 21:03   ` [PATCH 8/9] cgroup: implement for_each_css() Tejun Heo
2013-08-28 21:03     ` Tejun Heo
     [not found]     ` <1377723829-22814-9-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-09-03 20:54       ` [PATCH v2 " Tejun Heo
2013-09-03 20:54         ` Tejun Heo
2013-08-28 21:03   ` [PATCH 9/9] cgroup: remove for_each_root_subsys() Tejun Heo
2013-08-28 21:03     ` Tejun Heo
2013-08-28 21:03   ` Tejun Heo
2013-09-05  3:24   ` [PATCHSET cgroup/for-3.12] cgroup: factor out css creation into create_css() Li Zefan
2013-09-05  3:24     ` Li Zefan
2013-08-28 21:03 ` [PATCH 7/9] cgroup: factor out cgroup_subsys_state " Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903200656.GD27092@mtj.dyndns.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.