* [Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain
@ 2013-09-04 11:31 Peter Korsgaard
2013-09-04 11:34 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2013-09-04 11:31 UTC (permalink / raw)
To: buildroot
commit: http://git.buildroot.net/buildroot/commit/?id=b6d92bf415df33ac86487d68f5f8299f406859d2
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
Fixes http://autobuild.buildroot.net/results/92b/92b3990e3a51c9e400cff31a1f0d23aeb5085a54/
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
package/efl/libevas/libevas.mk | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/package/efl/libevas/libevas.mk b/package/efl/libevas/libevas.mk
index 41ceb49..46de4cb 100644
--- a/package/efl/libevas/libevas.mk
+++ b/package/efl/libevas/libevas.mk
@@ -203,6 +203,11 @@ else
LIBEVAS_CONF_OPT += --disable-font-loader-eet
endif
+# async image preload support needs threads support in toolchain
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBEVAS_CONF_OPT += --disable-async-preload
+endif
+
# libevas installs the source code of examples on the target, which
# are generally not useful.
define LIBEVAS_REMOVE_EXAMPLES
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain
2013-09-04 11:31 [Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain Peter Korsgaard
@ 2013-09-04 11:34 ` Thomas Petazzoni
2013-09-04 11:55 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2013-09-04 11:34 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Wed, 4 Sep 2013 13:31:19 +0200, Peter Korsgaard wrote:
> +# async image preload support needs threads support in toolchain
> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
Maybe using positive logic would have been better, no?
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
...
endif
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain
2013-09-04 11:34 ` Thomas Petazzoni
@ 2013-09-04 11:55 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-09-04 11:55 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Dear Peter Korsgaard,
Thomas> On Wed, 4 Sep 2013 13:31:19 +0200, Peter Korsgaard wrote:
>> +# async image preload support needs threads support in toolchain
>> +ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
Thomas> Maybe using positive logic would have been better, no?
Thomas> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
Thomas> ...
Thomas> endif
Perhaps. I don't really feel strongly about it, and we do have quite a
mix today:
git grep 'ifneq.*,y)' package | wc -l
164
git grep 'ifeq.*,)' package/|wc -l
85
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-04 11:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 11:31 [Buildroot] [git commit] libevas: async image preload support needs threads support in toolchain Peter Korsgaard
2013-09-04 11:34 ` Thomas Petazzoni
2013-09-04 11:55 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.