From: Lee Jones <lee.jones@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@cam.ac.uk" <jic23@cam.ac.uk>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"denis.ciocca@st.com" <denis.ciocca@st.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
Date: Wed, 4 Sep 2013 14:51:43 +0100 [thread overview]
Message-ID: <20130904135143.GJ20150@lee--X1> (raw)
In-Reply-To: <20130904123850.GI18206@e106331-lin.cambridge.arm.com>
On Wed, 04 Sep 2013, Mark Rutland wrote:
> Hi Lee,
>
> On Wed, Sep 04, 2013 at 10:31:34AM +0100, Lee Jones wrote:
> > After applying this node the LPS001WP sensor chip should probe
> > successfully once the driver support has also been applied.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> > index cf9b16e..aad8f54 100644
> > --- a/arch/arm/boot/dts/ste-snowball.dts
> > +++ b/arch/arm/boot/dts/ste-snowball.dts
> > @@ -153,6 +153,16 @@
> > status = "okay";
> > };
> >
> > + i2c@80128000 {
> > + lps001wp@5c {
> > + compatible = "lps001wp";
> > + reg = <0x5c>;
> > +
> > + vdd-supply = <&ab8500_ldo_aux1_reg>;
> > + vms-supply = <&db8500_vsmps2_reg>;
> > + };
> > + };
> > +
>
> This appears to be missing a binding document. I couldn't see one
> anywhere in this series, or in mainline already).
>
> As far as I can see, the compatible string should be "st,lps001wp".
>
> Please produce a binding document.
Patch sent, most of you are on CC.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT
Date: Wed, 4 Sep 2013 14:51:43 +0100 [thread overview]
Message-ID: <20130904135143.GJ20150@lee--X1> (raw)
In-Reply-To: <20130904123850.GI18206@e106331-lin.cambridge.arm.com>
On Wed, 04 Sep 2013, Mark Rutland wrote:
> Hi Lee,
>
> On Wed, Sep 04, 2013 at 10:31:34AM +0100, Lee Jones wrote:
> > After applying this node the LPS001WP sensor chip should probe
> > successfully once the driver support has also been applied.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > arch/arm/boot/dts/ste-snowball.dts | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ste-snowball.dts b/arch/arm/boot/dts/ste-snowball.dts
> > index cf9b16e..aad8f54 100644
> > --- a/arch/arm/boot/dts/ste-snowball.dts
> > +++ b/arch/arm/boot/dts/ste-snowball.dts
> > @@ -153,6 +153,16 @@
> > status = "okay";
> > };
> >
> > + i2c at 80128000 {
> > + lps001wp at 5c {
> > + compatible = "lps001wp";
> > + reg = <0x5c>;
> > +
> > + vdd-supply = <&ab8500_ldo_aux1_reg>;
> > + vms-supply = <&db8500_vsmps2_reg>;
> > + };
> > + };
> > +
>
> This appears to be missing a binding document. I couldn't see one
> anywhere in this series, or in mainline already).
>
> As far as I can see, the compatible string should be "st,lps001wp".
>
> Please produce a binding document.
Patch sent, most of you are on CC.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-04 13:51 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 9:31 [PATCH 00/11] iio: ST clean-ups and new pressure sensor device Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 9:31 ` [PATCH 01/11] ARM: ux500: Remove PrimeCell IDs from Nomadik I2C DT nodes Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 9:31 ` [PATCH 02/11] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 12:38 ` Mark Rutland
2013-09-04 12:38 ` Mark Rutland
2013-09-04 13:36 ` Lee Jones
2013-09-04 13:36 ` Lee Jones
2013-09-04 14:08 ` Mark Rutland
2013-09-04 14:08 ` Mark Rutland
2013-09-04 13:51 ` Lee Jones [this message]
2013-09-04 13:51 ` Lee Jones
2013-09-04 13:55 ` [PATCH v2 " Lee Jones
2013-09-04 13:55 ` Lee Jones
2013-09-04 9:31 ` [PATCH 03/11] ARM: ux500: CONFIG: Enable ST's IIO Pressure Sensors by default Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 9:31 ` [PATCH 04/11] iio: pressure-i2c: st: Simplify error checking in probe() Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 16:21 ` Jonathan Cameron
2013-09-04 16:21 ` Jonathan Cameron
2013-09-04 16:21 ` Jonathan Cameron
2013-09-04 16:30 ` Lee Jones
2013-09-04 16:30 ` Lee Jones
2013-09-04 9:31 ` [PATCH 05/11] iio: pressure-core: st: Describe LPS331AP defines by name Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 20:10 ` Denis CIOCCA
2013-09-04 20:10 ` Denis CIOCCA
2013-09-04 20:10 ` Denis CIOCCA
2013-09-05 7:38 ` Lee Jones
2013-09-05 7:38 ` Lee Jones
2013-09-04 9:31 ` [PATCH 06/11] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 20:15 ` Denis CIOCCA
2013-09-04 20:15 ` Denis CIOCCA
2013-09-04 20:15 ` Denis CIOCCA
2013-09-05 7:21 ` Lee Jones
2013-09-05 7:21 ` Lee Jones
2013-09-05 7:31 ` Denis CIOCCA
2013-09-05 7:31 ` Denis CIOCCA
2013-09-05 7:31 ` Denis CIOCCA
2013-09-05 7:59 ` Lee Jones
2013-09-05 7:59 ` Lee Jones
2013-09-05 8:35 ` Denis CIOCCA
2013-09-05 8:35 ` Denis CIOCCA
2013-09-05 8:35 ` Denis CIOCCA
2013-09-04 9:31 ` [PATCH 07/11] iio: sensors-core: st: Allow full-scale to be an optional feature Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 9:31 ` [PATCH 08/11] iio: pressure-core: st: Allow for number of channels to vary Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 20:17 ` Denis CIOCCA
2013-09-04 9:31 ` [PATCH 09/11] iio: pressure-core: st: Clean-up error handling in probe function Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 16:32 ` Jonathan Cameron
2013-09-04 16:32 ` Jonathan Cameron
2013-09-04 16:32 ` Jonathan Cameron
2013-09-04 9:31 ` [PATCH 10/11] iio: pressure: st: Add support for new LPS001WP pressure sensor Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 9:31 ` [PATCH 11/11] iio: pressure-core: st: Provide correct regulator support Lee Jones
2013-09-04 9:31 ` Lee Jones
2013-09-04 13:11 ` Mark Rutland
2013-09-04 13:11 ` Mark Rutland
2013-09-04 13:18 ` Lars-Peter Clausen
2013-09-04 13:18 ` Lars-Peter Clausen
2013-09-04 13:26 ` Lee Jones
2013-09-04 13:26 ` Lee Jones
2013-09-04 15:05 ` Mark Brown
2013-09-04 15:05 ` Mark Brown
2013-09-04 13:24 ` Mark Brown
2013-09-04 13:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904135143.GJ20150@lee--X1 \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=denis.ciocca@st.com \
--cc=jic23@cam.ac.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.