* [patch] sfc: check for allocation failure
@ 2013-09-02 9:04 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2013-09-02 9:04 UTC (permalink / raw)
To: Solarflare linux maintainers; +Cc: Ben Hutchings, netdev, kernel-janitors
It upsets static analyzers when we don't check for allocation failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
index ba6c87a..aac6897 100644
--- a/drivers/net/ethernet/sfc/mtd.c
+++ b/drivers/net/ethernet/sfc/mtd.c
@@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
/* Allocate space for maximum number of partitions */
parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
+ if (!parts)
+ return -ENOMEM;
n_parts = 0;
spi = &nic_data->spi_flash;
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [patch] sfc: check for allocation failure
@ 2013-09-02 9:04 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2013-09-02 9:04 UTC (permalink / raw)
To: Solarflare linux maintainers; +Cc: Ben Hutchings, netdev, kernel-janitors
It upsets static analyzers when we don't check for allocation failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
index ba6c87a..aac6897 100644
--- a/drivers/net/ethernet/sfc/mtd.c
+++ b/drivers/net/ethernet/sfc/mtd.c
@@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
/* Allocate space for maximum number of partitions */
parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
+ if (!parts)
+ return -ENOMEM;
n_parts = 0;
spi = &nic_data->spi_flash;
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
2013-09-02 9:04 ` Dan Carpenter
@ 2013-09-02 17:00 ` Ben Hutchings
-1 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-02 17:00 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Solarflare linux maintainers, netdev, kernel-janitors
On Mon, 2013-09-02 at 12:04 +0300, Dan Carpenter wrote:
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Thanks Dan.
Ben.
> diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
> index ba6c87a..aac6897 100644
> --- a/drivers/net/ethernet/sfc/mtd.c
> +++ b/drivers/net/ethernet/sfc/mtd.c
> @@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
>
> /* Allocate space for maximum number of partitions */
> parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
> + if (!parts)
> + return -ENOMEM;
> n_parts = 0;
>
> spi = &nic_data->spi_flash;
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
@ 2013-09-02 17:00 ` Ben Hutchings
0 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-02 17:00 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Solarflare linux maintainers, netdev, kernel-janitors
On Mon, 2013-09-02 at 12:04 +0300, Dan Carpenter wrote:
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Thanks Dan.
Ben.
> diff --git a/drivers/net/ethernet/sfc/mtd.c b/drivers/net/ethernet/sfc/mtd.c
> index ba6c87a..aac6897 100644
> --- a/drivers/net/ethernet/sfc/mtd.c
> +++ b/drivers/net/ethernet/sfc/mtd.c
> @@ -384,6 +384,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
>
> /* Allocate space for maximum number of partitions */
> parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
> + if (!parts)
> + return -ENOMEM;
> n_parts = 0;
>
> spi = &nic_data->spi_flash;
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
2013-09-02 9:04 ` Dan Carpenter
@ 2013-09-04 2:49 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-09-04 2:49 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, bhutchings, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 2 Sep 2013 12:04:42 +0300
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This applies cleanly neither to net nor net-next, please send me a
version that does.
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
@ 2013-09-04 2:49 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-09-04 2:49 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, bhutchings, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 2 Sep 2013 12:04:42 +0300
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This applies cleanly neither to net nor net-next, please send me a
version that does.
Thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
2013-09-04 2:49 ` David Miller
@ 2013-09-04 14:41 ` Ben Hutchings
-1 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-04 14:41 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, netdev, kernel-janitors, David Miller
On Tue, 2013-09-03 at 22:49 -0400, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Mon, 2 Sep 2013 12:04:42 +0300
>
> > It upsets static analyzers when we don't check for allocation failure.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This applies cleanly neither to net nor net-next, please send me a
> version that does.
Oh yes, I failed to spot the filename. That function has since been
moved to falcon.c.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch] sfc: check for allocation failure
@ 2013-09-04 14:41 ` Ben Hutchings
0 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-04 14:41 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, netdev, kernel-janitors, David Miller
On Tue, 2013-09-03 at 22:49 -0400, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Mon, 2 Sep 2013 12:04:42 +0300
>
> > It upsets static analyzers when we don't check for allocation failure.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This applies cleanly neither to net nor net-next, please send me a
> version that does.
Oh yes, I failed to spot the filename. That function has since been
moved to falcon.c.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [patch v2] sfc: check for allocation failure
2013-09-04 2:49 ` David Miller
@ 2013-09-04 15:07 ` Dan Carpenter
-1 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2013-09-04 15:07 UTC (permalink / raw)
To: Solarflare linux maintainers; +Cc: Ben Hutchings, netdev, kernel-janitors
It upsets static analyzers when we don't check for allocation failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: rebased on latest linux-next
diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c
index 38d179c..75799f8 100644
--- a/drivers/net/ethernet/sfc/falcon.c
+++ b/drivers/net/ethernet/sfc/falcon.c
@@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
/* Allocate space for maximum number of partitions */
parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
+ if (!parts)
+ return -ENOMEM;
n_parts = 0;
spi = &nic_data->spi_flash;
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [patch v2] sfc: check for allocation failure
@ 2013-09-04 15:07 ` Dan Carpenter
0 siblings, 0 replies; 14+ messages in thread
From: Dan Carpenter @ 2013-09-04 15:07 UTC (permalink / raw)
To: Solarflare linux maintainers; +Cc: Ben Hutchings, netdev, kernel-janitors
It upsets static analyzers when we don't check for allocation failure.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: rebased on latest linux-next
diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c
index 38d179c..75799f8 100644
--- a/drivers/net/ethernet/sfc/falcon.c
+++ b/drivers/net/ethernet/sfc/falcon.c
@@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
/* Allocate space for maximum number of partitions */
parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
+ if (!parts)
+ return -ENOMEM;
n_parts = 0;
spi = &nic_data->spi_flash;
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [patch v2] sfc: check for allocation failure
2013-09-04 15:07 ` Dan Carpenter
@ 2013-09-04 15:51 ` Ben Hutchings
-1 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-04 15:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Solarflare linux maintainers, netdev, kernel-janitors
On Wed, 2013-09-04 at 18:07 +0300, Dan Carpenter wrote:
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> v2: rebased on latest linux-next
>
> diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c
> index 38d179c..75799f8 100644
> --- a/drivers/net/ethernet/sfc/falcon.c
> +++ b/drivers/net/ethernet/sfc/falcon.c
> @@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
>
> /* Allocate space for maximum number of partitions */
> parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
> + if (!parts)
> + return -ENOMEM;
> n_parts = 0;
>
> spi = &nic_data->spi_flash;
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v2] sfc: check for allocation failure
@ 2013-09-04 15:51 ` Ben Hutchings
0 siblings, 0 replies; 14+ messages in thread
From: Ben Hutchings @ 2013-09-04 15:51 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Solarflare linux maintainers, netdev, kernel-janitors
On Wed, 2013-09-04 at 18:07 +0300, Dan Carpenter wrote:
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> v2: rebased on latest linux-next
>
> diff --git a/drivers/net/ethernet/sfc/falcon.c b/drivers/net/ethernet/sfc/falcon.c
> index 38d179c..75799f8 100644
> --- a/drivers/net/ethernet/sfc/falcon.c
> +++ b/drivers/net/ethernet/sfc/falcon.c
> @@ -894,6 +894,8 @@ static int falcon_mtd_probe(struct efx_nic *efx)
>
> /* Allocate space for maximum number of partitions */
> parts = kcalloc(2, sizeof(*parts), GFP_KERNEL);
> + if (!parts)
> + return -ENOMEM;
> n_parts = 0;
>
> spi = &nic_data->spi_flash;
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v2] sfc: check for allocation failure
2013-09-04 15:07 ` Dan Carpenter
@ 2013-09-04 17:08 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-09-04 17:08 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, bhutchings, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Sep 2013 18:07:27 +0300
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: rebased on latest linux-next
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [patch v2] sfc: check for allocation failure
@ 2013-09-04 17:08 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2013-09-04 17:08 UTC (permalink / raw)
To: dan.carpenter; +Cc: linux-net-drivers, bhutchings, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 4 Sep 2013 18:07:27 +0300
> It upsets static analyzers when we don't check for allocation failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: rebased on latest linux-next
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-09-05 13:52 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02 9:04 [patch] sfc: check for allocation failure Dan Carpenter
2013-09-02 9:04 ` Dan Carpenter
2013-09-02 17:00 ` Ben Hutchings
2013-09-02 17:00 ` Ben Hutchings
2013-09-04 2:49 ` David Miller
2013-09-04 2:49 ` David Miller
2013-09-04 14:41 ` Ben Hutchings
2013-09-04 14:41 ` Ben Hutchings
2013-09-04 15:07 ` [patch v2] " Dan Carpenter
2013-09-04 15:07 ` Dan Carpenter
2013-09-04 15:51 ` Ben Hutchings
2013-09-04 15:51 ` Ben Hutchings
2013-09-04 17:08 ` David Miller
2013-09-04 17:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.