From: Marek Vasut <marex@denx.de>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, Rob Herring <rob.herring@calxeda.com>,
Thierry Reding <thierry.reding@gmail.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH] pwm: pxa: add device tree support to pwm driver
Date: Wed, 4 Sep 2013 16:35:26 +0200 [thread overview]
Message-ID: <201309041635.26695.marex@denx.de> (raw)
In-Reply-To: <5227425E.7030806@newsguy.com>
Dear Mike Dunn,
> On 09/03/2013 03:20 PM, Marek Vasut wrote:
>
> [...]
>
> >> +#ifdef CONFIG_OF
> >> +/* use the platform_device id table for OF match table data */
> >> +static struct of_device_id pwm_of_match[] = {
> >> + { .compatible = "marvell,pxa25x-pwm", .data = &pwm_id_table[0] },
> >> + { .compatible = "marvell,pxa27x-pwm", .data = &pwm_id_table[1] },
> >> + { .compatible = "marvell,pxa168-pwm", .data = &pwm_id_table[2] },
> >> + { .compatible = "marvell,pxa910-pwm", .data = &pwm_id_table[3] },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, pwm_of_match);
> >
> > Are PXA2xx and PXA3xx PWM impleemntations not all the same ? If so, why
> > not just stick with pxa25x-pwm only for all of the CPUs (aka. the lowest
> > CPU model). Then the table would have but a single entry.
>
> I'm just echoing the existing platform_device_id table...
>
> static const struct platform_device_id pwm_id_table[] = {
> /* PWM has_secondary_pwm? */
> { "pxa25x-pwm", 0 },
> { "pxa27x-pwm", HAS_SECONDARY_PWM },
> { "pxa168-pwm", 0 },
> { "pxa910-pwm", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(platform, pwm_id_table);
>
> ... so that my changes to the driver are minimal. Yes, apparently the only
> difference is the existance of a "secondary" pwm for pxa27x.
>
> BTW, the pxa27x actually has four pwms, which is why the addition I made to
> pxa27x.dtsi has two nodes (the driver handles two pwms for each device
> instance in the pxa27x case).
>
What's that "secondary PWM" there? I no longer remember, sorry. The question
remains still, we can have two entries there (pxa25x and pxa27x) ORR have one
entry (pxa25x) + mrvl,has-secondary-pwm entry.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: pxa: add device tree support to pwm driver
Date: Wed, 4 Sep 2013 16:35:26 +0200 [thread overview]
Message-ID: <201309041635.26695.marex@denx.de> (raw)
In-Reply-To: <5227425E.7030806@newsguy.com>
Dear Mike Dunn,
> On 09/03/2013 03:20 PM, Marek Vasut wrote:
>
> [...]
>
> >> +#ifdef CONFIG_OF
> >> +/* use the platform_device id table for OF match table data */
> >> +static struct of_device_id pwm_of_match[] = {
> >> + { .compatible = "marvell,pxa25x-pwm", .data = &pwm_id_table[0] },
> >> + { .compatible = "marvell,pxa27x-pwm", .data = &pwm_id_table[1] },
> >> + { .compatible = "marvell,pxa168-pwm", .data = &pwm_id_table[2] },
> >> + { .compatible = "marvell,pxa910-pwm", .data = &pwm_id_table[3] },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, pwm_of_match);
> >
> > Are PXA2xx and PXA3xx PWM impleemntations not all the same ? If so, why
> > not just stick with pxa25x-pwm only for all of the CPUs (aka. the lowest
> > CPU model). Then the table would have but a single entry.
>
> I'm just echoing the existing platform_device_id table...
>
> static const struct platform_device_id pwm_id_table[] = {
> /* PWM has_secondary_pwm? */
> { "pxa25x-pwm", 0 },
> { "pxa27x-pwm", HAS_SECONDARY_PWM },
> { "pxa168-pwm", 0 },
> { "pxa910-pwm", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(platform, pwm_id_table);
>
> ... so that my changes to the driver are minimal. Yes, apparently the only
> difference is the existance of a "secondary" pwm for pxa27x.
>
> BTW, the pxa27x actually has four pwms, which is why the addition I made to
> pxa27x.dtsi has two nodes (the driver handles two pwms for each device
> instance in the pxa27x case).
>
What's that "secondary PWM" there? I no longer remember, sorry. The question
remains still, we can have two entries there (pxa25x and pxa27x) ORR have one
entry (pxa25x) + mrvl,has-secondary-pwm entry.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
Thierry Reding <thierry.reding@gmail.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pwm: pxa: add device tree support to pwm driver
Date: Wed, 4 Sep 2013 16:35:26 +0200 [thread overview]
Message-ID: <201309041635.26695.marex@denx.de> (raw)
In-Reply-To: <5227425E.7030806@newsguy.com>
Dear Mike Dunn,
> On 09/03/2013 03:20 PM, Marek Vasut wrote:
>
> [...]
>
> >> +#ifdef CONFIG_OF
> >> +/* use the platform_device id table for OF match table data */
> >> +static struct of_device_id pwm_of_match[] = {
> >> + { .compatible = "marvell,pxa25x-pwm", .data = &pwm_id_table[0] },
> >> + { .compatible = "marvell,pxa27x-pwm", .data = &pwm_id_table[1] },
> >> + { .compatible = "marvell,pxa168-pwm", .data = &pwm_id_table[2] },
> >> + { .compatible = "marvell,pxa910-pwm", .data = &pwm_id_table[3] },
> >> + { }
> >> +};
> >> +MODULE_DEVICE_TABLE(of, pwm_of_match);
> >
> > Are PXA2xx and PXA3xx PWM impleemntations not all the same ? If so, why
> > not just stick with pxa25x-pwm only for all of the CPUs (aka. the lowest
> > CPU model). Then the table would have but a single entry.
>
> I'm just echoing the existing platform_device_id table...
>
> static const struct platform_device_id pwm_id_table[] = {
> /* PWM has_secondary_pwm? */
> { "pxa25x-pwm", 0 },
> { "pxa27x-pwm", HAS_SECONDARY_PWM },
> { "pxa168-pwm", 0 },
> { "pxa910-pwm", 0 },
> { },
> };
> MODULE_DEVICE_TABLE(platform, pwm_id_table);
>
> ... so that my changes to the driver are minimal. Yes, apparently the only
> difference is the existance of a "secondary" pwm for pxa27x.
>
> BTW, the pxa27x actually has four pwms, which is why the addition I made to
> pxa27x.dtsi has two nodes (the driver handles two pwms for each device
> instance in the pxa27x case).
>
What's that "secondary PWM" there? I no longer remember, sorry. The question
remains still, we can have two entries there (pxa25x and pxa27x) ORR have one
entry (pxa25x) + mrvl,has-secondary-pwm entry.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-04 14:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 19:23 [PATCH] pwm: pxa: add device tree support to pwm driver Mike Dunn
2013-09-03 19:23 ` Mike Dunn
2013-09-03 19:23 ` Mike Dunn
2013-09-03 22:20 ` Marek Vasut
2013-09-03 22:20 ` Marek Vasut
2013-09-03 22:20 ` Marek Vasut
2013-09-04 14:23 ` Mike Dunn
2013-09-04 14:23 ` Mike Dunn
2013-09-04 14:23 ` Mike Dunn
2013-09-04 14:35 ` Marek Vasut [this message]
2013-09-04 14:35 ` Marek Vasut
2013-09-04 14:35 ` Marek Vasut
2013-09-04 15:41 ` Mike Dunn
2013-09-04 15:41 ` Mike Dunn
2013-09-04 15:41 ` Mike Dunn
2013-09-04 22:11 ` Marek Vasut
2013-09-04 22:11 ` Marek Vasut
2013-09-04 22:11 ` Marek Vasut
2013-09-05 15:24 ` Mike Dunn
2013-09-05 15:24 ` Mike Dunn
2013-09-05 15:24 ` Mike Dunn
2013-09-05 15:34 ` Marek Vasut
2013-09-05 15:34 ` Marek Vasut
2013-09-05 15:34 ` Marek Vasut
2013-09-05 16:07 ` Mike Dunn
2013-09-05 16:07 ` Mike Dunn
2013-09-05 16:07 ` Mike Dunn
2013-09-04 14:38 ` Sergei Shtylyov
2013-09-04 14:38 ` Sergei Shtylyov
2013-09-04 15:44 ` Mike Dunn
2013-09-04 15:44 ` Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309041635.26695.marex@denx.de \
--to=marex@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mikedunn@newsguy.com \
--cc=rob.herring@calxeda.com \
--cc=robert.jarzmik@free.fr \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.