From: jerry.hoemann-VXdhtT5mjnY@public.gmane.org
To: Matthew Garrett
<matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
kexec <kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions
Date: Wed, 4 Sep 2013 14:09:59 -0600 [thread overview]
Message-ID: <20130904200959.GE8540@anatevka.fc.hp.com> (raw)
In-Reply-To: <1378252218-18798-9-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
On Tue, Sep 03, 2013 at 07:50:15PM -0400, Matthew Garrett wrote:
> kexec permits the loading and execution of arbitrary code in ring 0, which
> is something that module signing enforcement is meant to prevent. It makes
> sense to disable kexec in this situation.
>
> Signed-off-by: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
Matthew,
Disabling kexec will disable kdump, correct?
Are there plans to enable kdump on a system where secure
boot is enabled?
thanks
Jerry
> ---
> kernel/kexec.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..3e2b63a 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -32,6 +32,7 @@
> #include <linux/vmalloc.h>
> #include <linux/swap.h>
> #include <linux/syscore_ops.h>
> +#include <linux/module.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>
> @@ -943,6 +944,13 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
> return -EPERM;
>
> /*
> + * kexec can be used to circumvent module loading restrictions, so
> + * prevent loading in that case
> + */
> + if (secure_modules())
> + return -EPERM;
> +
> + /*
> * Verify we have a legal set of flags
> * This leaves us room for future extensions.
> */
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard/MODL
3404 E Harmony Rd. MS 57 phone: (970) 898-1022
Ft. Collins, CO 80528 FAX: (970) 898-XXXX
email: jerry.hoemann-VXdhtT5mjnY@public.gmane.org
----------------------------------------------------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: jerry.hoemann@hp.com
To: Matthew Garrett <matthew.garrett@nebula.com>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
keescook@chromium.org, hpa@zytor.com,
kexec <kexec@lists.infradead.org>
Subject: Re: [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions
Date: Wed, 4 Sep 2013 14:09:59 -0600 [thread overview]
Message-ID: <20130904200959.GE8540@anatevka.fc.hp.com> (raw)
In-Reply-To: <1378252218-18798-9-git-send-email-matthew.garrett@nebula.com>
On Tue, Sep 03, 2013 at 07:50:15PM -0400, Matthew Garrett wrote:
> kexec permits the loading and execution of arbitrary code in ring 0, which
> is something that module signing enforcement is meant to prevent. It makes
> sense to disable kexec in this situation.
>
> Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
Matthew,
Disabling kexec will disable kdump, correct?
Are there plans to enable kdump on a system where secure
boot is enabled?
thanks
Jerry
> ---
> kernel/kexec.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..3e2b63a 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -32,6 +32,7 @@
> #include <linux/vmalloc.h>
> #include <linux/swap.h>
> #include <linux/syscore_ops.h>
> +#include <linux/module.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>
> @@ -943,6 +944,13 @@ SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
> return -EPERM;
>
> /*
> + * kexec can be used to circumvent module loading restrictions, so
> + * prevent loading in that case
> + */
> + if (secure_modules())
> + return -EPERM;
> +
> + /*
> * Verify we have a legal set of flags
> * This leaves us room for future extensions.
> */
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
----------------------------------------------------------------------------
Jerry Hoemann Software Engineer Hewlett-Packard/MODL
3404 E Harmony Rd. MS 57 phone: (970) 898-1022
Ft. Collins, CO 80528 FAX: (970) 898-XXXX
email: jerry.hoemann@hp.com
----------------------------------------------------------------------------
next prev parent reply other threads:[~2013-09-04 20:09 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 23:50 (unknown), Matthew Garrett
2013-09-03 23:50 ` Matthew Garrett
2013-09-03 23:50 ` [PATCH V3 01/11] Add secure_modules() call Matthew Garrett
[not found] ` <1378252218-18798-2-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:45 ` James Morris
2013-09-04 0:45 ` James Morris
2013-09-05 2:14 ` joeyli
2013-09-05 2:14 ` joeyli
2013-09-03 23:50 ` [PATCH V3 02/11] PCI: Lock down BAR access when module security is enabled Matthew Garrett
[not found] ` <1378252218-18798-3-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:45 ` James Morris
2013-09-04 0:45 ` James Morris
2013-09-04 16:57 ` David Woodhouse
2013-09-04 16:57 ` David Woodhouse
[not found] ` <1378313861.4210.39.camel-W2I5cNIroUsVm/YvaOjsyQ@public.gmane.org>
2013-09-04 17:04 ` Matthew Garrett
2013-09-04 17:04 ` Matthew Garrett
2013-09-04 18:58 ` David Woodhouse
[not found] ` <1378321109.2627.9.camel-Fexsq3y4057IgHVZqg5X0TlWvGAXklZc@public.gmane.org>
2013-09-04 19:01 ` Matthew Garrett
2013-09-04 19:01 ` Matthew Garrett
2013-09-04 19:31 ` David Woodhouse
2013-09-04 19:31 ` David Woodhouse
2013-09-03 23:50 ` [PATCH V3 03/11] x86: Lock down IO port " Matthew Garrett
2013-09-04 0:45 ` James Morris
[not found] ` <1378252218-18798-4-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-05 3:52 ` H. Peter Anvin
2013-09-05 3:52 ` H. Peter Anvin
[not found] ` <5227FFE8.5050102-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-09-05 3:58 ` Matthew Garrett
2013-09-05 3:58 ` Matthew Garrett
2013-09-05 15:36 ` H. Peter Anvin
2013-09-05 15:36 ` H. Peter Anvin
2013-09-03 23:50 ` [PATCH V3 04/11] ACPI: Limit access to custom_method Matthew Garrett
[not found] ` <1378252218-18798-5-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:46 ` James Morris
2013-09-04 0:46 ` James Morris
2013-09-03 23:50 ` [PATCH V3 05/11] asus-wmi: Restrict debugfs interface when module loading is restricted Matthew Garrett
[not found] ` <1378252218-18798-6-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:46 ` James Morris
2013-09-04 0:46 ` James Morris
2013-09-03 23:50 ` [PATCH V3 06/11] Restrict /dev/mem and /dev/kmem " Matthew Garrett
[not found] ` <1378252218-18798-7-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:47 ` James Morris
2013-09-04 0:47 ` James Morris
[not found] ` <1378252218-18798-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-03 23:50 ` [PATCH V3 07/11] acpi: Ignore acpi_rsdp kernel parameter " Matthew Garrett
2013-09-03 23:50 ` Matthew Garrett
2013-09-03 23:50 ` [PATCH V3 11/11] Add option to automatically enforce module signatures when in Secure Boot mode Matthew Garrett
2013-09-03 23:50 ` Matthew Garrett
2013-09-05 3:13 ` joeyli
[not found] ` <1378252218-18798-12-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 1:42 ` James Morris
2013-09-04 1:42 ` James Morris
2013-09-04 1:42 ` Matthew Garrett
2013-09-04 1:42 ` Matthew Garrett
2013-09-05 8:24 ` joeyli
2013-09-05 8:24 ` joeyli
2013-09-05 10:16 ` Matt Fleming
2013-09-05 10:16 ` Matt Fleming
[not found] ` <20130905101649.GL28598-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-09-05 12:54 ` Matthew Garrett
2013-09-05 12:54 ` Matthew Garrett
2013-09-04 15:53 ` Kees Cook
2013-09-04 15:53 ` Re: Kees Cook
[not found] ` <CAGXu5jLCTU1MG4fYDzpT=TAP9DRAUuRuhZNB+edJsOzN4iXbDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-04 16:05 ` Re: Josh Boyer
2013-09-04 16:05 ` Re: Josh Boyer
2013-09-03 23:50 ` [PATCH V3 08/11] kexec: Disable at runtime if the kernel enforces module loading restrictions Matthew Garrett
[not found] ` <1378252218-18798-9-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:48 ` James Morris
2013-09-04 0:48 ` James Morris
2013-09-04 20:09 ` jerry.hoemann-VXdhtT5mjnY [this message]
2013-09-04 20:09 ` jerry.hoemann
2013-09-04 20:12 ` Matthew Garrett
2013-09-04 20:12 ` Matthew Garrett
2013-09-04 20:12 ` Matthew Garrett
2013-09-04 20:14 ` Josh Boyer
2013-09-04 20:14 ` Josh Boyer
2013-09-04 20:14 ` Josh Boyer
2013-09-08 6:40 ` Greg KH
2013-09-08 6:40 ` Greg KH
[not found] ` <20130908064027.GA3587-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-08 6:44 ` Matthew Garrett
2013-09-08 6:44 ` Matthew Garrett
2013-09-08 7:24 ` Greg KH
2013-09-08 7:24 ` Greg KH
[not found] ` <20130908072408.GA5092-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-08 14:40 ` Matthew Garrett
2013-09-08 14:40 ` Matthew Garrett
2013-09-08 15:51 ` Kees Cook
2013-09-08 15:51 ` Kees Cook
[not found] ` <CAGXu5jLwCt6RtQC+kxcUC69tMydx8DO2QWDv3jK6_mOyT_iNbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-08 16:18 ` Greg KH
2013-09-08 16:18 ` Greg KH
[not found] ` <20130908161859.GA18946-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-08 16:24 ` Matthew Garrett
2013-09-08 16:24 ` Matthew Garrett
2013-09-08 16:39 ` Greg KH
2013-09-08 16:39 ` Greg KH
[not found] ` <20130908163926.GA19665-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-08 16:59 ` Matthew Garrett
2013-09-08 16:59 ` Matthew Garrett
2013-09-08 17:22 ` Greg KH
2013-09-08 17:22 ` Greg KH
[not found] ` <20130908172249.GB20959-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-09-08 17:25 ` Matthew Garrett
2013-09-08 17:25 ` Matthew Garrett
2013-09-08 17:11 ` James Bottomley
2013-09-08 17:11 ` James Bottomley
[not found] ` <1378660284.2429.11.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2013-09-08 17:15 ` Matthew Garrett
2013-09-08 17:15 ` Matthew Garrett
2013-09-08 17:22 ` James Bottomley
2013-09-08 17:22 ` James Bottomley
[not found] ` <1378660975.2429.14.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2013-09-08 17:27 ` Matthew Garrett
2013-09-08 17:27 ` Matthew Garrett
2013-09-08 17:32 ` James Bottomley
2013-09-08 17:32 ` James Bottomley
[not found] ` <1378661576.2429.16.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2013-09-08 17:38 ` Matthew Garrett
2013-09-08 17:38 ` Matthew Garrett
2013-09-03 23:50 ` [PATCH V3 09/11] uswsusp: Disable when module loading is restricted Matthew Garrett
[not found] ` <1378252218-18798-10-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:48 ` James Morris
2013-09-04 0:48 ` James Morris
2013-09-05 3:20 ` joeyli
2013-09-05 3:20 ` joeyli
2013-09-03 23:50 ` [PATCH V3 10/11] x86: Restrict MSR access " Matthew Garrett
[not found] ` <1378252218-18798-11-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-04 0:49 ` James Morris
2013-09-04 0:49 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904200959.GE8540@anatevka.fc.hp.com \
--to=jerry.hoemann-vxdhtt5mjny@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.