All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Mikko Perttunen
	<mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/6] host1x: hdmi: Detect whether display is connected with HDMI or DVI
Date: Wed, 4 Sep 2013 23:59:03 +0200	[thread overview]
Message-ID: <20130904215902.GB4661@mithrandir> (raw)
In-Reply-To: <52277EBA.6030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

On Wed, Sep 04, 2013 at 12:40:58PM -0600, Stephen Warren wrote:
> On 08/28/2013 09:48 AM, Mikko Perttunen wrote:
> > Use EDID data to determine whether the display supports HDMI or just DVI.
> > This used to be hardcoded to be HDMI, which broke support for DVI displays
> > that couldn't understand the interspersed audio/other data.
> > 
> > If the EDID data isn't available, default to DVI, which should be a safer
> > choice.
> 
> This seems like a bug-fix that might even be worth CC: stable?

Possibly. The patch reaches deeply into some DRM structures, which I'd
like to avoid. I'll have another look to see if it can be done in a
slightly different way.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Mikko Perttunen <mperttunen@nvidia.com>,
	tbergstrom@nvidia.com, dri-devel@lists.freedesktop.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] host1x: hdmi: Detect whether display is connected with HDMI or DVI
Date: Wed, 4 Sep 2013 23:59:03 +0200	[thread overview]
Message-ID: <20130904215902.GB4661@mithrandir> (raw)
In-Reply-To: <52277EBA.6030105@wwwdotorg.org>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

On Wed, Sep 04, 2013 at 12:40:58PM -0600, Stephen Warren wrote:
> On 08/28/2013 09:48 AM, Mikko Perttunen wrote:
> > Use EDID data to determine whether the display supports HDMI or just DVI.
> > This used to be hardcoded to be HDMI, which broke support for DVI displays
> > that couldn't understand the interspersed audio/other data.
> > 
> > If the EDID data isn't available, default to DVI, which should be a safer
> > choice.
> 
> This seems like a bug-fix that might even be worth CC: stable?

Possibly. The patch reaches deeply into some DRM structures, which I'd
like to avoid. I'll have another look to see if it can be done in a
slightly different way.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-09-04 21:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28 15:48 [PATCH v2 0/6] HDMI support for Tegra114 Dalmore Mikko Perttunen
2013-08-28 15:48 ` Mikko Perttunen
2013-08-28 15:48 ` [PATCH v2 1/6] host1x: hdmi: Add Tegra114 support Mikko Perttunen
2013-08-28 15:48   ` Mikko Perttunen
     [not found]   ` <1377704922-2824-2-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-04 18:39     ` Stephen Warren
2013-09-04 18:39       ` Stephen Warren
2013-09-04 21:55       ` Thierry Reding
2013-08-28 15:48 ` [PATCH v2 2/6] host1x: hdmi: Detect whether display is connected with HDMI or DVI Mikko Perttunen
2013-08-28 15:48   ` Mikko Perttunen
     [not found]   ` <1377704922-2824-3-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-04 18:40     ` Stephen Warren
2013-09-04 18:40       ` Stephen Warren
     [not found]       ` <52277EBA.6030105-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-04 21:59         ` Thierry Reding [this message]
2013-09-04 21:59           ` Thierry Reding
2013-08-28 15:48 ` [PATCH v2 3/6] host1x: hdmi: Enable Vdd earlier for hotplug/DDC Mikko Perttunen
2013-08-28 15:48   ` Mikko Perttunen
     [not found]   ` <1377704922-2824-4-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-04 18:44     ` Stephen Warren
2013-09-04 18:44       ` Stephen Warren
     [not found]       ` <52277F90.40109-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-04 22:03         ` Mikko Perttunen
2013-09-04 22:03           ` Mikko Perttunen
     [not found]           ` <5227AE4F.8050603-/1wQRMveznE@public.gmane.org>
2013-09-04 22:24             ` Stephen Warren
2013-09-04 22:24               ` Stephen Warren
2013-08-28 15:48 ` [PATCH v2 4/6] clk: tegra114: Initialize clocks needed for HDMI Mikko Perttunen
2013-08-28 15:48   ` Mikko Perttunen
     [not found]   ` <1377704922-2824-5-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-04 18:45     ` Stephen Warren
2013-09-04 18:45       ` Stephen Warren
2013-08-28 15:48 ` [PATCH v2 5/6] ARM: tegra: Add host1x, DC and HDMI to Tegra114 device tree Mikko Perttunen
2013-08-28 15:48   ` Mikko Perttunen
     [not found]   ` <1377704922-2824-6-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-09-04 18:46     ` Stephen Warren
2013-09-04 18:46       ` Stephen Warren
     [not found] ` <1377704922-2824-1-git-send-email-mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-08-28 15:48   ` [PATCH v2 6/6] ARM: tegra: Add HDMI to Tegra114 Dalmore " Mikko Perttunen
2013-08-28 15:48     ` Mikko Perttunen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904215902.GB4661@mithrandir \
    --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.