All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Franklin S. Cooper Jr" <fcooper@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH 3/6 v3] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature
Date: Thu, 5 Sep 2013 14:11:40 -0400	[thread overview]
Message-ID: <20130905181140.GG27300@edge> (raw)
In-Reply-To: <1378397315-14333-1-git-send-email-fcooper@ti.com>

On Thu, Sep 05, 2013 at 11:08:34AM -0500, Franklin S. Cooper Jr wrote:
> * Do to the inability to keep the git repository intact the board port labs
>   recipe manually ran git clone which took a long time every time the recipe was
>   built.
> * Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the recipes can
>   now be treated like any other recipe and allow OE to handle the cloning and
>   unpacking.
> * This will significantly shorten the amount of time required to rebuild this
>   recipe.
> 
> Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> ---
> Version 3 changes:
> Use a specific commit instead of using AUTOREV
> 
> Version 2 changes:
> Split recipe into its own patch.
> Also use the kernel's license.
> 
>  .../board-port-labs/board-port-labs-linux_git.bb   |   35 ++++++++++++++++++++
>  1 files changed, 35 insertions(+), 0 deletions(-)
>  create mode 100644 meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> 
> diff --git a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> new file mode 100644
> index 0000000..4ed1adf
> --- /dev/null
> +++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_git.bb
> @@ -0,0 +1,35 @@
> +DESCRIPTION = "Git repositories containing sample board port code"
> +HOMEPAGE = "https://gitorious.org/sitara-board-port"
> +
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> +
> +inherit allarch
> +
> +CREATE_SRCIPK = "1"
> +SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-linux"
> +SRCIPK_PRESERVE_GIT = "true"
> +
> +PR = "r0"
> +
> +BRANCH = "master"
> +SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-linux.git;protocol=git;branch=${BRANCH}"
> +
> +SRCREV = "30df33e7134ab507a339b89a864256cabfbddea1"
> +
> +S = "${WORKDIR}/git"
> +
> +adjust_git_prepend() {
> +
> +    # Checkout a specific branch instead of a commit that is used by default
> +    git checkout ${BRANCH}

So, you are still doing AUTOREV, even though you no longer explicitly name it 
that way... :)

I was thinking if you agree to lock to a specific SRVREV, we don't need that 
whole adjust_git_prepend() part with branch checkout. Comments?


> +}
> +
> +do_configure() {
> +    :
> +}
> +
> +do_compile() {
> +    :
> +}
> +
> -- 
> 1.7.0.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  parent reply	other threads:[~2013-09-05 18:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 16:08 [PATCH 3/6 v3] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature Franklin S. Cooper Jr
2013-09-05 16:08 ` [PATCH 4/6 v3] board-port-labs-u-boot: " Franklin S. Cooper Jr
2013-09-05 18:11 ` Denys Dmytriyenko [this message]
2013-09-05 18:39   ` [PATCH 3/6 v3] board-port-labs-linux: " Cooper Jr., Franklin
2013-09-05 18:48     ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905181140.GG27300@edge \
    --to=denys@ti.com \
    --cc=fcooper@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.