Re: [PATCH 3/6 v3] board-port-labs-linux: Create new recipe using new sourceipk.bbclass feature

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Sep 05, 2013 at 02:39:09PM -0400, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Thursday, September 05, 2013 1:12 PM
> > To: Cooper Jr., Franklin
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH 3/6 v3] board-port-labs-linux: Create new
> > recipe using new sourceipk.bbclass feature
> > 
> > On Thu, Sep 05, 2013 at 11:08:34AM -0500, Franklin S. Cooper Jr wrote:
> > > * Do to the inability to keep the git repository intact the board port labs
> > >   recipe manually ran git clone which took a long time every time the recipe
> > was
> > >   built.
> > > * Using the new SRCIPK_PRESERVED_GIT feature in sourceipk.bbclass the
> > recipes can
> > >   now be treated like any other recipe and allow OE to handle the cloning and
> > >   unpacking.
> > > * This will significantly shorten the amount of time required to rebuild this
> > >   recipe.
> > >
> > > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > > ---
> > > Version 3 changes:
> > > Use a specific commit instead of using AUTOREV
> > >
> > > Version 2 changes:
> > > Split recipe into its own patch.
> > > Also use the kernel's license.
> > >
> > >  .../board-port-labs/board-port-labs-linux_git.bb   |   35
> > ++++++++++++++++++++
> > >  1 files changed, 35 insertions(+), 0 deletions(-)  create mode 100644
> > > meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linux_
> > > git.bb
> > >
> > > diff --git
> > > a/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linu
> > > x_git.bb
> > > b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-linu
> > > x_git.bb
> > > new file mode 100644
> > > index 0000000..4ed1adf
> > > --- /dev/null
> > > +++ b/meta-arago-distro/recipes-tisdk/board-port-labs/board-port-labs-
> > > +++ linux_git.bb
> > > @@ -0,0 +1,35 @@
> > > +DESCRIPTION = "Git repositories containing sample board port code"
> > > +HOMEPAGE = "https://gitorious.org/sitara-board-port"
> > > +
> > > +LICENSE = "GPLv2"
> > > +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> > > +
> > > +inherit allarch
> > > +
> > > +CREATE_SRCIPK = "1"
> > > +SRCIPK_INSTALL_DIR = "board-support/board-port-labs/sitara-board-port-
> > linux"
> > > +SRCIPK_PRESERVE_GIT = "true"
> > > +
> > > +PR = "r0"
> > > +
> > > +BRANCH = "master"
> > > +SRC_URI = "git://gitorious.org/sitara-board-port/sitara-board-port-
> > linux.git;protocol=git;branch=${BRANCH}"
> > > +
> > > +SRCREV = "30df33e7134ab507a339b89a864256cabfbddea1"
> > > +
> > > +S = "${WORKDIR}/git"
> > > +
> > > +adjust_git_prepend() {
> > > +
> > > +    # Checkout a specific branch instead of a commit that is used by default
> > > +    git checkout ${BRANCH}
> > 
> > So, you are still doing AUTOREV, even though you no longer explicitly name it
> > that way... :)
> [Franklin] Never thought of it that way. :)
> > 
> > I was thinking if you agree to lock to a specific SRVREV, we don't need that
> > whole adjust_git_prepend() part with branch checkout. Comments?
> [Franklin] 
> The only reason I am doing this is so someone will know exactly what branch 
> they are on when looking at the git repo packaged by sourceipk.
> Without that code if they did a git status they would see "Not currently on 
> any branch". By checking out the specific branch now they will see "# On 
> branch master" which people tend to expect. So it's more a cosmetic change 
> but does mimic how users see the board port git repositories in previous 
> sdks.

Ah, I see what you are saying. I think you are right - if we don't pull or 
fetch after a specific branch is checked out, then we should stay on the same 
commit... Ok, I'll take it.


> > 
> > 
> > > +}
> > > +
> > > +do_configure() {
> > > +    :
> > > +}
> > > +
> > > +do_compile() {
> > > +    :
> > > +}
> > > +
> > > --
> > > 1.7.0.4
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago