All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h
Date: Thu, 5 Sep 2013 12:04:07 -0700	[thread overview]
Message-ID: <20130905190407.GA603@infradead.org> (raw)
In-Reply-To: <1378382015-16026-2-git-send-email-david@fromorbit.com>

On Thu, Sep 05, 2013 at 09:53:33PM +1000, Dave Chinner wrote:
> All of the buffer operations structures are needed to be exported
> for xfs_db, so move them all to a common location rather than
> spreading them all over the place. They are verifying the on-disk
> format, so xfs_format.h is as good a place as any.
> 
> Don't move the dir2 buffer verifiers - they are already shared in a
> "central" place for all the dir2 and moving them just requires
> adding more include files...

Please only keep the actual format in the _format.h headers and use
a different shared header for incore bits that can be shared.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-09-05 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 11:53 [PATCH 0/3] xfs: more code movement for userspace Dave Chinner
2013-09-05 11:53 ` [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h Dave Chinner
2013-09-05 19:04   ` Christoph Hellwig [this message]
2013-09-05 23:54     ` Dave Chinner
2013-09-06 16:27       ` Christoph Hellwig
2013-09-06 21:55         ` Dave Chinner
2013-09-05 11:53 ` [PATCH 2/3] xfs: unify directory/attribute format definitions Dave Chinner
2013-09-05 11:53 ` [PATCH 3/3] xfs: split dquot buffer operations out Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905190407.GA603@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.