From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h
Date: Sat, 7 Sep 2013 07:55:00 +1000 [thread overview]
Message-ID: <20130906215459.GG12541@dastard> (raw)
In-Reply-To: <20130906162701.GA9994@infradead.org>
On Fri, Sep 06, 2013 at 09:27:01AM -0700, Christoph Hellwig wrote:
> On Fri, Sep 06, 2013 at 09:54:12AM +1000, Dave Chinner wrote:
> > Fair enough - I thought about that, but then realised we don't
> > really have any "global" shared header files that fit this purpose.
> > The only two really are xfs_fs.h - which is used for ioctl interface
> > definitions - and xfs_types.h which is used for type definitions,
> > not structure instances...
> >
> > So I'm not really sure where we'd put something like this without
> > creating a new header file, and I don't really want to do that,
> > either.
>
> We might need a new one, the headers still need major work anyway.
>
> If we start with
>
> xfs*_format.h - purely disk format
> xfs_fs.h - ioctl and userspace ABI constants
>
> an
>
> xfs_shared.h
>
> and
> xfs_kernel.h
OK. I'm not a great fan of the "xfs_shared.h" name, I'll see if I
can come up with something better....
> seem like logical additions to move most of the misc headers to instead
> of all the silly ones for just a handful or two worth of prototypes.
>
> Note that a few non-format bits already sneaked into xfs_format.h
> unfortunately, guess I need to watch more closely :)
They did, for the same reason as I put these ones there. I'll move
them to the "xfs_shared.h" once I create it....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-06 21:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 11:53 [PATCH 0/3] xfs: more code movement for userspace Dave Chinner
2013-09-05 11:53 ` [PATCH 1/3] xfs: move buf_ops externs to a xfs_format.h Dave Chinner
2013-09-05 19:04 ` Christoph Hellwig
2013-09-05 23:54 ` Dave Chinner
2013-09-06 16:27 ` Christoph Hellwig
2013-09-06 21:55 ` Dave Chinner [this message]
2013-09-05 11:53 ` [PATCH 2/3] xfs: unify directory/attribute format definitions Dave Chinner
2013-09-05 11:53 ` [PATCH 3/3] xfs: split dquot buffer operations out Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906215459.GG12541@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.