All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Porter <matt.porter@linaro.org>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: Mark Jackson <mpfj-list@newflow.co.uk>,
	tony@atomide.com, Mugunthan V N <mugunthanvnm@ti.com>,
	linux-omap@vger.kernel.org, netdev@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, hvaibhav@ti.com,
	richardcochran@gmail.com, Olof Johansson <olof@lixom.net>,
	Kevin Hilman <khilman@linaro.org>,
	michal.bachraty@gmail.com, michal.bachraty@streamunlimited.com
Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Date: Thu, 5 Sep 2013 16:16:39 -0400	[thread overview]
Message-ID: <20130905201637.GB10973@ohporter.com> (raw)
In-Reply-To: <871u70bd95.fsf@dell.be.48ers.dk>

On Mon, Jul 15, 2013 at 07:31:18AM +0200, Peter Korsgaard wrote:
> >>>>> "Mark" == Mark Jackson <mpfj-list@newflow.co.uk> writes:
> 
> Hi,
> 
>  Mark> On 08/07/13 13:42, Mark Jackson wrote:
>  >> On 18/01/13 05:14, Mugunthan V N wrote:
>  >>> On 1/18/2013 3:48 AM, Peter Korsgaard wrote:
>  >>>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old
>  >>>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot
>  >>>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the
>  >>>> CPSW slaves, causing the driver to use a random hwaddr, which is some times
>  >>>> troublesome.
>  >>>> 
>  >>>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes
>  >>>> more sense to default to these rather than random ones. Add a fixup step
>  >>>> which adds mac-address dt properties using the efuse addresses if the DTB
>  >>>> didn't contain valid ones.
>  >>>> 
>  >>>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>  >>> 
>  >>> This implementation looks fine.
>  >>> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
>  >> 
>  >> Tested-by: Mark Jackson <mpfj-list@newflow.co.uk>
> 
>  Mark> Is this ever going to be put into the mainline code ?
> 
> Good question. Tony, could you please pick this up? It has been pending
> since January and has a number of acks.
> 
> Do you want me to resend?

Also working nicely here on 3.11.

Tested-by: Matt Porter <matt.porter@linaro.org>

Kevin or Olof: can you apply? Seems to be continuing no response after
Ack back in January.

-Matt

  reply	other threads:[~2013-09-05 20:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 22:18 [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Peter Korsgaard
     [not found] ` <1358461134-13452-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
2013-01-18  5:14   ` Mugunthan V N
     [not found]     ` <50F8DA3A.3090406-l0cyMroinI0@public.gmane.org>
2013-01-18  8:26       ` Michal Bachraty
2013-07-08 12:42     ` Mark Jackson
2013-07-12 14:33       ` Mark Jackson
2013-07-15  5:31         ` Peter Korsgaard
2013-07-15  5:31           ` Peter Korsgaard
2013-09-05 20:16           ` Matt Porter [this message]
2013-09-05 20:22             ` Olof Johansson
2013-09-05 21:08               ` [PATCH RESEND] " Peter Korsgaard
2013-09-05 21:38                 ` Peter Korsgaard
2013-09-05 21:42                 ` [PATCHv2 " Peter Korsgaard
2013-09-05 22:07                   ` Olof Johansson
2013-09-06  8:44                     ` Peter Korsgaard
2013-09-05 21:08               ` [PATCHv2] " Peter Korsgaard
2013-09-05 21:08                 ` Peter Korsgaard
2013-09-05 20:11       ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905201637.GB10973@ohporter.com \
    --to=matt.porter@linaro.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=hvaibhav@ti.com \
    --cc=jacmet@sunsite.dk \
    --cc=khilman@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=michal.bachraty@gmail.com \
    --cc=michal.bachraty@streamunlimited.com \
    --cc=mpfj-list@newflow.co.uk \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=richardcochran@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.