From: Mark Jackson <mpfj-list@newflow.co.uk>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Peter Korsgaard <jacmet@sunsite.dk>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, hvaibhav@ti.com,
richardcochran@gmail.com, tony@atomide.com,
michal.bachraty@gmail.com, michal.bachraty@streamunlimited.com
Subject: Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Date: Mon, 08 Jul 2013 13:42:04 +0100 [thread overview]
Message-ID: <51DAB39C.7090106@newflow.co.uk> (raw)
In-Reply-To: <50F8DA3A.3090406@ti.com>
On 18/01/13 05:14, Mugunthan V N wrote:
> On 1/18/2013 3:48 AM, Peter Korsgaard wrote:
>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old
>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot
>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the
>> CPSW slaves, causing the driver to use a random hwaddr, which is some times
>> troublesome.
>>
>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes
>> more sense to default to these rather than random ones. Add a fixup step
>> which adds mac-address dt properties using the efuse addresses if the DTB
>> didn't contain valid ones.
>>
>> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
>>
>
> This implementation looks fine.
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Tested-by: Mark Jackson <mpfj-list@newflow.co.uk>
next prev parent reply other threads:[~2013-07-08 12:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 22:18 [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt Peter Korsgaard
[not found] ` <1358461134-13452-1-git-send-email-jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>
2013-01-18 5:14 ` Mugunthan V N
[not found] ` <50F8DA3A.3090406-l0cyMroinI0@public.gmane.org>
2013-01-18 8:26 ` Michal Bachraty
2013-07-08 12:42 ` Mark Jackson [this message]
2013-07-12 14:33 ` Mark Jackson
2013-07-15 5:31 ` Peter Korsgaard
2013-07-15 5:31 ` Peter Korsgaard
2013-09-05 20:16 ` Matt Porter
2013-09-05 20:22 ` Olof Johansson
2013-09-05 21:08 ` [PATCH RESEND] " Peter Korsgaard
2013-09-05 21:38 ` Peter Korsgaard
2013-09-05 21:42 ` [PATCHv2 " Peter Korsgaard
2013-09-05 22:07 ` Olof Johansson
2013-09-06 8:44 ` Peter Korsgaard
2013-09-05 21:08 ` [PATCHv2] " Peter Korsgaard
2013-09-05 21:08 ` Peter Korsgaard
2013-09-05 20:11 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DAB39C.7090106@newflow.co.uk \
--to=mpfj-list@newflow.co.uk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hvaibhav@ti.com \
--cc=jacmet@sunsite.dk \
--cc=linux-omap@vger.kernel.org \
--cc=michal.bachraty@gmail.com \
--cc=michal.bachraty@streamunlimited.com \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.