* [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
@ 2013-09-05 9:08 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2013-09-05 9:08 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel, Geert Uytterhoeven
ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/sparc/kernel/ptrace_64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/kernel/ptrace_64.c b/arch/sparc/kernel/ptrace_64.c
index 7ff45e4..8e7e2f9 100644
--- a/arch/sparc/kernel/ptrace_64.c
+++ b/arch/sparc/kernel/ptrace_64.c
@@ -14,6 +14,7 @@
#include <linux/sched.h>
#include <linux/mm.h>
#include <linux/errno.h>
+#include <linux/export.h>
#include <linux/ptrace.h>
#include <linux/user.h>
#include <linux/smp.h>
@@ -116,6 +117,7 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
preempt_enable();
}
+EXPORT_SYMBOL(flush_ptrace_access);
static int get_from_target(struct task_struct *target, unsigned long uaddr,
void *kbuf, int len)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
@ 2013-09-05 9:08 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2013-09-05 9:08 UTC (permalink / raw)
To: David S. Miller; +Cc: sparclinux, linux-kernel, Geert Uytterhoeven
ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/sparc/kernel/ptrace_64.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/kernel/ptrace_64.c b/arch/sparc/kernel/ptrace_64.c
index 7ff45e4..8e7e2f9 100644
--- a/arch/sparc/kernel/ptrace_64.c
+++ b/arch/sparc/kernel/ptrace_64.c
@@ -14,6 +14,7 @@
#include <linux/sched.h>
#include <linux/mm.h>
#include <linux/errno.h>
+#include <linux/export.h>
#include <linux/ptrace.h>
#include <linux/user.h>
#include <linux/smp.h>
@@ -116,6 +117,7 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
preempt_enable();
}
+EXPORT_SYMBOL(flush_ptrace_access);
static int get_from_target(struct task_struct *target, unsigned long uaddr,
void *kbuf, int len)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
2013-09-05 9:08 ` Geert Uytterhoeven
@ 2013-09-06 12:56 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-09-06 12:56 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, sparclinux, linux-kernel
On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> undefined!
This seems to be more copy_to_user_page fallout, so instead of all these
arch patches we should figure out why lustre absolutely wants to use
this API that so far has been for core MM code only.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
@ 2013-09-06 12:56 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-09-06 12:56 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, sparclinux, linux-kernel
On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> undefined!
This seems to be more copy_to_user_page fallout, so instead of all these
arch patches we should figure out why lustre absolutely wants to use
this API that so far has been for core MM code only.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
2013-09-06 12:56 ` Christoph Hellwig
@ 2013-09-06 12:58 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-09-06 12:58 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, sparclinux, linux-kernel
On Fri, Sep 06, 2013 at 05:56:13AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> > ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> > undefined!
>
> This seems to be more copy_to_user_page fallout, so instead of all these
> arch patches we should figure out why lustre absolutely wants to use
> this API that so far has been for core MM code only.
Looking at the code is seems to be for a reimplementation of
__access_remote_vm. So at very least it should use that, but I still
requiestion why it's doing that at all.
Geert, please don't just export stuff for staging/ use only. Code
wouldn't be in staging if it weren't a steaming pile of junk, so
adjusting anyting in the real tree for it needs proper discussion first.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre)
@ 2013-09-06 12:58 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2013-09-06 12:58 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, sparclinux, linux-kernel
On Fri, Sep 06, 2013 at 05:56:13AM -0700, Christoph Hellwig wrote:
> On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote:
> > ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
> > undefined!
>
> This seems to be more copy_to_user_page fallout, so instead of all these
> arch patches we should figure out why lustre absolutely wants to use
> this API that so far has been for core MM code only.
Looking at the code is seems to be for a reimplementation of
__access_remote_vm. So at very least it should use that, but I still
requiestion why it's doing that at all.
Geert, please don't just export stuff for staging/ use only. Code
wouldn't be in staging if it weren't a steaming pile of junk, so
adjusting anyting in the real tree for it needs proper discussion first.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-06 12:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 9:08 [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre) Geert Uytterhoeven
2013-09-05 9:08 ` Geert Uytterhoeven
2013-09-06 12:56 ` Christoph Hellwig
2013-09-06 12:56 ` Christoph Hellwig
2013-09-06 12:58 ` Christoph Hellwig
2013-09-06 12:58 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.