* [meta-networking][PATCH] inetutils: Remove empty usr/lib
@ 2013-09-05 21:02 Khem Raj
2013-09-05 21:18 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-09-05 21:02 UTC (permalink / raw)
To: openembedded-devel
This directory is empty and is flagged by QA checker
ERROR: QA Issue: inetutils: Files/directories were installed but not
shipped
/usr/lib
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
index 7c7343e..e371ae5 100644
--- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
+++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
@@ -70,6 +70,8 @@ do_install_append () {
cp ${WORKDIR}/telnet.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/telnet
cp ${WORKDIR}/tftpd.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/tftpd
rm -rf ${D}${libexecdir}/
+ # remove usr/lib if empty
+ rmdir ${D}${libdir}
}
PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
--
1.8.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] inetutils: Remove empty usr/lib
2013-09-05 21:02 [meta-networking][PATCH] inetutils: Remove empty usr/lib Khem Raj
@ 2013-09-05 21:18 ` Martin Jansa
2013-09-05 22:32 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2013-09-05 21:18 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
On Thu, Sep 05, 2013 at 02:02:55PM -0700, Khem Raj wrote:
> This directory is empty and is flagged by QA checker
>
> ERROR: QA Issue: inetutils: Files/directories were installed but not
> shipped
> /usr/lib
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> index 7c7343e..e371ae5 100644
> --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> @@ -70,6 +70,8 @@ do_install_append () {
> cp ${WORKDIR}/telnet.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/telnet
> cp ${WORKDIR}/tftpd.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/tftpd
> rm -rf ${D}${libexecdir}/
> + # remove usr/lib if empty
> + rmdir ${D}${libdir}
The comment suggests missing --ignore-fail-on-non-empty
> }
>
> PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
> --
> 1.8.4
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] inetutils: Remove empty usr/lib
2013-09-05 21:18 ` Martin Jansa
@ 2013-09-05 22:32 ` Khem Raj
2013-09-06 13:41 ` Joe MacDonald
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-09-05 22:32 UTC (permalink / raw)
To: openembeded-devel
On Thu, Sep 5, 2013 at 2:18 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Sep 05, 2013 at 02:02:55PM -0700, Khem Raj wrote:
>> This directory is empty and is flagged by QA checker
>>
>> ERROR: QA Issue: inetutils: Files/directories were installed but not
>> shipped
>> /usr/lib
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
>> index 7c7343e..e371ae5 100644
>> --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
>> +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
>> @@ -70,6 +70,8 @@ do_install_append () {
>> cp ${WORKDIR}/telnet.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/telnet
>> cp ${WORKDIR}/tftpd.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/tftpd
>> rm -rf ${D}${libexecdir}/
>> + # remove usr/lib if empty
>> + rmdir ${D}${libdir}
>
> The comment suggests missing --ignore-fail-on-non-empty
hmmm,I would add it when that happens and also then take opportunity
to make sure that they are packaged
into right packages, so far I have not found a case where its populated.
>
>> }
>>
>> PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
>> --
>> 1.8.4
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
> --
> Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] inetutils: Remove empty usr/lib
2013-09-05 22:32 ` Khem Raj
@ 2013-09-06 13:41 ` Joe MacDonald
0 siblings, 0 replies; 4+ messages in thread
From: Joe MacDonald @ 2013-09-06 13:41 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 2435 bytes --]
[Re: [oe] [meta-networking][PATCH] inetutils: Remove empty usr/lib] On 13.09.05 (Thu 15:32) Khem Raj wrote:
> On Thu, Sep 5, 2013 at 2:18 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> > On Thu, Sep 05, 2013 at 02:02:55PM -0700, Khem Raj wrote:
> >> This directory is empty and is flagged by QA checker
> >>
> >> ERROR: QA Issue: inetutils: Files/directories were installed but not
> >> shipped
> >> /usr/lib
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> >> index 7c7343e..e371ae5 100644
> >> --- a/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> >> +++ b/meta-networking/recipes-connectivity/inetutils/inetutils_1.9.1.bb
> >> @@ -70,6 +70,8 @@ do_install_append () {
> >> cp ${WORKDIR}/telnet.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/telnet
> >> cp ${WORKDIR}/tftpd.xinetd.inetutils ${D}/${sysconfdir}/xinetd.d/tftpd
> >> rm -rf ${D}${libexecdir}/
> >> + # remove usr/lib if empty
> >> + rmdir ${D}${libdir}
> >
> > The comment suggests missing --ignore-fail-on-non-empty
>
> hmmm,I would add it when that happens and also then take opportunity
> to make sure that they are packaged
> into right packages, so far I have not found a case where its populated.
Yep, I'm sold.
Merged.
-J.
>
> >
> >> }
> >>
> >> PACKAGES =+ "${PN}-ping ${PN}-ping6 ${PN}-hostname ${PN}-ifconfig \
> >> --
> >> 1.8.4
> >>
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> > --
> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
> >
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
-Joe MacDonald.
:wq
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-06 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 21:02 [meta-networking][PATCH] inetutils: Remove empty usr/lib Khem Raj
2013-09-05 21:18 ` Martin Jansa
2013-09-05 22:32 ` Khem Raj
2013-09-06 13:41 ` Joe MacDonald
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.