All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Rob Landley <rob@landley.net>,
	linux-pci@vger.kernel.org, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH] PCI: clean up pci_find_slot() in pci.txt
Date: Fri, 6 Sep 2013 16:58:35 -0600	[thread overview]
Message-ID: <20130906225835.GA12956@google.com> (raw)
In-Reply-To: <1378103680-42500-1-git-send-email-wangyijing@huawei.com>

On Mon, Sep 02, 2013 at 02:34:40PM +0800, Yijing Wang wrote:
> Pci_find_slot() has been removed from the kernel,
> clean up its description in pci.txt
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Applied to my pci/misc branch for v3.13.  Thanks!

> ---
>  Documentation/PCI/pci.txt |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/PCI/pci.txt b/Documentation/PCI/pci.txt
> index bccf602..ac39338 100644
> --- a/Documentation/PCI/pci.txt
> +++ b/Documentation/PCI/pci.txt
> @@ -525,8 +525,10 @@ corresponding register block for you.
>  6. Other interesting functions
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> -pci_find_slot()			Find pci_dev corresponding to given bus and
> -				slot numbers.
> +pci_get_domain_bus_and_slot()	Find pci_dev corresponding to given domain,
> +                        bus and slot and number. If the device is
> +                        found, its reference count is increased and
> +                        return the pci_dev pointer.

I fixed this indentation to match the surrounding text.

>  pci_set_power_state()		Set PCI Power Management state (0=D0 ... 3=D3)
>  pci_find_capability()		Find specified capability in device's capability
>  				list.
> @@ -582,7 +584,6 @@ having sane locking.
>  
>  pci_find_device()	Superseded by pci_get_device()
>  pci_find_subsys()	Superseded by pci_get_subsys()
> -pci_find_slot()		Superseded by pci_get_slot()

I kept this mention and updated the replacement to be
pci_get_domain_bus_and_slot().  The whole point of this section is
to describe things that are no longer in the kernel but might be
seen in old drivers.

>  
>  The alternative is the traditional PCI device driver that walks PCI
> -- 
> 1.7.1
> 
> 

      reply	other threads:[~2013-09-06 22:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  6:34 [PATCH] PCI: clean up pci_find_slot() in pci.txt Yijing Wang
2013-09-06 22:58 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130906225835.GA12956@google.com \
    --to=bhelgaas@google.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=rob@landley.net \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.