All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PCI: clean up pci_find_slot() in pci.txt
@ 2013-09-02  6:34 Yijing Wang
  2013-09-06 22:58 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Yijing Wang @ 2013-09-02  6:34 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: Rob Landley, linux-pci, Yijing Wang, Hanjun Guo

Pci_find_slot() has been removed from the kernel,
clean up its description in pci.txt

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
---
 Documentation/PCI/pci.txt |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Documentation/PCI/pci.txt b/Documentation/PCI/pci.txt
index bccf602..ac39338 100644
--- a/Documentation/PCI/pci.txt
+++ b/Documentation/PCI/pci.txt
@@ -525,8 +525,10 @@ corresponding register block for you.
 6. Other interesting functions
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-pci_find_slot()			Find pci_dev corresponding to given bus and
-				slot numbers.
+pci_get_domain_bus_and_slot()	Find pci_dev corresponding to given domain,
+                        bus and slot and number. If the device is
+                        found, its reference count is increased and
+                        return the pci_dev pointer.
 pci_set_power_state()		Set PCI Power Management state (0=D0 ... 3=D3)
 pci_find_capability()		Find specified capability in device's capability
 				list.
@@ -582,7 +584,6 @@ having sane locking.
 
 pci_find_device()	Superseded by pci_get_device()
 pci_find_subsys()	Superseded by pci_get_subsys()
-pci_find_slot()		Superseded by pci_get_slot()
 
 
 The alternative is the traditional PCI device driver that walks PCI
-- 
1.7.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: clean up pci_find_slot() in pci.txt
  2013-09-02  6:34 [PATCH] PCI: clean up pci_find_slot() in pci.txt Yijing Wang
@ 2013-09-06 22:58 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2013-09-06 22:58 UTC (permalink / raw)
  To: Yijing Wang; +Cc: Rob Landley, linux-pci, Hanjun Guo

On Mon, Sep 02, 2013 at 02:34:40PM +0800, Yijing Wang wrote:
> Pci_find_slot() has been removed from the kernel,
> clean up its description in pci.txt
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Applied to my pci/misc branch for v3.13.  Thanks!

> ---
>  Documentation/PCI/pci.txt |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/PCI/pci.txt b/Documentation/PCI/pci.txt
> index bccf602..ac39338 100644
> --- a/Documentation/PCI/pci.txt
> +++ b/Documentation/PCI/pci.txt
> @@ -525,8 +525,10 @@ corresponding register block for you.
>  6. Other interesting functions
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> -pci_find_slot()			Find pci_dev corresponding to given bus and
> -				slot numbers.
> +pci_get_domain_bus_and_slot()	Find pci_dev corresponding to given domain,
> +                        bus and slot and number. If the device is
> +                        found, its reference count is increased and
> +                        return the pci_dev pointer.

I fixed this indentation to match the surrounding text.

>  pci_set_power_state()		Set PCI Power Management state (0=D0 ... 3=D3)
>  pci_find_capability()		Find specified capability in device's capability
>  				list.
> @@ -582,7 +584,6 @@ having sane locking.
>  
>  pci_find_device()	Superseded by pci_get_device()
>  pci_find_subsys()	Superseded by pci_get_subsys()
> -pci_find_slot()		Superseded by pci_get_slot()

I kept this mention and updated the replacement to be
pci_get_domain_bus_and_slot().  The whole point of this section is
to describe things that are no longer in the kernel but might be
seen in old drivers.

>  
>  The alternative is the traditional PCI device driver that walks PCI
> -- 
> 1.7.1
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-06 22:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-02  6:34 [PATCH] PCI: clean up pci_find_slot() in pci.txt Yijing Wang
2013-09-06 22:58 ` Bjorn Helgaas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.