Re: [PATCH v4] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state

[Gleb Natapov <gleb@redhat.com>]

On Tue, Sep 03, 2013 at 09:11:45PM +0200, Jan Kiszka wrote:
> kvm_set_cr0 performs checks on the state transition that may prevent
> loading L1's cr0. For now we rely on the hardware to catch invalid
> states loaded by L1 into its VMCS. Still, consistency checks on the host
> state part of the VMCS on guest entry will have to be improved later on.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  arch/x86/kvm/vmx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 1f1da43..b43d1f8 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -8186,7 +8186,7 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu,
>  	 * fpu_active (which may have changed).
>  	 * Note that vmx_set_cr0 refers to efer set above.
>  	 */
> -	kvm_set_cr0(vcpu, vmcs12->host_cr0);
> +	vmx_set_cr0(vcpu, vmcs12->host_cr0);
>  	/*
>  	 * If we did fpu_activate()/fpu_deactivate() during L2's run, we need
>  	 * to apply the same changes to L1's vmcs. We just set cr0 correctly,

For this one and 2,4,6 of the series:

Reviewed-by: Gleb Natapov <gleb@redhat.com>

--
			Gleb.