From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm <kvm@vger.kernel.org>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Yang Zhang <yang.z.zhang@intel.com>,
Arthur Chunqi Li <yzt356@gmail.com>
Subject: Re: [PATCH v3 3/6] KVM: nVMX: Load nEPT state after EFER
Date: Mon, 02 Sep 2013 20:20:18 +0200 [thread overview]
Message-ID: <5224D6E2.5040605@siemens.com> (raw)
In-Reply-To: <20130902180935.GJ10142@redhat.com>
On 2013-09-02 20:09, Gleb Natapov wrote:
> On Mon, Sep 02, 2013 at 07:58:30PM +0200, Jan Kiszka wrote:
>> On 2013-09-02 15:16, Gleb Natapov wrote:
>>> On Thu, Aug 08, 2013 at 04:26:30PM +0200, Jan Kiszka wrote:
>>>> We need to update EFER.NX before building the nEPT state via
>>>> nested_ept_init_mmu_context. Otherwise, we risk to create an MMU context
>>>> that claims to have NX disabled while the guest EPT used NX. This will
>>>> cause spurious faults for L2.
>>>>
>>> Hmm, I do not see how nested ept mmu depends on guests EFER.NX setting.
>>> It just sets mmu->nx to true.
>>
>> Don't ask me for the details behind this, but update_permission_bitmask
>> called by kvm_init_shadow_ept_mmu is using it e.g. And the
> It uses it only in !ept case though and never looks at a guest setting
> as far as I can tell. Is it possible that this was an artifact of all
> nEPT code and the latest one does not need this patch?
Hmm, possibly. Let me recheck, hope I can find the reproduction pattern
again...
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2013-09-02 18:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 14:26 [PATCH v3 0/6] KVM: nVMX: Enable unrestricted guest mode and fix some nEPT issues Jan Kiszka
2013-08-08 14:26 ` [PATCH v3 1/6] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state Jan Kiszka
2013-09-02 8:21 ` Gleb Natapov
2013-09-02 9:06 ` Jan Kiszka
2013-09-02 9:36 ` Gleb Natapov
2013-09-03 17:44 ` Jan Kiszka
2013-09-03 17:55 ` Gleb Natapov
2013-09-03 19:11 ` [PATCH v4] " Jan Kiszka
2013-09-08 8:57 ` Gleb Natapov
2013-09-10 13:14 ` [PATCH v3 1/6] " Arthur Chunqi Li
2013-09-10 13:26 ` Paolo Bonzini
2013-09-15 11:01 ` Gleb Natapov
2013-08-08 14:26 ` [PATCH v3 2/6] KVM: nVMX: Do not set identity page map for L2 Jan Kiszka
2013-08-08 14:26 ` [PATCH v3 3/6] KVM: nVMX: Load nEPT state after EFER Jan Kiszka
2013-09-02 13:16 ` Gleb Natapov
2013-09-02 17:58 ` Jan Kiszka
2013-09-02 18:09 ` Gleb Natapov
2013-09-02 18:20 ` Jan Kiszka [this message]
2013-09-02 18:38 ` Jan Kiszka
2013-08-08 14:26 ` [PATCH v3 4/6] KVM: nVMX: Implement support for EFER saving on VM-exit Jan Kiszka
2013-08-08 14:26 ` [PATCH v3 5/6] KVM: nVMX: Update mmu.base_role.nxe after EFER loading on VM-entry/exit Jan Kiszka
2013-09-03 8:39 ` Gleb Natapov
2013-09-03 8:51 ` Jan Kiszka
2013-09-03 9:04 ` Gleb Natapov
2013-09-03 9:32 ` Jan Kiszka
2013-08-08 14:26 ` [PATCH v3 6/6] KVM: nVMX: Enable unrestricted guest mode support Jan Kiszka
2013-08-25 6:46 ` [PATCH v3 0/6] KVM: nVMX: Enable unrestricted guest mode and fix some nEPT issues Jan Kiszka
2013-08-25 10:01 ` Paolo Bonzini
2013-08-27 11:18 ` Gleb Natapov
2013-09-12 16:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5224D6E2.5040605@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=gleb@redhat.com \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yang.z.zhang@intel.com \
--cc=yzt356@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.