[Buildroot] [PATCH v2 2/7] sunxi-cedarx: bump to newer version, use armel2 binaries, add demo

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Spenser Gilliland,

It'd be great if your patches were split in a slightly more
fine-grained fashion. I.e this patch should have been three patches,
for the three different things you mention in the patch title.

On Thu,  5 Sep 2013 23:25:16 -0500, Spenser Gilliland wrote:
>  SUNXI_CEDARX_INSTALL_STAGING = YES
> @@ -14,7 +14,12 @@ SUNXI_CEDARX_CONFIGURE_OPTS = \
>  
>  ifeq ($(BR2_ARM_EABIHF),y)
>  SUNXI_CEDARX_BIN_DIR = $(@D)/libcedarv/linux-armhf
> -# libavheap.so is only available on EABIHF
> +SUNXI_CEDARX_SAMPLE_LOC = $(SUNXI_CEDARX_BIN_DIR)/sample/ve
> +else
> +SUNXI_CEDARX_BIN_DIR = $(@D)/libcedarv/linux-armel2
> +SUNXI_CEDARX_SAMPLE_LOC = $(SUNXI_CEDARX_BIN_DIR)/sample/output/ve
> +endif

I was confused by this for a while, but now I understand: since you've
bumped the version, the libavheap.so library is now available for
non-EABIhf toolchains.

BTW, silly from the cedarx people that the sample binary is not in the
same location between EABIhf and EABI.

Also, what is the difference between the linux-armel2 and linux-armel
directories in the CedarX stuff?

So, essentially, patch looks good to me.

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com