From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 4/7] mesa3d: modularize and bump to version 9.1.6
Date: Sun, 8 Sep 2013 20:30:51 +0200 [thread overview]
Message-ID: <20130908203051.63b7055d@skate> (raw)
In-Reply-To: <1378441521-10050-5-git-send-email-spenser@gillilanding.com>
Dear Spenser Gilliland,
On Thu, 5 Sep 2013 23:25:18 -0500, Spenser Gilliland wrote:
>
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
> package/mesa3d/Config.in | 177 ++++++++++++++++++++-
> package/mesa3d/mesa3d-cross-glsl-compiler.patch | 41 +++++
> package/mesa3d/mesa3d-gbm-without-dri.patch | 30 ++++
> package/mesa3d/mesa3d-uclibc-locale.patch | 56 -------
> package/mesa3d/mesa3d.mk | 115 +++++++++++--
> package/opengl/Config.in | 3 +
> package/opengl/libegl/libegl.mk | 4 +
> package/opengl/libgl/libgl.mk | 20 +++
> package/opengl/libgles/libgles.mk | 4 +
> package/opengl/libopenvg/libopenvg.mk | 4 +
> .../xserver_xorg-server/xserver_xorg-server.mk | 4 +-
> 11 files changed, 378 insertions(+), 80 deletions(-)
> create mode 100644 package/mesa3d/mesa3d-cross-glsl-compiler.patch
> create mode 100644 package/mesa3d/mesa3d-gbm-without-dri.patch
> delete mode 100644 package/mesa3d/mesa3d-uclibc-locale.patch
> create mode 100644 package/opengl/libgl/libgl.mk
I'm far from being able to understand all the internal details of
Mesa3D, what GBM is and so on, but from a Buildroot packaging
perspective, it looks good to me, so:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
However, see my comments on PATCH 3/7 saying that maybe moving mesa3d
outside of package/x11r7/ isn't really a good idea for the moment.
Another comment below.
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_LARGEFILE
This would require a comment saying that mesa3d is not available due to
toolchain missing C++ and largefile support. This comment is missing
today for C++ support, but it'd be good to add it. Can be done as a
followup patch, though.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-09-08 18:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 4:25 [Buildroot] [PATCH v2 0/7] glmark2 and Mesa updates Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 1/7] libdrm: bump and add experimental ARM framebuffer support Spenser Gilliland
2013-09-08 16:51 ` Thomas Petazzoni
2013-09-20 8:41 ` Peter Korsgaard
2013-09-06 4:25 ` [Buildroot] [PATCH v2 2/7] sunxi-cedarx: bump to newer version, use armel2 binaries, add demo Spenser Gilliland
2013-09-08 16:59 ` Thomas Petazzoni
2013-09-12 4:41 ` Spenser Gilliland
2013-09-20 13:54 ` Peter Korsgaard
2013-09-06 4:25 ` [Buildroot] [PATCH v2 3/7] mesa3d: pull out from x11 Spenser Gilliland
2013-09-08 17:02 ` Thomas Petazzoni
2013-09-12 2:57 ` Spenser Gilliland
2013-09-12 7:23 ` Thomas Petazzoni
2013-09-06 4:25 ` [Buildroot] [PATCH v2 4/7] mesa3d: modularize and bump to version 9.1.6 Spenser Gilliland
2013-09-08 18:30 ` Thomas Petazzoni [this message]
2013-09-12 2:58 ` Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 5/7] libpng12: new package Spenser Gilliland
2013-09-08 17:04 ` Thomas Petazzoni
2013-09-11 5:33 ` Arnout Vandecappelle
2013-09-12 3:20 ` Spenser Gilliland
2013-09-06 4:25 ` [Buildroot] [PATCH v2 6/7] glmark2: " Spenser Gilliland
2013-09-08 18:38 ` Thomas Petazzoni
2013-09-12 3:12 ` Spenser Gilliland
2013-09-11 5:47 ` Arnout Vandecappelle
2013-09-12 3:17 ` Spenser Gilliland
2013-09-30 20:39 ` Arnout Vandecappelle
2013-09-06 4:25 ` [Buildroot] [PATCH v2 7/7] mesa3d-demos: " Spenser Gilliland
2013-09-11 5:58 ` Arnout Vandecappelle
2013-09-12 3:21 ` Spenser Gilliland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130908203051.63b7055d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.