From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/9] drm: Make sure every ioctl structure has a typedef
Date: Sun, 8 Sep 2013 20:36:30 +0100 [thread overview]
Message-ID: <20130908193629.GA31384@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20130908115829.GW27291@phenom.ffwll.local>
On Sun, Sep 08, 2013 at 01:58:29PM +0200, Daniel Vetter wrote:
> On Fri, Sep 06, 2013 at 07:57:19PM +0100, Damien Lespiau wrote:
> > Just for consistency.
> >
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
>
> Afaik kernel coding style is to echew typdefs for normal structures as
> much as possible. The only exception is for truly opaque types used in
> abstractions, like dma_addr_t or pid_t.
>
> All the typedefs we still have here go back to the old days of a drm core
> shared between *bsd and linux. Since that's long gone they imo should all
> die, but certainly we shouldn't add new ones.
I figured that since we where talking about user space API, the kernel
rules wouldn't apply there and we could have some consistency, but I
certainly can just drop those patches.
--
Damien
next prev parent reply other threads:[~2013-09-08 19:36 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 18:57 Stereo 3D v3 Damien Lespiau
2013-09-06 18:57 ` [PATCH 1/9] drm: Move the GET_CAP macros next to the corresponding ioctl structure Damien Lespiau
2013-09-08 13:20 ` David Herrmann
2013-09-06 18:57 ` [PATCH 2/9] drm: Sort userspace typedefs by ioctl number Damien Lespiau
2013-09-06 18:57 ` [PATCH 3/9] drm: Make sure every ioctl structure has a typedef Damien Lespiau
2013-09-08 11:58 ` Daniel Vetter
2013-09-08 19:36 ` Damien Lespiau [this message]
2013-09-08 20:04 ` Daniel Vetter
2013-09-06 18:57 ` [PATCH 4/9] drm: Add a SET_CAP ioctl Damien Lespiau
2013-09-06 18:57 ` [PATCH 5/9] drm: Add HDMI stereo 3D flags to struct drm_mode_modeinfo Damien Lespiau
2013-09-06 18:57 ` [PATCH 6/9] drm: Add a DRM_CAP_STEREO_3D capability for SET_CAP ioctl Damien Lespiau
2013-09-08 13:50 ` David Herrmann
2013-09-08 14:49 ` Damien Lespiau
2013-09-13 16:04 ` Joakim Plate
2013-09-16 17:39 ` [PATCH 6/9] drm: Add a DRM_CAP_STEREO_3D capability for SET_CAP?ioctl Damien Lespiau
2013-09-06 18:57 ` [PATCH 7/9] drm/edid: Expose mandatory stereo modes for HDMI sinks Damien Lespiau
2013-09-13 16:10 ` Joakim Plate
2013-09-13 16:31 ` Daniel Vetter
2013-09-16 17:35 ` Damien Lespiau
2013-09-16 17:56 ` Ville Syrjälä
2013-09-16 18:20 ` Daniel Vetter
2013-09-16 18:04 ` Daniel Vetter
2013-09-17 9:22 ` Damien Lespiau
2013-09-06 18:57 ` [PATCH 8/9] drm: Reject modes with more than 1 stereo flags set Damien Lespiau
2013-09-06 18:57 ` [PATCH 9/9] drm: Set the relevant infoframe field when scanning out a 3D mode Damien Lespiau
2013-09-06 19:11 ` Stereo 3D v3 Chris Wilson
2013-09-08 11:59 ` Daniel Vetter
2013-09-08 13:46 ` David Herrmann
2013-09-08 15:03 ` Damien Lespiau
2013-09-08 20:05 ` Daniel Vetter
2013-09-10 14:14 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130908193629.GA31384@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.