From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [REPOST PATCH 1/4] slab: factor out calculate nr objects in cache_estimate
Date: Mon, 9 Sep 2013 13:32:34 +0900 [thread overview]
Message-ID: <20130909043233.GC22390@lge.com> (raw)
In-Reply-To: <00000140f3f56efb-1b2035a6-b81f-433f-aa2d-d1af50018b6a-000000@email.amazonses.com>
On Fri, Sep 06, 2013 at 03:48:04PM +0000, Christoph Lameter wrote:
> On Fri, 6 Sep 2013, Joonsoo Kim wrote:
>
> > }
> > *num = nr_objs;
> > - *left_over = slab_size - nr_objs*buffer_size - mgmt_size;
> > + *left_over = slab_size - (nr_objs * buffer_size) - mgmt_size;
> > }
>
> What is the point of this change? Drop it.
Okay. I will drop it.
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [REPOST PATCH 1/4] slab: factor out calculate nr objects in cache_estimate
Date: Mon, 9 Sep 2013 13:32:34 +0900 [thread overview]
Message-ID: <20130909043233.GC22390@lge.com> (raw)
In-Reply-To: <00000140f3f56efb-1b2035a6-b81f-433f-aa2d-d1af50018b6a-000000@email.amazonses.com>
On Fri, Sep 06, 2013 at 03:48:04PM +0000, Christoph Lameter wrote:
> On Fri, 6 Sep 2013, Joonsoo Kim wrote:
>
> > }
> > *num = nr_objs;
> > - *left_over = slab_size - nr_objs*buffer_size - mgmt_size;
> > + *left_over = slab_size - (nr_objs * buffer_size) - mgmt_size;
> > }
>
> What is the point of this change? Drop it.
Okay. I will drop it.
>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-09-09 4:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 5:57 [REPOST PATCH 0/4] slab: implement byte sized indexes for the freelist of a slab Joonsoo Kim
2013-09-06 5:57 ` Joonsoo Kim
2013-09-06 5:57 ` [REPOST PATCH 1/4] slab: factor out calculate nr objects in cache_estimate Joonsoo Kim
2013-09-06 5:57 ` Joonsoo Kim
2013-09-06 15:48 ` Christoph Lameter
2013-09-06 15:48 ` Christoph Lameter
2013-09-09 4:32 ` Joonsoo Kim [this message]
2013-09-09 4:32 ` Joonsoo Kim
2013-09-06 5:57 ` [REPOST PATCH 2/4] slab: introduce helper functions to get/set free object Joonsoo Kim
2013-09-06 5:57 ` Joonsoo Kim
2013-09-06 15:49 ` Christoph Lameter
2013-09-06 15:49 ` Christoph Lameter
2013-09-06 5:57 ` [REPOST PATCH 3/4] slab: introduce byte sized index for the freelist of a slab Joonsoo Kim
2013-09-06 5:57 ` Joonsoo Kim
2013-09-06 15:58 ` Christoph Lameter
2013-09-06 15:58 ` Christoph Lameter
2013-09-09 4:32 ` Joonsoo Kim
2013-09-09 4:32 ` Joonsoo Kim
2013-09-09 14:44 ` Christoph Lameter
2013-09-09 14:44 ` Christoph Lameter
2013-09-10 5:43 ` Joonsoo Kim
2013-09-10 5:43 ` Joonsoo Kim
2013-09-10 21:25 ` Christoph Lameter
2013-09-10 21:25 ` Christoph Lameter
2013-09-11 1:04 ` Joonsoo Kim
2013-09-11 1:04 ` Joonsoo Kim
2013-09-11 14:22 ` Christoph Lameter
2013-09-11 14:22 ` Christoph Lameter
2013-09-12 6:52 ` Joonsoo Kim
2013-09-12 6:52 ` Joonsoo Kim
2013-09-06 5:57 ` [REPOST PATCH 4/4] slab: make more slab management structure off the slab Joonsoo Kim
2013-09-06 5:57 ` Joonsoo Kim
2013-09-06 15:59 ` Christoph Lameter
2013-09-06 15:59 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909043233.GC22390@lge.com \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.