From: Matt Porter <matt.porter@linaro.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: linux-omap@vger.kernel.org, bcousson@baylibre.com,
tony@atomide.com, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, olof@lixom.net
Subject: Re: [PATCHv3] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black
Date: Mon, 9 Sep 2013 09:31:01 -0400 [thread overview]
Message-ID: <20130909133059.GD10973@ohporter.com> (raw)
In-Reply-To: <1378638746-10627-1-git-send-email-koen@dominion.thruhere.net>
On Sun, Sep 08, 2013 at 01:12:26PM +0200, Koen Kooi wrote:
> The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added,
> so create a common dtsi both can use.
>
> IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver
> after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead
> of 1.8.
>
> MMC support for AM335x still isn't in, so only the LDO change has been added.
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
Tested-by: Matt Porter <matt.porter@linaro.org>
Works fine for me on tip and 3.11. I did notice a regression in musb (worked
on 3.11, now failing to probe but this is not related to your new dts as it
happens on am335x-bone.dts too, assuming merge window volatility). One nit,
git-am picked up a whitespace error on that extra line at EOF so you should
trim that out.
Only thing is...for a clear bug like this that will destroy hardware, it
should be marked Cc: stable@vger.kernel.org to be picked up in stable.
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: matt.porter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black
Date: Mon, 9 Sep 2013 09:31:01 -0400 [thread overview]
Message-ID: <20130909133059.GD10973@ohporter.com> (raw)
In-Reply-To: <1378638746-10627-1-git-send-email-koen@dominion.thruhere.net>
On Sun, Sep 08, 2013 at 01:12:26PM +0200, Koen Kooi wrote:
> The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added,
> so create a common dtsi both can use.
>
> IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver
> after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead
> of 1.8.
>
> MMC support for AM335x still isn't in, so only the LDO change has been added.
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
Tested-by: Matt Porter <matt.porter@linaro.org>
Works fine for me on tip and 3.11. I did notice a regression in musb (worked
on 3.11, now failing to probe but this is not related to your new dts as it
happens on am335x-bone.dts too, assuming merge window volatility). One nit,
git-am picked up a whitespace error on that extra line at EOF so you should
trim that out.
Only thing is...for a clear bug like this that will destroy hardware, it
should be marked Cc: stable at vger.kernel.org to be picked up in stable.
-Matt
next prev parent reply other threads:[~2013-09-09 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 11:12 [PATCHv3] ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black Koen Kooi
2013-09-08 11:12 ` Koen Kooi
2013-09-09 13:19 ` Tom Rini
2013-09-09 13:19 ` Tom Rini
2013-09-09 13:19 ` Tom Rini
2013-09-09 13:31 ` Matt Porter [this message]
2013-09-09 13:31 ` Matt Porter
2013-09-09 13:51 ` Jonathan Austin
2013-09-09 13:51 ` Jonathan Austin
2013-09-09 13:59 ` Matt Porter
2013-09-09 13:59 ` Matt Porter
2013-09-09 14:16 ` Matt Porter
2013-09-09 14:16 ` Matt Porter
2013-09-09 16:02 ` Jonathan Austin
2013-09-09 16:02 ` Jonathan Austin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909133059.GD10973@ohporter.com \
--to=matt.porter@linaro.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=koen@dominion.thruhere.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.