From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: kexec@lists.infradead.org, Eric Biederman <ebiederm@xmission.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/radeon: Implement radeon_pci_shutdown
Date: Mon, 9 Sep 2013 09:32:48 -0400 [thread overview]
Message-ID: <20130909133248.GH21435@phenom.dumpdata.com> (raw)
In-Reply-To: <20130908121058.GC360@x4>
On Sun, Sep 08, 2013 at 02:10:58PM +0200, Markus Trippelsdorf wrote:
> Currently radeon devices are not properbly shutdown during kexec. This
properly
> cases a varity of issues, e.g. dpm initialization failures.
> Fix this by implementing a radeon_pci_shutdown function, that unloads
> the driver cleanly.
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index cb4445f..d71edee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -380,6 +380,15 @@ static const struct file_operations radeon_driver_kms_fops = {
> #endif
> };
>
> +
> +static void
> +radeon_pci_shutdown(struct pci_dev *pdev)
> +{
> + struct drm_device *dev = pci_get_drvdata(pdev);
> +
> + radeon_driver_unload_kms(dev);
> +}
> +
> static struct drm_driver kms_driver = {
> .driver_features =
> DRIVER_USE_AGP |
> @@ -453,6 +462,7 @@ static struct pci_driver radeon_kms_pci_driver = {
> .remove = radeon_pci_remove,
> .suspend = radeon_pci_suspend,
> .resume = radeon_pci_resume,
> + .shutdown = radeon_pci_shutdown,
> };
>
> static int __init radeon_init(void)
> --
> Markus
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: kexec@lists.infradead.org, Eric Biederman <ebiederm@xmission.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/radeon: Implement radeon_pci_shutdown
Date: Mon, 9 Sep 2013 09:32:48 -0400 [thread overview]
Message-ID: <20130909133248.GH21435@phenom.dumpdata.com> (raw)
In-Reply-To: <20130908121058.GC360@x4>
On Sun, Sep 08, 2013 at 02:10:58PM +0200, Markus Trippelsdorf wrote:
> Currently radeon devices are not properbly shutdown during kexec. This
properly
> cases a varity of issues, e.g. dpm initialization failures.
> Fix this by implementing a radeon_pci_shutdown function, that unloads
> the driver cleanly.
>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> ---
> drivers/gpu/drm/radeon/radeon_drv.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
> index cb4445f..d71edee 100644
> --- a/drivers/gpu/drm/radeon/radeon_drv.c
> +++ b/drivers/gpu/drm/radeon/radeon_drv.c
> @@ -380,6 +380,15 @@ static const struct file_operations radeon_driver_kms_fops = {
> #endif
> };
>
> +
> +static void
> +radeon_pci_shutdown(struct pci_dev *pdev)
> +{
> + struct drm_device *dev = pci_get_drvdata(pdev);
> +
> + radeon_driver_unload_kms(dev);
> +}
> +
> static struct drm_driver kms_driver = {
> .driver_features =
> DRIVER_USE_AGP |
> @@ -453,6 +462,7 @@ static struct pci_driver radeon_kms_pci_driver = {
> .remove = radeon_pci_remove,
> .suspend = radeon_pci_suspend,
> .resume = radeon_pci_resume,
> + .shutdown = radeon_pci_shutdown,
> };
>
> static int __init radeon_init(void)
> --
> Markus
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2013-09-09 13:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-08 12:09 [PATCH 0/3] drm/radeon kexec fixes Markus Trippelsdorf
2013-09-08 12:09 ` Markus Trippelsdorf
2013-09-08 12:10 ` [PATCH 1/3] kexec: get rid of late printk Markus Trippelsdorf
2013-09-08 12:10 ` Markus Trippelsdorf
2013-09-08 20:11 ` Daniel Vetter
2013-09-08 20:11 ` Daniel Vetter
2013-09-08 20:42 ` Bruno Prémont
2013-09-08 20:42 ` Bruno Prémont
2013-09-08 12:10 ` [PATCH 2/3] drm/radeon: Implement radeon_pci_shutdown Markus Trippelsdorf
2013-09-08 12:10 ` Markus Trippelsdorf
2013-09-09 13:32 ` Konrad Rzeszutek Wilk [this message]
2013-09-09 13:32 ` Konrad Rzeszutek Wilk
2013-09-08 12:11 ` [PATCH 3/3] drm/radeon: get rid of r100_restore_sanity hack Markus Trippelsdorf
2013-09-08 12:11 ` Markus Trippelsdorf
2013-09-09 0:32 ` [PATCH 0/3] drm/radeon kexec fixes Eric W. Biederman
2013-09-09 0:32 ` Eric W. Biederman
2013-09-09 9:21 ` Markus Trippelsdorf
2013-09-09 9:21 ` Markus Trippelsdorf
2013-09-09 9:38 ` Christian König
2013-09-09 9:38 ` Christian König
2013-09-11 9:01 ` Markus Trippelsdorf
2013-09-11 9:01 ` Markus Trippelsdorf
2013-09-11 9:10 ` Christian König
2013-09-11 9:10 ` Christian König
2013-09-11 13:30 ` Alex Deucher
2013-09-11 13:30 ` Alex Deucher
2013-09-09 13:04 ` Alex Deucher
2013-09-09 13:04 ` Alex Deucher
2013-09-10 18:27 ` Eric W. Biederman
2013-09-10 18:27 ` Eric W. Biederman
2013-09-10 20:40 ` Alex Deucher
2013-09-10 20:40 ` Alex Deucher
2013-09-11 8:53 ` Markus Trippelsdorf
2013-09-11 8:53 ` Markus Trippelsdorf
2013-09-11 9:21 ` Christian König
2013-09-11 9:21 ` Christian König
2013-09-11 13:40 ` Alex Deucher
2013-09-11 13:40 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909133248.GH21435@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=markus@trippelsdorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.