* [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings
@ 2013-09-09 20:25 eladwexler77
2013-09-10 14:52 ` Dan Carpenter
2013-09-10 14:56 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: eladwexler77 @ 2013-09-09 20:25 UTC (permalink / raw)
To: kernel-janitors
From: Elad Wexler <eladwexler77@yahoo.com>
Coding style issues
Signed-off-by: Elad Wexler <eladwexler77@yahoo.com>
---
drivers/staging/usbip/stub_dev.c | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index d8957a5..76a1ff0 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -357,8 +357,9 @@ static int stub_probe(struct usb_interface *interface,
busid_priv = get_busid_priv(udev_busid);
if (!busid_priv || (busid_priv->status = STUB_BUSID_REMOV) ||
(busid_priv->status = STUB_BUSID_OTHER)) {
- dev_info(&interface->dev, "%s is not in match_busid table... "
- "skip!\n", udev_busid);
+ dev_info(&interface->dev,
+ "%s is not in match_busid table... skip!\n",
+ udev_busid);
/*
* Return value should be ENODEV or ENOXIO to continue trying
@@ -375,8 +376,10 @@ static int stub_probe(struct usb_interface *interface,
}
if (!strcmp(udev->bus->bus_name, "vhci_hcd")) {
- dev_dbg(&udev->dev, "%s is attached on vhci_hcd... skip!\n",
- udev_busid);
+ dev_dbg(&udev->dev,
+ "%s is attached on vhci_hcd... skip!\n",
+ udev_busid);
+
return -ENODEV;
}
@@ -386,10 +389,10 @@ static int stub_probe(struct usb_interface *interface,
return -ENODEV;
busid_priv->interf_count++;
- dev_info(&interface->dev, "usbip-host: register new interface "
- "(bus %u dev %u ifn %u)\n",
- udev->bus->busnum, udev->devnum,
- interface->cur_altsetting->desc.bInterfaceNumber);
+ dev_info(&interface->dev,
+ "usbip-host: register new interface (bus %u dev %u ifn %u)\n",
+ udev->bus->busnum, udev->devnum,
+ interface->cur_altsetting->desc.bInterfaceNumber);
/* set private data to usb_interface */
usb_set_intfdata(interface, sdev);
@@ -412,9 +415,10 @@ static int stub_probe(struct usb_interface *interface,
if (!sdev)
return -ENOMEM;
- dev_info(&interface->dev, "usbip-host: register new device "
- "(bus %u dev %u ifn %u)\n", udev->bus->busnum, udev->devnum,
- interface->cur_altsetting->desc.bInterfaceNumber);
+ dev_info(&interface->dev,
+ "usbip-host: register new device (bus %u dev %u ifn %u)\n",
+ udev->bus->busnum, udev->devnum,
+ interface->cur_altsetting->desc.bInterfaceNumber);
busid_priv->interf_count = 0;
busid_priv->shutdown_busid = 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings
2013-09-09 20:25 [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings eladwexler77
@ 2013-09-10 14:52 ` Dan Carpenter
2013-09-10 14:56 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-09-10 14:52 UTC (permalink / raw)
To: kernel-janitors
On Mon, Sep 09, 2013 at 11:25:02PM +0300, eladwexler77@yahoo.com wrote:
> From: Elad Wexler <eladwexler77@yahoo.com>
>
> Coding style issues
>
> Signed-off-by: Elad Wexler <eladwexler77@yahoo.com>
This looks ok but it needs to be sent to Greg and
devel@driverdev.osuosl.org. Please resend.
Also it would be better if the patch description were more complete.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings
2013-09-09 20:25 [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings eladwexler77
2013-09-10 14:52 ` Dan Carpenter
@ 2013-09-10 14:56 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-09-10 14:56 UTC (permalink / raw)
To: kernel-janitors
On Tue, Sep 10, 2013 at 05:52:50PM +0300, Dan Carpenter wrote:
> On Mon, Sep 09, 2013 at 11:25:02PM +0300, eladwexler77@yahoo.com wrote:
> > From: Elad Wexler <eladwexler77@yahoo.com>
> >
> > Coding style issues
> >
> > Signed-off-by: Elad Wexler <eladwexler77@yahoo.com>
>
> This looks ok but it needs to be sent to Greg and
> devel@driverdev.osuosl.org. Please resend.
The osuosl.org mailing list seems to be broken. Use the
driverdev-devel@linuxdriverproject.org list instead.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-10 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 20:25 [PATCH] Staging: usbip: stub_dev: Fixed checkpatch warnings eladwexler77
2013-09-10 14:52 ` Dan Carpenter
2013-09-10 14:56 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.