From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] powerpc: Provide for giveup_fpu/altivec to save state in alternate location
Date: Tue, 10 Sep 2013 23:54:44 +0000 [thread overview]
Message-ID: <20130910235444.GD4455@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <675235E3-6991-4DB1-90A4-935E826F6413@suse.de>
On Tue, Sep 10, 2013 at 12:12:47PM -0500, Alexander Graf wrote:
>
> On 10.09.2013, at 05:21, Paul Mackerras wrote:
>
> > @@ -212,6 +212,7 @@ struct thread_struct {
> > #endif
> > #endif
> > struct thread_fp_state fp_state;
> > + struct thread_fp_state *fp_save_area;
>
> Why do you need these pointers? Couldn't you handle everything you need through preempt notifiers?
As you note in your review of a later patch, no, I need the pointer so
that if in-kernel code wants to use FP or VSX, potentially in the
context of this same process, it knows where to save the FP/VSX state
away to.
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] powerpc: Provide for giveup_fpu/altivec to save state in alternate location
Date: Wed, 11 Sep 2013 09:54:44 +1000 [thread overview]
Message-ID: <20130910235444.GD4455@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <675235E3-6991-4DB1-90A4-935E826F6413@suse.de>
On Tue, Sep 10, 2013 at 12:12:47PM -0500, Alexander Graf wrote:
>
> On 10.09.2013, at 05:21, Paul Mackerras wrote:
>
> > @@ -212,6 +212,7 @@ struct thread_struct {
> > #endif
> > #endif
> > struct thread_fp_state fp_state;
> > + struct thread_fp_state *fp_save_area;
>
> Why do you need these pointers? Couldn't you handle everything you need through preempt notifiers?
As you note in your review of a later patch, no, I need the pointer so
that if in-kernel code wants to use FP or VSX, potentially in the
context of this same process, it knows where to save the FP/VSX state
away to.
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Alexander Graf <agraf@suse.de>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/6] powerpc: Provide for giveup_fpu/altivec to save state in alternate location
Date: Wed, 11 Sep 2013 09:54:44 +1000 [thread overview]
Message-ID: <20130910235444.GD4455@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <675235E3-6991-4DB1-90A4-935E826F6413@suse.de>
On Tue, Sep 10, 2013 at 12:12:47PM -0500, Alexander Graf wrote:
>
> On 10.09.2013, at 05:21, Paul Mackerras wrote:
>
> > @@ -212,6 +212,7 @@ struct thread_struct {
> > #endif
> > #endif
> > struct thread_fp_state fp_state;
> > + struct thread_fp_state *fp_save_area;
>
> Why do you need these pointers? Couldn't you handle everything you need through preempt notifiers?
As you note in your review of a later patch, no, I need the pointer so
that if in-kernel code wants to use FP or VSX, potentially in the
context of this same process, it knows where to save the FP/VSX state
away to.
Paul.
next prev parent reply other threads:[~2013-09-10 23:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 10:20 [PATCH 0/6] powerpc: Unify FP/VMX/VSX state handling between KVM and main kernel Paul Mackerras
2013-09-10 10:20 ` Paul Mackerras
2013-09-10 10:20 ` Paul Mackerras
2013-09-10 10:20 ` [PATCH 1/6] powerpc: Put FP/VSX and VR state into structures Paul Mackerras
2013-09-10 10:20 ` Paul Mackerras
2013-09-10 10:20 ` Paul Mackerras
2013-09-10 17:07 ` Alexander Graf
2013-09-10 17:07 ` Alexander Graf
2013-09-10 17:07 ` Alexander Graf
2013-09-10 23:52 ` Paul Mackerras
2013-09-10 23:52 ` Paul Mackerras
2013-09-10 23:52 ` Paul Mackerras
2013-09-10 10:21 ` [PATCH 2/6] powerpc: Provide for giveup_fpu/altivec to save state in alternate location Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 17:12 ` Alexander Graf
2013-09-10 17:12 ` Alexander Graf
2013-09-10 17:12 ` Alexander Graf
2013-09-10 23:54 ` Paul Mackerras [this message]
2013-09-10 23:54 ` Paul Mackerras
2013-09-10 23:54 ` Paul Mackerras
2013-09-10 10:21 ` [PATCH 3/6] KVM: PPC: Use load_fp/vr_state rather than load_up_fpu/altivec Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 10:21 ` [PATCH 4/6] KVM: PPC: Store FP/VSX/VMX state in thread_fp/vr_state structures Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 10:21 ` Paul Mackerras
2013-09-10 10:22 ` [PATCH 5/6] KVM: PPC: Book3S: Load/save FP/VMX/VSX state directly to/from vcpu struct Paul Mackerras
2013-09-10 10:22 ` Paul Mackerras
2013-09-10 10:22 ` Paul Mackerras
2013-09-10 18:54 ` Alexander Graf
2013-09-10 18:54 ` Alexander Graf
2013-09-10 18:54 ` Alexander Graf
2013-09-10 10:22 ` [PATCH 6/6] KVM: PPC: Book3S HV: Use load/store_fp_state functions in HV guest entry/exit Paul Mackerras
2013-09-10 10:22 ` Paul Mackerras
2013-09-10 10:22 ` Paul Mackerras
2013-09-10 18:57 ` Alexander Graf
2013-09-10 18:57 ` Alexander Graf
2013-09-10 18:57 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910235444.GD4455@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.