From: Luiz Capitulino <lcapitulino@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes
Date: Fri, 13 Sep 2013 14:01:25 -0400 [thread overview]
Message-ID: <20130913140125.75a32a72@redhat.com> (raw)
In-Reply-To: <5230FD28.3030806@redhat.com>
On Wed, 11 Sep 2013 17:30:48 -0600
Eric Blake <eblake@redhat.com> wrote:
> On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> > docs/qmp/qmp-events.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> > index 39b6016..1e91f45 100644
> > --- a/docs/qmp/qmp-events.txt
> > +++ b/docs/qmp/qmp-events.txt
> > @@ -1,4 +1,4 @@
> > - QEMU Monitor Protocol Events
> > + QEMU Machine Protocol Events
> > ============================
> >
> > BALLOON_CHANGE
> > @@ -173,7 +173,7 @@ Data:
> > "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> >
> > NIC_RX_FILTER_CHANGED
> > ------------------
> > +---------------------
> >
> > The event is emitted once until the query command is executed,
> > the first event will always be emitted.
> >
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> But incomplete. DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED
> is out of order,
Fixed those.
> and it's probably worth splitting SPICE_CONNECTED and
> SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and
> VNC_DISCONNECTED).
This probably better done in a different patch. Will left for another day.
next prev parent reply other threads:[~2013-09-13 18:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 20:52 [Qemu-devel] [PATCH 0/6] QMP: re-organize documentation Luiz Capitulino
2013-09-11 20:52 ` [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp Luiz Capitulino
2013-09-11 22:08 ` Eric Blake
2013-09-11 22:13 ` Eric Blake
2013-09-13 17:52 ` Luiz Capitulino
2013-09-11 20:52 ` [Qemu-devel] [PATCH 2/6] QMP: fix qmp-commands.txt generation path Luiz Capitulino
2013-09-11 22:09 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 3/6] QMP: QMP/ -> docs/qmp/ Luiz Capitulino
2013-09-11 22:15 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 4/6] QMP: Update README file Luiz Capitulino
2013-09-11 23:13 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 5/6] QMP: Update qmp-spec.txt Luiz Capitulino
2013-09-11 23:27 ` Eric Blake
2013-09-13 17:54 ` Luiz Capitulino
2013-09-13 18:00 ` Eric Blake
2013-09-11 20:52 ` [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes Luiz Capitulino
2013-09-11 23:30 ` Eric Blake
2013-09-13 18:01 ` Luiz Capitulino [this message]
2013-09-13 18:16 ` Eric Blake
2013-09-13 18:20 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913140125.75a32a72@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.