Re: [Qemu-devel] [PATCH 6/6] QMP: qmp-events.txt: minor fixes

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

On 09/11/2013 02:52 PM, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  docs/qmp/qmp-events.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> index 39b6016..1e91f45 100644
> --- a/docs/qmp/qmp-events.txt
> +++ b/docs/qmp/qmp-events.txt
> @@ -1,4 +1,4 @@
> -                   QEMU Monitor Protocol Events
> +                   QEMU Machine Protocol Events
>                     ============================
>  
>  BALLOON_CHANGE
> @@ -173,7 +173,7 @@ Data:
>    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
>  
>  NIC_RX_FILTER_CHANGED
> ------------------
> +---------------------
>  
>  The event is emitted once until the query command is executed,
>  the first event will always be emitted.
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

But incomplete.  DEVICE_DELETED has a too-long delimiter, GUEST_PANICKED
is out of order, and it's probably worth splitting SPICE_CONNECTED and
SPICE_DISCONNECTED into separate sections (matching VNC_CONNECTED and
VNC_DISCONNECTED).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]