From: drjones@redhat.com (Andrew Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS
Date: Sat, 14 Sep 2013 14:23:11 +0200 [thread overview]
Message-ID: <20130914122310.GC2596@hawk.usersys.redhat.com> (raw)
In-Reply-To: <AC39CB35-1EE1-49DE-A2E4-F544699A516B@suse.de>
On Sat, Sep 14, 2013 at 07:14:02AM -0500, Alexander Graf wrote:
>
>
> Am 14.09.2013 um 07:10 schrieb Andrew Jones <drjones@redhat.com>:
>
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> > arch/arm/kvm/arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> > index 741f66a2edbd7..9ebf8ac3a12ff 100644
> > --- a/arch/arm/kvm/arm.c
> > +++ b/arch/arm/kvm/arm.c
> > @@ -201,7 +201,7 @@ int kvm_dev_ioctl_check_extension(long ext)
> > r = 1;
> > break;
> > case KVM_CAP_NR_VCPUS:
> > - r = num_online_cpus();
> > + r = min(num_online_cpus(), KVM_MAX_VCPUS);
>
> Is there any real reason to prohibit overcommit?
This doesn't prohibit it. Users can attempt to configure anything they'd
like, but only selections KVM_MAX_VCPUS and below will work.
drew
>
> Alex
>
> > break;
> > case KVM_CAP_MAX_VCPUS:
> > r = KVM_MAX_VCPUS;
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > kvmarm mailing list
> > kvmarm at lists.cs.columbia.edu
> > https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS
Date: Sat, 14 Sep 2013 14:23:11 +0200 [thread overview]
Message-ID: <20130914122310.GC2596@hawk.usersys.redhat.com> (raw)
In-Reply-To: <AC39CB35-1EE1-49DE-A2E4-F544699A516B@suse.de>
On Sat, Sep 14, 2013 at 07:14:02AM -0500, Alexander Graf wrote:
>
>
> Am 14.09.2013 um 07:10 schrieb Andrew Jones <drjones@redhat.com>:
>
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> > arch/arm/kvm/arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> > index 741f66a2edbd7..9ebf8ac3a12ff 100644
> > --- a/arch/arm/kvm/arm.c
> > +++ b/arch/arm/kvm/arm.c
> > @@ -201,7 +201,7 @@ int kvm_dev_ioctl_check_extension(long ext)
> > r = 1;
> > break;
> > case KVM_CAP_NR_VCPUS:
> > - r = num_online_cpus();
> > + r = min(num_online_cpus(), KVM_MAX_VCPUS);
>
> Is there any real reason to prohibit overcommit?
This doesn't prohibit it. Users can attempt to configure anything they'd
like, but only selections KVM_MAX_VCPUS and below will work.
drew
>
> Alex
>
> > break;
> > case KVM_CAP_MAX_VCPUS:
> > r = KVM_MAX_VCPUS;
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > kvmarm mailing list
> > kvmarm@lists.cs.columbia.edu
> > https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Jones <drjones@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS
Date: Sat, 14 Sep 2013 14:23:11 +0200 [thread overview]
Message-ID: <20130914122310.GC2596@hawk.usersys.redhat.com> (raw)
In-Reply-To: <AC39CB35-1EE1-49DE-A2E4-F544699A516B@suse.de>
On Sat, Sep 14, 2013 at 07:14:02AM -0500, Alexander Graf wrote:
>
>
> Am 14.09.2013 um 07:10 schrieb Andrew Jones <drjones@redhat.com>:
>
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> > arch/arm/kvm/arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kvm/arm.c b/arch/arm/kvm/arm.c
> > index 741f66a2edbd7..9ebf8ac3a12ff 100644
> > --- a/arch/arm/kvm/arm.c
> > +++ b/arch/arm/kvm/arm.c
> > @@ -201,7 +201,7 @@ int kvm_dev_ioctl_check_extension(long ext)
> > r = 1;
> > break;
> > case KVM_CAP_NR_VCPUS:
> > - r = num_online_cpus();
> > + r = min(num_online_cpus(), KVM_MAX_VCPUS);
>
> Is there any real reason to prohibit overcommit?
This doesn't prohibit it. Users can attempt to configure anything they'd
like, but only selections KVM_MAX_VCPUS and below will work.
drew
>
> Alex
>
> > break;
> > case KVM_CAP_MAX_VCPUS:
> > r = KVM_MAX_VCPUS;
> > --
> > 1.8.1.4
> >
> > _______________________________________________
> > kvmarm mailing list
> > kvmarm@lists.cs.columbia.edu
> > https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm
next prev parent reply other threads:[~2013-09-14 12:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 12:10 [PATCH 0/3] KVM_MAX_VCPUS related changes Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-14 12:10 ` [PATCH 1/3] arm: kvm: clamp NR_VCPUS to MAX_VCPUS Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-14 12:14 ` Alexander Graf
2013-09-14 12:14 ` Alexander Graf
2013-09-14 12:22 ` Marc Zyngier
2013-09-14 12:22 ` Marc Zyngier
2013-09-14 12:23 ` Andrew Jones [this message]
2013-09-14 12:23 ` Andrew Jones
2013-09-14 12:23 ` Andrew Jones
2013-09-14 12:10 ` [PATCH 2/3] arm32: kvm: rename CONFIG_KVM_ARM_MAX_VCPUS Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-15 9:30 ` Gleb Natapov
2013-09-15 9:30 ` Gleb Natapov
2013-09-15 9:30 ` Gleb Natapov
2013-09-16 8:09 ` Marc Zyngier
2013-09-16 8:09 ` Marc Zyngier
2013-09-16 8:32 ` Gleb Natapov
2013-09-16 8:32 ` Gleb Natapov
2013-09-16 8:49 ` Marc Zyngier
2013-09-16 8:49 ` Marc Zyngier
2013-09-17 21:42 ` Christoffer Dall
2013-09-17 21:42 ` Christoffer Dall
2013-09-24 14:09 ` [PATCH v2] " Andrew Jones
2013-09-24 14:09 ` Andrew Jones
2013-09-24 14:09 ` Andrew Jones
2013-09-25 19:31 ` Christoffer Dall
2013-09-25 19:31 ` Christoffer Dall
2013-09-26 7:54 ` Andrew Jones
2013-09-26 7:54 ` Andrew Jones
2013-09-26 7:54 ` Andrew Jones
2013-09-14 12:10 ` [PATCH 3/3] aarch64: kvm: introduce CONFIG_KVM_MAX_VCPUS Andrew Jones
2013-09-14 12:10 ` Andrew Jones
2013-09-17 21:34 ` Christoffer Dall
2013-09-17 21:34 ` Christoffer Dall
2013-09-18 6:21 ` Gleb Natapov
2013-09-18 6:21 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914122310.GC2596@hawk.usersys.redhat.com \
--to=drjones@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.