All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS
Date: Sun, 15 Sep 2013 07:36:05 +0200	[thread overview]
Message-ID: <20130915073605.793f79ad@lilith> (raw)
In-Reply-To: <7B43E01F5906F9448BF8BAACD5D26B3803CA11@DENBGAT9EH2MSX.ww902.siemens.net>

Hi Roger,

On Thu, 12 Sep 2013 13:18:20 +0000, "Meier, Roger"
<r.meier@siemens.com> wrote:

> Hi Albert
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
> > Behalf Of Albert ARIBAUD
> > Sent: Mittwoch, 11. September 2013 15:53
> > To: u-boot at lists.denx.de
> > Subject: [U-Boot] [PATCH v2] Merge and reformat boards.cfg and MAINTAINERS
> > 
> > Put all informations about targets, including state (active or
> > orphan) and maintainers, in boards.cfg; remove MAINTAINERS;
> > adjust the build system accordingly.
> > 
> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
> > V2:
> > 	- updated with latest boards.cfg/MAINTAINER info
> > 	- fixed wrong maintainer(s) for orphan boards
> > 	- fixed wrong maintainer(s) for base:options case
> > 	- fixed lingering misuses of boards.cfg and MAINTAINERS
> > V1:
> > 	- initial submission from squashed RFC patch series
> > 
> >  MAINTAINERS             | 1412 ----------------------------
> >  MAKEALL                 |   51 +-
> >  Makefile                |    2 +-
> >  README                  |    6 +-
> >  boards.cfg              | 2345 ++++++++++++++++++++++++----------------------
> > -
> >  mkconfig                |   31 +-
> >  tools/buildman/board.py |    2 +-
> >  tools/reformat.py       |  132 +++
> >  8 files changed, 1350 insertions(+), 2631 deletions(-)
> >  delete mode 100644 MAINTAINERS
> >  create mode 100755 tools/reformat.py
> > 
> 
> I really like that simplification!
> 
> tools/checkpatch.pl detected these errors:
> ---SNIP---
> ERROR: trailing whitespace
> #4055: FILE: tools/reformat.py:32:
> +#       ^I$
> 
> ERROR: trailing whitespace
> #4125: FILE: tools/reformat.py:102:
> +^I^I# any missing field is set to default if it exists $
> ---SNIP---
> 
> and I recognized that tools/checkpatch.pl needs the patch below.
> 
> Regards,
> Roger
> 
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 896e2bc..88c5bc7 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -398,7 +398,7 @@ sub top_of_kernel_tree {
>  	my ($root) = @_;
>  
>  	my @tree_check = (
> -		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> +		"COPYING", "CREDITS", "Kbuild", "Makefile",
>  		"README", "Documentation", "arch", "include", "drivers",
>  		"fs", "init", "ipc", "kernel", "lib", "scripts",
>  	);
> @@ -3701,7 +3701,7 @@ sub process {
>  $vname has style problems, please review.
>  
>  If any of these errors are false positives, please report
> -them to the maintainer, see CHECKPATCH in MAINTAINERS.
> +them to the maintainer, see boards.cfg.
>  EOM
>  	}

Thanks! I thought I'd done a grep -i MAINTAINERS before posting,
obviously I hadn't.

Could you send thoses two fixes as as a proper, standalone git patch
rather than a reply to another patch, so that they can be properly
attributed to you?

Amicalement,
-- 
Albert.

  parent reply	other threads:[~2013-09-15  5:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-10 19:10 [U-Boot] [PATCH] Merge and reformat boards.cfg and MAINTAINERS Albert ARIBAUD
2013-09-11 13:52 ` [U-Boot] [PATCH v2] " Albert ARIBAUD
2013-09-12 15:11   ` Tom Rini
2013-09-17  0:55     ` Masahiro Yamada
2013-09-19  6:29       ` Albert ARIBAUD
2013-09-27 11:05         ` Masahiro Yamada
2013-10-03 21:32           ` Albert ARIBAUD
     [not found]   ` <7B43E01F5906F9448BF8BAACD5D26B3803CA11@DENBGAT9EH2MSX.ww902.siemens.net>
2013-09-15  5:36     ` Albert ARIBAUD [this message]
2013-09-16  6:55       ` Meier, Roger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130915073605.793f79ad@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.