From: Thierry Reding <thierry.reding@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Milo Kim <milo.kim@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/4] Documentation: add LP3943 DT bindings and document
Date: Sun, 15 Sep 2013 13:27:56 +0200 [thread overview]
Message-ID: <20130915112755.GB9765@ulmo> (raw)
In-Reply-To: <20130912152455.GN11227@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, Sep 12, 2013 at 04:24:55PM +0100, Lee Jones wrote:
> On Thu, 12 Sep 2013, Milo Kim wrote:
[...]
> > diff --git a/Documentation/lp3943.txt b/Documentation/lp3943.txt
> > new file mode 100644
> > index 0000000..576ebd0
> > --- /dev/null
> > +++ b/Documentation/lp3943.txt
[...]
> If this stuff is really important (and most of it really isn't), then
> put it either in the commit log or in the driver.
I can only speak for myself, but the initial driver commit message is
about the last place I look for this kind of information. I'd expect it
to be either somewhere in Documentation/ or in one of the source files.
In this case I'd probably look at the MFD core driver source file. More
likely, even, I'd just go google "LP3943" and grab a public datasheet
from TI where all of this can hopefully be found.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Milo Kim <milo.kim-l0cyMroinI0@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/4] Documentation: add LP3943 DT bindings and document
Date: Sun, 15 Sep 2013 13:27:56 +0200 [thread overview]
Message-ID: <20130915112755.GB9765@ulmo> (raw)
In-Reply-To: <20130912152455.GN11227@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, Sep 12, 2013 at 04:24:55PM +0100, Lee Jones wrote:
> On Thu, 12 Sep 2013, Milo Kim wrote:
[...]
> > diff --git a/Documentation/lp3943.txt b/Documentation/lp3943.txt
> > new file mode 100644
> > index 0000000..576ebd0
> > --- /dev/null
> > +++ b/Documentation/lp3943.txt
[...]
> If this stuff is really important (and most of it really isn't), then
> put it either in the commit log or in the driver.
I can only speak for myself, but the initial driver commit message is
about the last place I look for this kind of information. I'd expect it
to be either somewhere in Documentation/ or in one of the source files.
In this case I'd probably look at the MFD core driver source file. More
likely, even, I'd just go google "LP3943" and grab a public datasheet
from TI where all of this can hopefully be found.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-15 11:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 1:35 [PATCH v3 4/4] Documentation: add LP3943 DT bindings and document Milo Kim
2013-09-12 1:35 ` Milo Kim
2013-09-12 15:24 ` Lee Jones
2013-09-15 11:27 ` Thierry Reding [this message]
2013-09-15 11:27 ` Thierry Reding
2013-09-16 7:30 ` Lee Jones
2013-09-19 11:25 ` Thierry Reding
2013-09-19 11:25 ` Thierry Reding
2013-09-19 11:56 ` Lee Jones
2013-09-19 11:56 ` Lee Jones
2013-09-22 14:35 ` Milo Kim
2013-09-22 14:35 ` Milo Kim
2013-09-22 14:35 ` Milo Kim
2013-09-23 7:58 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130915112755.GB9765@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.