All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Peter Hurley <peter@hurleysoftware.com>
Cc: codonell <codonell@redhat.com>, Eduard Benes <ebenes@redhat.com>,
	Karel Srot <ksrot@redhat.com>, Matt Newsome <mnewsome@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] tty: disassociate_ctty() sends the extra SIGCONT
Date: Sun, 15 Sep 2013 17:50:26 +0200	[thread overview]
Message-ID: <20130915155026.GA11917@redhat.com> (raw)
In-Reply-To: <20130915155006.GA11913@redhat.com>

Starting from v3.10 (probably f91e2590 "tty: Signal foreground
group processes in hangup") disassociate_ctty() sends SIGCONT
if tty && on_exit. This breaks LSB test-suite, in particular
test8 in _exit.c and test40 in sigcon5.c.

Put the "!on_exit" check back to restore the old behaviour.

Cc: stable@vger.kernel.org # v3.10+
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Karel Srot <ksrot@redhat.com>
---
 drivers/tty/tty_io.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index a9355ce..3a1a01a 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -854,7 +854,8 @@ void disassociate_ctty(int on_exit)
 			struct pid *tty_pgrp = tty_get_pgrp(tty);
 			if (tty_pgrp) {
 				kill_pgrp(tty_pgrp, SIGHUP, on_exit);
-				kill_pgrp(tty_pgrp, SIGCONT, on_exit);
+				if (!on_exit)
+					kill_pgrp(tty_pgrp, SIGCONT, on_exit);
 				put_pid(tty_pgrp);
 			}
 		}
-- 
1.5.5.1



  reply	other threads:[~2013-09-15 15:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-15 15:50 [PATCH 0/1] tty: disassociate_ctty() sends the extra SIGCONT Oleg Nesterov
2013-09-15 15:50 ` Oleg Nesterov [this message]
2013-09-16 22:16   ` [PATCH 1/1] " Peter Hurley
2013-09-17 19:41     ` Carlos O'Donell
2013-09-17 20:30       ` Peter Hurley
2013-09-17 20:39   ` Peter Hurley
2013-09-21 18:34     ` Oleg Nesterov
2013-09-21 20:25       ` Peter Hurley
2013-09-22 20:03         ` Oleg Nesterov
2013-09-24 18:18           ` Peter Hurley
2013-09-25 16:21 ` v3.10 breaks T.tcflush (Was: tty: disassociate_ctty() sends the extra SIGCONT) Oleg Nesterov
2013-09-25 17:56   ` Oleg Nesterov
2013-09-26  0:06   ` Peter Hurley
2013-09-26  0:13     ` [PATCH] tty: Fix SIGTTOU not sent with tcflush() Peter Hurley
2013-09-26  0:24       ` Greg Kroah-Hartman
2013-09-26 16:36       ` Oleg Nesterov
2013-09-26 19:10         ` Oleg Nesterov
2013-09-26 21:18           ` Peter Hurley
2013-09-27  5:19           ` Karel Srot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130915155026.GA11917@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=codonell@redhat.com \
    --cc=ebenes@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=ksrot@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mnewsome@redhat.com \
    --cc=peter@hurleysoftware.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.