All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: mingo@kernel.org, hpa@zytor.com,
	Robin Holt <robin.m.holt@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>, Rob Landley <rob@landley.net>,
	Mike Travis <travis@sgi.com>,
	Daniel J Blueman <daniel@numascale-asia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] Have __free_pages_memory() free in larger chunks.
Date: Sun, 15 Sep 2013 13:03:39 -0400	[thread overview]
Message-ID: <20130915170339.GA3278@cmpxchg.org> (raw)
In-Reply-To: <1378839444-196190-1-git-send-email-nzimmer@sgi.com>

On Tue, Sep 10, 2013 at 01:57:24PM -0500, Nathan Zimmer wrote:
> From: Robin Holt <robin.m.holt@gmail.com>
> 
> On large memory machines it can take a few minutes to get through
> free_all_bootmem().
> 
> Currently, when free_all_bootmem() calls __free_pages_memory(), the
> number of contiguous pages that __free_pages_memory() passes to the
> buddy allocator is limited to BITS_PER_LONG.  BITS_PER_LONG was originally
> chosen to keep things similar to mm/nobootmem.c.  But it is more
> efficient to limit it to MAX_ORDER.
> 
>        base   new  change
> 8TB    202s  172s   30s
> 16TB   401s  351s   50s
> 
> That is around 1%-3% improvement on total boot time.
> 
> This patch was spun off from the boot time rfc Robin and I had been
> working on.
> 
> Signed-off-by: Robin Holt <robin.m.holt@gmail.com>
> Signed-off-by: Nathan Zimmer <nzimmer@sgi.com>
> To: "H. Peter Anvin" <hpa@zytor.com>
> To: Ingo Molnar <mingo@kernel.org>
> Cc: Linux Kernel <linux-kernel@vger.kernel.org>
> Cc: Linux MM <linux-mm@kvack.org>
> Cc: Rob Landley <rob@landley.net>
> Cc: Mike Travis <travis@sgi.com>
> Cc: Daniel J Blueman <daniel@numascale-asia.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Mel Gorman <mgorman@suse.de>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Nathan Zimmer <nzimmer@sgi.com>
Cc: mingo@kernel.org, hpa@zytor.com,
	Robin Holt <robin.m.holt@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>, Rob Landley <rob@landley.net>,
	Mike Travis <travis@sgi.com>,
	Daniel J Blueman <daniel@numascale-asia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Yinghai Lu <yinghai@kernel.org>, Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] Have __free_pages_memory() free in larger chunks.
Date: Sun, 15 Sep 2013 13:03:39 -0400	[thread overview]
Message-ID: <20130915170339.GA3278@cmpxchg.org> (raw)
In-Reply-To: <1378839444-196190-1-git-send-email-nzimmer@sgi.com>

On Tue, Sep 10, 2013 at 01:57:24PM -0500, Nathan Zimmer wrote:
> From: Robin Holt <robin.m.holt@gmail.com>
> 
> On large memory machines it can take a few minutes to get through
> free_all_bootmem().
> 
> Currently, when free_all_bootmem() calls __free_pages_memory(), the
> number of contiguous pages that __free_pages_memory() passes to the
> buddy allocator is limited to BITS_PER_LONG.  BITS_PER_LONG was originally
> chosen to keep things similar to mm/nobootmem.c.  But it is more
> efficient to limit it to MAX_ORDER.
> 
>        base   new  change
> 8TB    202s  172s   30s
> 16TB   401s  351s   50s
> 
> That is around 1%-3% improvement on total boot time.
> 
> This patch was spun off from the boot time rfc Robin and I had been
> working on.
> 
> Signed-off-by: Robin Holt <robin.m.holt@gmail.com>
> Signed-off-by: Nathan Zimmer <nzimmer@sgi.com>
> To: "H. Peter Anvin" <hpa@zytor.com>
> To: Ingo Molnar <mingo@kernel.org>
> Cc: Linux Kernel <linux-kernel@vger.kernel.org>
> Cc: Linux MM <linux-mm@kvack.org>
> Cc: Rob Landley <rob@landley.net>
> Cc: Mike Travis <travis@sgi.com>
> Cc: Daniel J Blueman <daniel@numascale-asia.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Greg KH <gregkh@linuxfoundation.org>
> Cc: Yinghai Lu <yinghai@kernel.org>
> Cc: Mel Gorman <mgorman@suse.de>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

  reply	other threads:[~2013-09-15 17:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 18:57 [PATCH] Have __free_pages_memory() free in larger chunks Nathan Zimmer
2013-09-10 18:57 ` Nathan Zimmer
2013-09-15 17:03 ` Johannes Weiner [this message]
2013-09-15 17:03   ` Johannes Weiner
2013-10-05 11:30 ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130915170339.GA3278@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=daniel@numascale-asia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=nzimmer@sgi.com \
    --cc=rob@landley.net \
    --cc=robin.m.holt@gmail.com \
    --cc=travis@sgi.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.