All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org,
	Akira Hayakawa <ruby.wktk@gmail.com>,
	dm-devel@redhat.com, cesarb@cesarb.net, joe@perches.com,
	akpm@linux-foundation.org, agk@redhat.com, m.chehab@samsung.com
Subject: Re: staging: Add dm-writeboost
Date: Tue, 17 Sep 2013 01:49:39 +0300	[thread overview]
Message-ID: <20130916224939.GT25896@mwanda> (raw)
In-Reply-To: <20130916215357.GA5015@redhat.com>

On Mon, Sep 16, 2013 at 05:53:57PM -0400, Mike Snitzer wrote:
> - variable names need to be a bit more verbose (arr => array)

"struct array " is a horrible name.  :P  Please don't use either "arr"
or "array".

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Akira Hayakawa <ruby.wktk@gmail.com>,
	devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, dm-devel@redhat.com,
	agk@redhat.com, joe@perches.com, akpm@linux-foundation.org,
	cesarb@cesarb.net, m.chehab@samsung.com
Subject: Re: staging: Add dm-writeboost
Date: Tue, 17 Sep 2013 01:49:39 +0300	[thread overview]
Message-ID: <20130916224939.GT25896@mwanda> (raw)
In-Reply-To: <20130916215357.GA5015@redhat.com>

On Mon, Sep 16, 2013 at 05:53:57PM -0400, Mike Snitzer wrote:
> - variable names need to be a bit more verbose (arr => array)

"struct array " is a horrible name.  :P  Please don't use either "arr"
or "array".

regards,
dan carpenter


  reply	other threads:[~2013-09-16 22:49 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-01 11:10 [PATCH] staging: Add dm-writeboost Akira Hayakawa
2013-09-16 21:53 ` Mike Snitzer
2013-09-16 21:53   ` Mike Snitzer
2013-09-16 22:49   ` Dan Carpenter [this message]
2013-09-16 22:49     ` Dan Carpenter
2013-09-17 12:41   ` Akira Hayakawa
2013-09-17 12:41     ` Akira Hayakawa
2013-09-17 20:18     ` Mike Snitzer
2013-09-17 20:18       ` Mike Snitzer
2013-09-17 12:43   ` Akira Hayakawa
2013-09-17 12:43     ` Akira Hayakawa
2013-09-17 20:59     ` Mike Snitzer
2013-09-17 20:59       ` Mike Snitzer
2013-09-22  0:09       ` Reworking dm-writeboost [was: Re: staging: Add dm-writeboost] Akira Hayakawa
2013-09-22  0:09         ` Akira Hayakawa
2013-09-24 12:20         ` Akira Hayakawa
2013-09-24 12:20           ` Akira Hayakawa
2013-09-25 17:37           ` Mike Snitzer
2013-09-25 17:37             ` Mike Snitzer
2013-09-26  1:42             ` Akira Hayakawa
2013-09-26  1:47             ` Akira Hayakawa
2013-09-27 18:35               ` Mike Snitzer
2013-09-27 18:35                 ` Mike Snitzer
2013-09-28 11:29                 ` Akira Hayakawa
2013-09-28 11:29                   ` Akira Hayakawa
2013-09-25 23:03           ` Greg KH
2013-09-25 23:03             ` Greg KH
2013-09-26  3:43           ` Dave Chinner
2013-10-01  8:26             ` Joe Thornber
2013-10-01  8:26               ` Joe Thornber
2013-10-03  0:01               ` Mikulas Patocka
2013-10-03  0:01                 ` [dm-devel] " Mikulas Patocka
2013-10-04  2:04                 ` Dave Chinner
2013-10-04  2:04                   ` Dave Chinner
2013-10-05  7:51                   ` Akira Hayakawa
2013-10-07 23:43                     ` Dave Chinner
2013-10-08  9:41                       ` Christoph Hellwig
2013-10-08  9:41                         ` Christoph Hellwig
2013-10-08 10:37                         ` Akira Hayakawa
2013-10-08 10:37                           ` Akira Hayakawa
2013-10-08 15:29                           ` Mike Snitzer
2013-10-09  1:07                             ` Akira Hayakawa
2013-10-09  1:07                               ` Akira Hayakawa
2013-10-08 10:57                       ` [dm-devel] " Akira Hayakawa
2013-10-08 10:57                         ` Akira Hayakawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130916224939.GT25896@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cesarb@cesarb.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=ruby.wktk@gmail.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.