All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-qt5][PATCH] Added module qtquickcontrols
@ 2013-09-11 11:19 Erik Botö
  2013-09-11 11:22 ` Laszlo Papp
  2013-09-17 12:55 ` Erik Botö
  0 siblings, 2 replies; 6+ messages in thread
From: Erik Botö @ 2013-09-11 11:19 UTC (permalink / raw)
  To: openembedded-devel

Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
---
 recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
 recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
 2 files changed, 8 insertions(+)
 create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
 create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb

diff --git a/recipes-qt/qt5/qtquickcontrols.inc b/recipes-qt/qt5/qtquickcontrols.inc
new file mode 100644
index 0000000..63e884e
--- /dev/null
+++ b/recipes-qt/qt5/qtquickcontrols.inc
@@ -0,0 +1,3 @@
+require qt5.inc
+
+DEPENDS += "qtdeclarative"
diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
new file mode 100644
index 0000000..fc880d7
--- /dev/null
+++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
@@ -0,0 +1,5 @@
+require qt5-${PV}.inc
+require ${PN}.inc
+
+SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
+SRC_URI[sha256sum] = "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
-- 
1.8.1.2



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [meta-qt5][PATCH] Added module qtquickcontrols
  2013-09-11 11:19 [meta-qt5][PATCH] Added module qtquickcontrols Erik Botö
@ 2013-09-11 11:22 ` Laszlo Papp
  2013-09-11 11:27   ` Erik Botö
  2013-09-17 12:55 ` Erik Botö
  1 sibling, 1 reply; 6+ messages in thread
From: Laszlo Papp @ 2013-09-11 11:22 UTC (permalink / raw)
  To: openembedded-devel

Were you able to run an example after adding this?


On Wed, Sep 11, 2013 at 12:19 PM, Erik Botö <erik.boto@pelagicore.com>wrote:

> Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> ---
>  recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
>  recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
>  2 files changed, 8 insertions(+)
>  create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
>  create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb
>
> diff --git a/recipes-qt/qt5/qtquickcontrols.inc
> b/recipes-qt/qt5/qtquickcontrols.inc
> new file mode 100644
> index 0000000..63e884e
> --- /dev/null
> +++ b/recipes-qt/qt5/qtquickcontrols.inc
> @@ -0,0 +1,3 @@
> +require qt5.inc
> +
> +DEPENDS += "qtdeclarative"
> diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/
> qtquickcontrols_5.1.0.bb
> new file mode 100644
> index 0000000..fc880d7
> --- /dev/null
> +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> @@ -0,0 +1,5 @@
> +require qt5-${PV}.inc
> +require ${PN}.inc
> +
> +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
> +SRC_URI[sha256sum] =
> "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
> --
> 1.8.1.2
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-qt5][PATCH] Added module qtquickcontrols
  2013-09-11 11:22 ` Laszlo Papp
@ 2013-09-11 11:27   ` Erik Botö
  2013-09-11 11:32     ` Laszlo Papp
  0 siblings, 1 reply; 6+ messages in thread
From: Erik Botö @ 2013-09-11 11:27 UTC (permalink / raw)
  To: openembedded-devel

Yes, I have a project that uses "QtQuick.Layouts 1.0" and
"QtQuick.Controls 1.0". I haven't done extensive testing, but after
adding this module the GUI starts and seems to be working as intended.

Cheers,
Erik

On Wed, Sep 11, 2013 at 1:22 PM, Laszlo Papp <lpapp@kde.org> wrote:
> Were you able to run an example after adding this?
>
>
> On Wed, Sep 11, 2013 at 12:19 PM, Erik Botö <erik.boto@pelagicore.com>wrote:
>
>> Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
>> ---
>>  recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
>>  recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
>>  2 files changed, 8 insertions(+)
>>  create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
>>  create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb
>>
>> diff --git a/recipes-qt/qt5/qtquickcontrols.inc
>> b/recipes-qt/qt5/qtquickcontrols.inc
>> new file mode 100644
>> index 0000000..63e884e
>> --- /dev/null
>> +++ b/recipes-qt/qt5/qtquickcontrols.inc
>> @@ -0,0 +1,3 @@
>> +require qt5.inc
>> +
>> +DEPENDS += "qtdeclarative"
>> diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/
>> qtquickcontrols_5.1.0.bb
>> new file mode 100644
>> index 0000000..fc880d7
>> --- /dev/null
>> +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
>> @@ -0,0 +1,5 @@
>> +require qt5-${PV}.inc
>> +require ${PN}.inc
>> +
>> +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
>> +SRC_URI[sha256sum] =
>> "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
>> --
>> 1.8.1.2
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel



-- 
=============================================
Erik Botö
Senior Software Engineer
Pelagicore AB
Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden
Mobile: +46 (0)76 881 72 03
E-Mail: erik.boto@pelagicore.com
=============================================


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-qt5][PATCH] Added module qtquickcontrols
  2013-09-11 11:27   ` Erik Botö
@ 2013-09-11 11:32     ` Laszlo Papp
  0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Papp @ 2013-09-11 11:32 UTC (permalink / raw)
  To: openembedded-devel

Very nice, thanks.


On Wed, Sep 11, 2013 at 12:27 PM, Erik Botö <erik.boto@pelagicore.com>wrote:

> Yes, I have a project that uses "QtQuick.Layouts 1.0" and
> "QtQuick.Controls 1.0". I haven't done extensive testing, but after
> adding this module the GUI starts and seems to be working as intended.
>
> Cheers,
> Erik
>
> On Wed, Sep 11, 2013 at 1:22 PM, Laszlo Papp <lpapp@kde.org> wrote:
> > Were you able to run an example after adding this?
> >
> >
> > On Wed, Sep 11, 2013 at 12:19 PM, Erik Botö <erik.boto@pelagicore.com
> >wrote:
> >
> >> Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> >> ---
> >>  recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
> >>  recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
> >>  2 files changed, 8 insertions(+)
> >>  create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
> >>  create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> >>
> >> diff --git a/recipes-qt/qt5/qtquickcontrols.inc
> >> b/recipes-qt/qt5/qtquickcontrols.inc
> >> new file mode 100644
> >> index 0000000..63e884e
> >> --- /dev/null
> >> +++ b/recipes-qt/qt5/qtquickcontrols.inc
> >> @@ -0,0 +1,3 @@
> >> +require qt5.inc
> >> +
> >> +DEPENDS += "qtdeclarative"
> >> diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/
> >> qtquickcontrols_5.1.0.bb
> >> new file mode 100644
> >> index 0000000..fc880d7
> >> --- /dev/null
> >> +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> >> @@ -0,0 +1,5 @@
> >> +require qt5-${PV}.inc
> >> +require ${PN}.inc
> >> +
> >> +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
> >> +SRC_URI[sha256sum] =
> >> "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
> >> --
> >> 1.8.1.2
> >>
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>
> --
> =============================================
> Erik Botö
> Senior Software Engineer
> Pelagicore AB
> Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden
> Mobile: +46 (0)76 881 72 03
> E-Mail: erik.boto@pelagicore.com
> =============================================
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-qt5][PATCH] Added module qtquickcontrols
  2013-09-11 11:19 [meta-qt5][PATCH] Added module qtquickcontrols Erik Botö
  2013-09-11 11:22 ` Laszlo Papp
@ 2013-09-17 12:55 ` Erik Botö
  2013-09-17 15:39   ` Martin Jansa
  1 sibling, 1 reply; 6+ messages in thread
From: Erik Botö @ 2013-09-17 12:55 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Laszlo Papp

Hi,

I just realized this patch does not package all files. The qt5.inc
only pick up on files three directories "deep", so I have to extend
this in qtquickcontrols.inc using:

FILES_${PN}-qmlplugins += " \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/qmldir \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qmltypes \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qml \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*.js \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*/qmldir \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qmltypes \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qml \
    ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.js \
    "

I would assume that this is better done in qt5.inc, can't really think
of any big drawback with having it central instead of per module and I
guess the decision to go "three deep" was just that it covered the
modules that recipes was written for at that time. Right?

Cheers,
Erik

On Wed, Sep 11, 2013 at 1:19 PM, Erik Botö <erik.boto@pelagicore.com> wrote:
> Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> ---
>  recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
>  recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
>  2 files changed, 8 insertions(+)
>  create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
>  create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb
>
> diff --git a/recipes-qt/qt5/qtquickcontrols.inc b/recipes-qt/qt5/qtquickcontrols.inc
> new file mode 100644
> index 0000000..63e884e
> --- /dev/null
> +++ b/recipes-qt/qt5/qtquickcontrols.inc
> @@ -0,0 +1,3 @@
> +require qt5.inc
> +
> +DEPENDS += "qtdeclarative"
> diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> new file mode 100644
> index 0000000..fc880d7
> --- /dev/null
> +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> @@ -0,0 +1,5 @@
> +require qt5-${PV}.inc
> +require ${PN}.inc
> +
> +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
> +SRC_URI[sha256sum] = "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
> --
> 1.8.1.2
>



-- 
=============================================
Erik Botö
Senior Software Engineer
Pelagicore AB
Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden
Mobile: +46 (0)76 881 72 03
E-Mail: erik.boto@pelagicore.com
=============================================


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [meta-qt5][PATCH] Added module qtquickcontrols
  2013-09-17 12:55 ` Erik Botö
@ 2013-09-17 15:39   ` Martin Jansa
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2013-09-17 15:39 UTC (permalink / raw)
  To: Erik Botö; +Cc: Laszlo Papp, openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2909 bytes --]

On Tue, Sep 17, 2013 at 02:55:52PM +0200, Erik Botö wrote:
> Hi,
> 
> I just realized this patch does not package all files. The qt5.inc
> only pick up on files three directories "deep", so I have to extend
> this in qtquickcontrols.inc using:
> 
> FILES_${PN}-qmlplugins += " \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/qmldir \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qmltypes \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*.qml \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*.js \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*/qmldir \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qmltypes \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.qml \
>     ${OE_QMAKE_PATH_QML}/*/*/*/*/*/*.js \
>     "
> 
> I would assume that this is better done in qt5.inc, can't really think
> of any big drawback with having it central instead of per module and I
> guess the decision to go "three deep" was just that it covered the
> modules that recipes was written for at that time. Right?

Right, please notice that 
https://github.com/meta-qt5/meta-qt5/commit/f11b1722e28800c790609d0de9541f6555e1ee5a
was merged today and resolves this.

You probably didn't know about alternative patch, because it was sitting
on github as pull-request and it wasn't sent to oe-devel, contributor is
now aware and will send next patches to oe-devel first.

Regards,

> 
> Cheers,
> Erik
> 
> On Wed, Sep 11, 2013 at 1:19 PM, Erik Botö <erik.boto@pelagicore.com> wrote:
> > Signed-off-by: Erik Botö <erik.boto@pelagicore.com>
> > ---
> >  recipes-qt/qt5/qtquickcontrols.inc      | 3 +++
> >  recipes-qt/qt5/qtquickcontrols_5.1.0.bb | 5 +++++
> >  2 files changed, 8 insertions(+)
> >  create mode 100644 recipes-qt/qt5/qtquickcontrols.inc
> >  create mode 100644 recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> >
> > diff --git a/recipes-qt/qt5/qtquickcontrols.inc b/recipes-qt/qt5/qtquickcontrols.inc
> > new file mode 100644
> > index 0000000..63e884e
> > --- /dev/null
> > +++ b/recipes-qt/qt5/qtquickcontrols.inc
> > @@ -0,0 +1,3 @@
> > +require qt5.inc
> > +
> > +DEPENDS += "qtdeclarative"
> > diff --git a/recipes-qt/qt5/qtquickcontrols_5.1.0.bb b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> > new file mode 100644
> > index 0000000..fc880d7
> > --- /dev/null
> > +++ b/recipes-qt/qt5/qtquickcontrols_5.1.0.bb
> > @@ -0,0 +1,5 @@
> > +require qt5-${PV}.inc
> > +require ${PN}.inc
> > +
> > +SRC_URI[md5sum] = "b3825124a173a36f63c2f8380dc61e81"
> > +SRC_URI[sha256sum] = "88d39421d78464c3900c37616e8369fc8d998c1b0f611980e6e082f46569646b"
> > --
> > 1.8.1.2
> >
> 
> 
> 
> -- 
> =============================================
> Erik Botö
> Senior Software Engineer
> Pelagicore AB
> Ekelundsgatan 4, 6tr, SE-411 18 Gothenburg, Sweden
> Mobile: +46 (0)76 881 72 03
> E-Mail: erik.boto@pelagicore.com
> =============================================

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-17 15:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-11 11:19 [meta-qt5][PATCH] Added module qtquickcontrols Erik Botö
2013-09-11 11:22 ` Laszlo Papp
2013-09-11 11:27   ` Erik Botö
2013-09-11 11:32     ` Laszlo Papp
2013-09-17 12:55 ` Erik Botö
2013-09-17 15:39   ` Martin Jansa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.