From: Felipe Balbi <balbi@ti.com>
To: Pavel Machek <pavel@denx.de>
Cc: kernel list <linux-kernel@vger.kernel.org>, <balbi@ti.com>,
<linux-usb@vger.kernel.org>
Subject: Re: Fix style in s3c-hsotg.c
Date: Tue, 17 Sep 2013 10:42:30 -0500 [thread overview]
Message-ID: <20130917154229.GI15645@radagast> (raw)
In-Reply-To: <20130902135832.GA22300@amd.pavel.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
Hi,
On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> Hi!
>
> checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> macro with if should be really enclosed in do {} while, and puts is
> going to be slightly faster.
>
> Here's suggested patch. I don't have the hardware, so it is completely
> untested.
>
> Signed-off-by: Pavel Machek, <pavel@denx.de>
this is not how you send a patch, please read
Documentation/SubmittingPatches
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-17 15:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 13:58 Fix style in s3c-hsotg.c Pavel Machek
2013-09-02 17:25 ` Sergei Shtylyov
2013-09-17 15:42 ` Felipe Balbi [this message]
2013-09-17 22:04 ` Pavel Machek
2013-09-18 1:45 ` Felipe Balbi
2013-09-18 9:20 ` Pavel Machek
2013-09-18 14:11 ` Felipe Balbi
2013-09-25 15:39 ` Bartlomiej Zolnierkiewicz
2013-09-25 20:35 ` Felipe Balbi
2013-09-25 23:53 ` Pavel Machek
2013-09-25 21:15 ` Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 1:33 Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917154229.GI15645@radagast \
--to=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.