Re: Fix style in s3c-hsotg.c

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 09/02/2013 05:58 PM, Pavel Machek wrote:

> checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> macro with if should be really enclosed in do {} while, and puts is
> going to be slightly faster.

> Here's suggested patch. I don't have the hardware, so it is completely
> untested.

> Signed-off-by: Pavel Machek, <pavel@denx.de>

> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index af22f24..f8e762a 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -2091,12 +2091,14 @@ static void kill_all_requests(struct s3c_hsotg *hsotg,
>   }
>
>   #define call_gadget(_hs, _entry) \
> +do { \
>   	if ((_hs)->gadget.speed != USB_SPEED_UNKNOWN &&	\
>   	    (_hs)->driver && (_hs)->driver->_entry) { \
>   		spin_unlock(&_hs->lock); \
>   		(_hs)->driver->_entry(&(_hs)->gadget); \
>   		spin_lock(&_hs->lock); \
>   		}

    Indentation also needs fixing on this line, maybe in another patch...

> +} while (0)

WBR, Sergei