Re: [Qemu-devel] [PATCH v2 1/2] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

[Michael Walle <michael@walle.cc>]

Am Montag, 2. September 2013, 00:58:42 schrieb Peter Crosthwaite:
> On Sun, Sep 1, 2013 at 3:22 AM, Antony Pavlov <antonynpavlov@gmail.com> 
wrote:
> > qemu_chr_fe_write() is capable of returning 0
> > to indicate EAGAIN (and friends) and we don't
> > handle this.
> > 
> > Just change it to qemu_chr_fe_write_all() to fix.
> > 
> > Reported-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> 
> Acked-by Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> 
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > CC: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> > CC: Michael Walle <michael@walle.cc>
> > CC: Andreas Färber <afaerber@suse.de>
> > ---
> > 
> >  hw/char/milkymist-uart.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c
> > index 2e4b5c5..6e4bc20 100644
> > --- a/hw/char/milkymist-uart.c
> > +++ b/hw/char/milkymist-uart.c
> > @@ -124,7 +124,7 @@ static void uart_write(void *opaque, hwaddr addr,
> > uint64_t value,
> > 
> >      switch (addr) {
> >      
> >      case R_RXTX:
> >          if (s->chr) {
> > 
> > -            qemu_chr_fe_write(s->chr, &ch, 1);
> > +            qemu_chr_fe_write_all(s->chr, &ch, 1);
> > 
> >          }
> >          s->regs[R_STAT] |= STAT_TX_EVT;
> >          break;
> > 
> > --
> > 1.8.4.rc3

I'll pick this one. Thank you.

-- 
michael