From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Dave Martin" <Dave.Martin@arm.com>,
"Ивайло Димитров" <freemangordon@abv.bg>, "nm@ti.com" <nm@ti.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1
Date: Tue, 17 Sep 2013 16:17:44 -0700 [thread overview]
Message-ID: <20130917231744.GJ9994@atomide.com> (raw)
In-Reply-To: <201309171753.24433@pali>
* Pali Rohár <pali.rohar@gmail.com> [130917 09:01]:
> On Tuesday 17 September 2013 17:43:31 Tony Lindgren wrote:
> > Have you guys checked how this works with the recently posted
> > "[PATCH v6 0/5] ARM: support for Trusted Foundations secure
> > monitor" series?
>
> this code looks like some Tegra and "Trusted Foundations"
> specific. There is Note: The API followed by Trusted Foundations
> does *not* follow the SMC calling conventions. Also code calling
> smc #0 instruction, so in my opinion for rx51 it is useless.
OK, so still no generic SMC code then :( This patch is fine
with me.
> Tony, can you include this two rx51 secure patches (patch v4 1/2
> and patch v2 2/2)? Or is there some any other problem?
No other comments on this patch, I'll post some comments on the
v2 2/2 patch considering we're moving to device tree based
booting.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1
Date: Tue, 17 Sep 2013 16:17:44 -0700 [thread overview]
Message-ID: <20130917231744.GJ9994@atomide.com> (raw)
In-Reply-To: <201309171753.24433@pali>
* Pali Roh?r <pali.rohar@gmail.com> [130917 09:01]:
> On Tuesday 17 September 2013 17:43:31 Tony Lindgren wrote:
> > Have you guys checked how this works with the recently posted
> > "[PATCH v6 0/5] ARM: support for Trusted Foundations secure
> > monitor" series?
>
> this code looks like some Tegra and "Trusted Foundations"
> specific. There is Note: The API followed by Trusted Foundations
> does *not* follow the SMC calling conventions. Also code calling
> smc #0 instruction, so in my opinion for rx51 it is useless.
OK, so still no generic SMC code then :( This patch is fine
with me.
> Tony, can you include this two rx51 secure patches (patch v4 1/2
> and patch v2 2/2)? Or is there some any other problem?
No other comments on this patch, I'll post some comments on the
v2 2/2 patch considering we're moving to device tree based
booting.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Dave Martin" <Dave.Martin@arm.com>,
"Ивайло Димитров" <freemangordon@abv.bg>, "nm@ti.com" <nm@ti.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
"pdeschrijver@nvidia.com" <pdeschrijver@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"santosh.shilimkar@ti.com" <santosh.shilimkar@ti.com>,
"pavel@ucw.cz" <pavel@ucw.cz>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1
Date: Tue, 17 Sep 2013 16:17:44 -0700 [thread overview]
Message-ID: <20130917231744.GJ9994@atomide.com> (raw)
In-Reply-To: <201309171753.24433@pali>
* Pali Rohár <pali.rohar@gmail.com> [130917 09:01]:
> On Tuesday 17 September 2013 17:43:31 Tony Lindgren wrote:
> > Have you guys checked how this works with the recently posted
> > "[PATCH v6 0/5] ARM: support for Trusted Foundations secure
> > monitor" series?
>
> this code looks like some Tegra and "Trusted Foundations"
> specific. There is Note: The API followed by Trusted Foundations
> does *not* follow the SMC calling conventions. Also code calling
> smc #0 instruction, so in my opinion for rx51 it is useless.
OK, so still no generic SMC code then :( This patch is fine
with me.
> Tony, can you include this two rx51 secure patches (patch v4 1/2
> and patch v2 2/2)? Or is there some any other problem?
No other comments on this patch, I'll post some comments on the
v2 2/2 patch considering we're moving to device tree based
booting.
Regards,
Tony
next prev parent reply other threads:[~2013-09-17 23:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 17:10 [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3() which calling instruction smc #1 Dave Martin
2013-09-17 15:43 ` Tony Lindgren
2013-09-17 15:43 ` Tony Lindgren
2013-09-17 15:53 ` Pali Rohár
2013-09-17 15:53 ` Pali Rohár
2013-09-17 23:17 ` Tony Lindgren [this message]
2013-09-17 23:17 ` Tony Lindgren
2013-09-17 23:17 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 12:43 [PATCH v3 " Dave Martin
2013-09-08 7:43 ` [PATCH v4 " Pali Rohár
2013-09-08 7:43 ` Pali Rohár
2013-09-14 9:37 ` Pali Rohár
2013-09-14 9:37 ` Pali Rohár
2013-10-08 7:13 ` Ben Dooks
2013-10-08 7:13 ` Ben Dooks
2013-10-08 7:13 ` Ben Dooks
2013-10-08 8:09 ` Russell King - ARM Linux
2013-10-08 8:09 ` Russell King - ARM Linux
2013-10-08 19:05 ` Tony Lindgren
2013-10-08 19:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917231744.GJ9994@atomide.com \
--to=tony@atomide.com \
--cc=Dave.Martin@arm.com \
--cc=aaro.koskinen@iki.fi \
--cc=freemangordon@abv.bg \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=pdeschrijver@nvidia.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.