All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition
Date: Wed, 18 Sep 2013 18:55:39 +0200	[thread overview]
Message-ID: <20130918185539.00adb05c@skate> (raw)
In-Reply-To: <1379503071-5446-1-git-send-email-fatih.asici@gmail.com>

Dear Fatih A??c?,

On Wed, 18 Sep 2013 14:17:51 +0300, Fatih A??c? wrote:
> The build with gpu-viv-bin-mx6q libraries was broken since it wasn't
> using "-DEGL_API_FB=1" flag which is found in egl.pc.
> 
> Signed-off-by: Fatih A??c? <fatih.asici@gmail.com>
> ---
>  package/qt5/qt5base/qt5base-egl-cflags.patch |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 package/qt5/qt5base/qt5base-egl-cflags.patch
> 
> diff --git a/package/qt5/qt5base/qt5base-egl-cflags.patch b/package/qt5/qt5base/qt5base-egl-cflags.patch
> new file mode 100644
> index 0000000..7f9d779
> --- /dev/null
> +++ b/package/qt5/qt5base/qt5base-egl-cflags.patch

All patches should have a description, and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

> @@ -0,0 +1,21 @@
> +--- a/configure
> ++++ b/configure
> +@@ -5391,6 +5391,7 @@
> +         QMAKE_CFLAGS_EGL=`$PKG_CONFIG --cflags egl 2>/dev/null`
> +         QMakeVar set QMAKE_INCDIR_EGL "$QMAKE_INCDIR_EGL"
> +         QMakeVar set QMAKE_LIBS_EGL "$QMAKE_LIBS_EGL"
> ++        QMakeVar set QMAKE_CFLAGS_EGL "$QMAKE_CFLAGS_EGL"
> +     fi       # detect EGL support
> +     if compileTest qpa/egl "EGL" $QMAKE_CFLAGS_EGL $QMAKE_LIBS_EGL; then
> +         CFG_EGL=yes
> +--- a/mkspecs/features/egl.prf
> ++++ b/mkspecs/features/egl.prf
> +@@ -14,6 +14,8 @@
> + } else {
> +     INCLUDEPATH += $$QMAKE_INCDIR_EGL
> +     LIBS_PRIVATE += $$QMAKE_LIBS_EGL
> ++    QMAKE_CFLAGS += $$QMAKE_CFLAGS_EGL
> ++    QMAKE_CXXFLAGS += $$QMAKE_CFLAGS_EGL

Shouldn't we have separate QMAKE_CFLAGS_EGL and QMAKE_CXXFLAGS_EGL ? Or
are you following a pattern used in other places?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2013-09-18 16:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-18 11:17 [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition Fatih Aşıcı
2013-09-18 16:55 ` Thomas Petazzoni [this message]
2013-09-18 21:28   ` Arnout Vandecappelle
2013-09-19  4:12     ` Thomas Petazzoni
2013-09-19 17:36       ` Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2013-09-18 18:48 Fatih Aşıcı

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130918185539.00adb05c@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.