From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition
Date: Thu, 19 Sep 2013 19:36:26 +0200 [thread overview]
Message-ID: <523B361A.6070603@mind.be> (raw)
In-Reply-To: <20130919061233.35eb34e3@skate>
On 19/09/13 06:12, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Wed, 18 Sep 2013 23:28:03 +0200, Arnout Vandecappelle wrote:
>
>>>>> +++ b/package/qt5/qt5base/qt5base-egl-cflags.patch
>>> All patches should have a description, and a Signed-off-by line. See
>>> http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
>>
>> Also, please give your patch a number so that the order in which
>> they're applied is predictable. At the moment this probably doesn't
>> matter much, but it makes it easier later on to make sure a new patch
>> will be applied after this one.
>
> Yeah, I also wanted to ask that, but there are existing patches for
> qt5base that doesn't comply with this, so I felt that it was maybe not
> appropriate to ask a contributor to fix our (my ?) mess :-)
>
> But indeed, Fatih, as a preparation patch, you could add number to the
> existing patches, and then add your own.
I didn't say to add a number to the existing patches. Since the order
doesn't matter for this patch, you can just give this patch a number and
leave the other ones alone. This is particularly relevant since your qt5
version bumping patch removes some of the patches, so renaming would give
a conflict...
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-09-19 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 11:17 [Buildroot] [PATCH] qt5base: fix build when egl headers need a definition Fatih Aşıcı
2013-09-18 16:55 ` Thomas Petazzoni
2013-09-18 21:28 ` Arnout Vandecappelle
2013-09-19 4:12 ` Thomas Petazzoni
2013-09-19 17:36 ` Arnout Vandecappelle [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-09-18 18:48 Fatih Aşıcı
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523B361A.6070603@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.