All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: "Cooper Jr., Franklin" <fcooper@ti.com>
Cc: "meta-arago@arago-project.org" <meta-arago@arago-project.org>
Subject: Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage
Date: Fri, 20 Sep 2013 16:53:11 -0400	[thread overview]
Message-ID: <20130920205310.GE30673@edge> (raw)
In-Reply-To: <8F29D6B095ED194EA1980491A5E029710C558340@DFLE08.ent.ti.com>

On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin wrote:
> 
> 
> > -----Original Message-----
> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > bounces@arago-project.org] On Behalf Of Maupin, Chase
> > Sent: Friday, September 20, 2013 3:31 PM
> > To: Denys Dmytriyenko
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks
> > when packaging data to avoid breakage
> > 
> > Will this still package things like the patches applied on top of the kernel in the
> > kernel sources?
> 
> [Franklin] Good call. Your right it doesn't. I gave it a shot and the 
> symbolic link remains but of course the link is broken if it is used on a 
> different machine.

Yeah, I had the same question originally. Unfortunately, you cannot assume 
there are no broken links in the sources to begin with. And those broken 
symlinks cannot be dereferenced w/o breaking the entire tar command and hence 
the build. That is what we discussed couple days ago - kernel now has a broken 
symlink that kills our sourceipk...

Why do patches symlinked and not copied? Can we fix that step instead of doing 
it in tar command?

-- 
Denys


> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" <denis@denix.org> wrote:
> > 
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-
> > distro/classes/sourceipk.bbclass
> > > index 1ea0577..777cb4f 100644
> > > --- a/meta-arago-distro/classes/sourceipk.bbclass
> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass
> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() {
> > >         fi
> > >
> > >         #Write the data tarball
> > > -        tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
> > > +        tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
> > >
> > >         # Create the debian-binary file
> > >         echo "2.0" > $srcipk_dir/debian-binary
> > > --
> > > 1.8.3.2
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


  reply	other threads:[~2013-09-20 20:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-20 18:59 [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage Denys Dmytriyenko
2013-09-20 19:28 ` Cooper Jr., Franklin
2013-09-20 19:31   ` Denys Dmytriyenko
2013-09-20 19:40 ` Cooper Jr., Franklin
2013-09-20 20:31 ` Maupin, Chase
2013-09-20 20:49   ` Cooper Jr., Franklin
2013-09-20 20:53     ` Denys Dmytriyenko [this message]
2013-09-23 15:34       ` Maupin, Chase
2013-09-23 17:55         ` Denys Dmytriyenko
2013-09-23 20:12           ` Cooper Jr., Franklin
2013-09-23 21:37             ` Denys Dmytriyenko
2013-09-23 22:09               ` Cooper Jr., Franklin
2013-09-24  0:44                 ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130920205310.GE30673@edge \
    --to=denys@ti.com \
    --cc=fcooper@ti.com \
    --cc=meta-arago@arago-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.