Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote:
> >-----Original Message-----
> >From: Dmytriyenko, Denys
> >Sent: Friday, September 20, 2013 4:53 PM
> >To: Cooper Jr., Franklin
> >Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org
> >Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference
> >symlinks when packaging data to avoid breakage
> >
> >On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin
> >wrote:
> >>
> >>
> >> > -----Original Message-----
> >> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >> > bounces@arago-project.org] On Behalf Of Maupin, Chase
> >> > Sent: Friday, September 20, 2013 3:31 PM
> >> > To: Denys Dmytriyenko
> >> > Cc: meta-arago@arago-project.org
> >> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not
> >dereference symlinks
> >> > when packaging data to avoid breakage
> >> >
> >> > Will this still package things like the patches applied on top
> >of the kernel in the
> >> > kernel sources?
> >>
> >> [Franklin] Good call. Your right it doesn't. I gave it a shot
> >and the
> >> symbolic link remains but of course the link is broken if it is
> >used on a
> >> different machine.
> >
> >Yeah, I had the same question originally. Unfortunately, you
> >cannot assume
> >there are no broken links in the sources to begin with. And those
> >broken
> >symlinks cannot be dereferenced w/o breaking the entire tar
> >command and hence
> >the build. That is what we discussed couple days ago - kernel now
> >has a broken
> >symlink that kills our sourceipk...
> >
> >Why do patches symlinked and not copied? Can we fix that step
> >instead of doing
> >it in tar command?
> 
> For most builds I think the idea is not to have multiple copies of the 
> patches.  But we wanted to provide those patches in the sources we ship.  
> That was why the symlink we dereferenced to provide the real file and not a 
> pointer to the patch.  So I'm not sure that it is a good idea to always copy 
> patches instead of symlink as most people probably won't care.

This paragraph is somewhat confusing. It sounds like the patch handling is 
done by sourceipk class, which is not.

Anyway, the ${S}/patches/ directory gets created and patches are symlinked 
there by the core framework to make quilt happy. Unfortunately, there are no 
flags or variables to copy patches instead of symlinking them, or affect that 
code in other way. So, sourceipk class just piggy-backs on the above code to 
prep quilt series.

> Is there a way to bypass the error?  Maybe something like 
> --ignore-command-error?  I'm not sure what changed that created this issue 
> so I'm not sure if this applies.

Unfortunately, no, that flag doesn't help. What changed is that kernel sources 
now contain a symlink that is currently broken. But I'm arguing that it's not 
kernel's fault, as having symlinks pointing nowhere in package sources should 
be allowed. In other words, symlinks in patches/ directory is a special case 
and handling them by dereferencing should not extend on the rest of the 
sources.

So, I'm thinking on possible ways to solve this - either patch the framework 
to copy patches instead of symlinking them or prep the patches/ directory 
before tarring up the sources for the sourceipk case...

-- 
Denys


> >> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko"
> ><denis@denix.org> wrote:
> >> >
> >> > > From: Denys Dmytriyenko <denys@ti.com>
> >> > >
> >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >> > > ---
> >> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +-
> >> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> > >
> >> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass
> >b/meta-arago-
> >> > distro/classes/sourceipk.bbclass
> >> > > index 1ea0577..777cb4f 100644
> >> > > --- a/meta-arago-distro/classes/sourceipk.bbclass
> >> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass
> >> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() {
> >> > >         fi
> >> > >
> >> > >         #Write the data tarball
> >> > > -        tar -C $tmp_dir --owner=0 --group=0 -chzf
> >$srcipk_dir/data.tar.gz .
> >> > > +        tar -C $tmp_dir --owner=0 --group=0 -czf
> >$srcipk_dir/data.tar.gz .
> >> > >
> >> > >         # Create the debian-binary file
> >> > >         echo "2.0" > $srcipk_dir/debian-binary
> >> > > --
> >> > > 1.8.3.2
> >> > >
> >> > > _______________________________________________
> >> > > meta-arago mailing list
> >> > > meta-arago@arago-project.org
> >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >> > _______________________________________________
> >> > meta-arago mailing list
> >> > meta-arago@arago-project.org
> >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago