* [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage
@ 2013-09-20 18:59 Denys Dmytriyenko
2013-09-20 19:28 ` Cooper Jr., Franklin
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Denys Dmytriyenko @ 2013-09-20 18:59 UTC (permalink / raw)
To: meta-arago
From: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
meta-arago-distro/classes/sourceipk.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass
index 1ea0577..777cb4f 100644
--- a/meta-arago-distro/classes/sourceipk.bbclass
+++ b/meta-arago-distro/classes/sourceipk.bbclass
@@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() {
fi
#Write the data tarball
- tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz .
+ tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz .
# Create the debian-binary file
echo "2.0" > $srcipk_dir/debian-binary
--
1.8.3.2
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 18:59 [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage Denys Dmytriyenko @ 2013-09-20 19:28 ` Cooper Jr., Franklin 2013-09-20 19:31 ` Denys Dmytriyenko 2013-09-20 19:40 ` Cooper Jr., Franklin 2013-09-20 20:31 ` Maupin, Chase 2 siblings, 1 reply; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-09-20 19:28 UTC (permalink / raw) To: Denys Dmytriyenko, meta-arago@arago-project.org Tested and it worked for me. > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko > Sent: Friday, September 20, 2013 2:00 PM > To: meta-arago@arago-project.org > Subject: [meta-arago] [PATCH] sourceipk: do not dereference symlinks when > packaging data to avoid breakage > > From: Denys Dmytriyenko <denys@ti.com> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > --- > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > distro/classes/sourceipk.bbclass > index 1ea0577..777cb4f 100644 > --- a/meta-arago-distro/classes/sourceipk.bbclass > +++ b/meta-arago-distro/classes/sourceipk.bbclass > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > fi > > #Write the data tarball > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > # Create the debian-binary file > echo "2.0" > $srcipk_dir/debian-binary > -- > 1.8.3.2 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 19:28 ` Cooper Jr., Franklin @ 2013-09-20 19:31 ` Denys Dmytriyenko 0 siblings, 0 replies; 13+ messages in thread From: Denys Dmytriyenko @ 2013-09-20 19:31 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Fri, Sep 20, 2013 at 07:28:22PM +0000, Cooper Jr., Franklin wrote: > Tested and it worked for me. Thanks! Tested-by: line would have been nice though :) > > -----Original Message----- > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko > > Sent: Friday, September 20, 2013 2:00 PM > > To: meta-arago@arago-project.org > > Subject: [meta-arago] [PATCH] sourceipk: do not dereference symlinks when > > packaging data to avoid breakage > > > > From: Denys Dmytriyenko <denys@ti.com> > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > --- > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > > distro/classes/sourceipk.bbclass > > index 1ea0577..777cb4f 100644 > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > fi > > > > #Write the data tarball > > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > > > # Create the debian-binary file > > echo "2.0" > $srcipk_dir/debian-binary > > -- > > 1.8.3.2 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 18:59 [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage Denys Dmytriyenko 2013-09-20 19:28 ` Cooper Jr., Franklin @ 2013-09-20 19:40 ` Cooper Jr., Franklin 2013-09-20 20:31 ` Maupin, Chase 2 siblings, 0 replies; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-09-20 19:40 UTC (permalink / raw) To: Denys Dmytriyenko, meta-arago@arago-project.org Tested-by: Franklin Cooper Jr. <fcooper@ti.com> > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Denys Dmytriyenko > Sent: Friday, September 20, 2013 2:00 PM > To: meta-arago@arago-project.org > Subject: [meta-arago] [PATCH] sourceipk: do not dereference symlinks when > packaging data to avoid breakage > > From: Denys Dmytriyenko <denys@ti.com> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > --- > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > distro/classes/sourceipk.bbclass > index 1ea0577..777cb4f 100644 > --- a/meta-arago-distro/classes/sourceipk.bbclass > +++ b/meta-arago-distro/classes/sourceipk.bbclass > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > fi > > #Write the data tarball > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > # Create the debian-binary file > echo "2.0" > $srcipk_dir/debian-binary > -- > 1.8.3.2 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 18:59 [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage Denys Dmytriyenko 2013-09-20 19:28 ` Cooper Jr., Franklin 2013-09-20 19:40 ` Cooper Jr., Franklin @ 2013-09-20 20:31 ` Maupin, Chase 2013-09-20 20:49 ` Cooper Jr., Franklin 2 siblings, 1 reply; 13+ messages in thread From: Maupin, Chase @ 2013-09-20 20:31 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-arago@arago-project.org Will this still package things like the patches applied on top of the kernel in the kernel sources? On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" <denis@denix.org> wrote: > From: Denys Dmytriyenko <denys@ti.com> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > --- > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago-distro/classes/sourceipk.bbclass > index 1ea0577..777cb4f 100644 > --- a/meta-arago-distro/classes/sourceipk.bbclass > +++ b/meta-arago-distro/classes/sourceipk.bbclass > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > fi > > #Write the data tarball > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > # Create the debian-binary file > echo "2.0" > $srcipk_dir/debian-binary > -- > 1.8.3.2 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 20:31 ` Maupin, Chase @ 2013-09-20 20:49 ` Cooper Jr., Franklin 2013-09-20 20:53 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-09-20 20:49 UTC (permalink / raw) To: Maupin, Chase, Denys Dmytriyenko; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > bounces@arago-project.org] On Behalf Of Maupin, Chase > Sent: Friday, September 20, 2013 3:31 PM > To: Denys Dmytriyenko > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > when packaging data to avoid breakage > > Will this still package things like the patches applied on top of the kernel in the > kernel sources? [Franklin] Good call. Your right it doesn't. I gave it a shot and the symbolic link remains but of course the link is broken if it is used on a different machine. > > Sent from my iPhone > > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" <denis@denix.org> wrote: > > > From: Denys Dmytriyenko <denys@ti.com> > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > --- > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > distro/classes/sourceipk.bbclass > > index 1ea0577..777cb4f 100644 > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > fi > > > > #Write the data tarball > > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > > > # Create the debian-binary file > > echo "2.0" > $srcipk_dir/debian-binary > > -- > > 1.8.3.2 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 20:49 ` Cooper Jr., Franklin @ 2013-09-20 20:53 ` Denys Dmytriyenko 2013-09-23 15:34 ` Maupin, Chase 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-09-20 20:53 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > bounces@arago-project.org] On Behalf Of Maupin, Chase > > Sent: Friday, September 20, 2013 3:31 PM > > To: Denys Dmytriyenko > > Cc: meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > > when packaging data to avoid breakage > > > > Will this still package things like the patches applied on top of the kernel in the > > kernel sources? > > [Franklin] Good call. Your right it doesn't. I gave it a shot and the > symbolic link remains but of course the link is broken if it is used on a > different machine. Yeah, I had the same question originally. Unfortunately, you cannot assume there are no broken links in the sources to begin with. And those broken symlinks cannot be dereferenced w/o breaking the entire tar command and hence the build. That is what we discussed couple days ago - kernel now has a broken symlink that kills our sourceipk... Why do patches symlinked and not copied? Can we fix that step instead of doing it in tar command? -- Denys > > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" <denis@denix.org> wrote: > > > > > From: Denys Dmytriyenko <denys@ti.com> > > > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > > --- > > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass b/meta-arago- > > distro/classes/sourceipk.bbclass > > > index 1ea0577..777cb4f 100644 > > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > > fi > > > > > > #Write the data tarball > > > - tar -C $tmp_dir --owner=0 --group=0 -chzf $srcipk_dir/data.tar.gz . > > > + tar -C $tmp_dir --owner=0 --group=0 -czf $srcipk_dir/data.tar.gz . > > > > > > # Create the debian-binary file > > > echo "2.0" > $srcipk_dir/debian-binary > > > -- > > > 1.8.3.2 > > > > > > _______________________________________________ > > > meta-arago mailing list > > > meta-arago@arago-project.org > > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-20 20:53 ` Denys Dmytriyenko @ 2013-09-23 15:34 ` Maupin, Chase 2013-09-23 17:55 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Maupin, Chase @ 2013-09-23 15:34 UTC (permalink / raw) To: Dmytriyenko, Denys, Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org >-----Original Message----- >From: Dmytriyenko, Denys >Sent: Friday, September 20, 2013 4:53 PM >To: Cooper Jr., Franklin >Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org >Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference >symlinks when packaging data to avoid breakage > >On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin >wrote: >> >> >> > -----Original Message----- >> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >> > bounces@arago-project.org] On Behalf Of Maupin, Chase >> > Sent: Friday, September 20, 2013 3:31 PM >> > To: Denys Dmytriyenko >> > Cc: meta-arago@arago-project.org >> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not >dereference symlinks >> > when packaging data to avoid breakage >> > >> > Will this still package things like the patches applied on top >of the kernel in the >> > kernel sources? >> >> [Franklin] Good call. Your right it doesn't. I gave it a shot >and the >> symbolic link remains but of course the link is broken if it is >used on a >> different machine. > >Yeah, I had the same question originally. Unfortunately, you >cannot assume >there are no broken links in the sources to begin with. And those >broken >symlinks cannot be dereferenced w/o breaking the entire tar >command and hence >the build. That is what we discussed couple days ago - kernel now >has a broken >symlink that kills our sourceipk... > >Why do patches symlinked and not copied? Can we fix that step >instead of doing >it in tar command? For most builds I think the idea is not to have multiple copies of the patches. But we wanted to provide those patches in the sources we ship. That was why the symlink we dereferenced to provide the real file and not a pointer to the patch. So I'm not sure that it is a good idea to always copy patches instead of symlink as most people probably won't care. Is there a way to bypass the error? Maybe something like --ignore-command-error? I'm not sure what changed that created this issue so I'm not sure if this applies. > >-- >Denys > > >> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" ><denis@denix.org> wrote: >> > >> > > From: Denys Dmytriyenko <denys@ti.com> >> > > >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> >> > > --- >> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > > >> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass >b/meta-arago- >> > distro/classes/sourceipk.bbclass >> > > index 1ea0577..777cb4f 100644 >> > > --- a/meta-arago-distro/classes/sourceipk.bbclass >> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass >> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { >> > > fi >> > > >> > > #Write the data tarball >> > > - tar -C $tmp_dir --owner=0 --group=0 -chzf >$srcipk_dir/data.tar.gz . >> > > + tar -C $tmp_dir --owner=0 --group=0 -czf >$srcipk_dir/data.tar.gz . >> > > >> > > # Create the debian-binary file >> > > echo "2.0" > $srcipk_dir/debian-binary >> > > -- >> > > 1.8.3.2 >> > > >> > > _______________________________________________ >> > > meta-arago mailing list >> > > meta-arago@arago-project.org >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >> > _______________________________________________ >> > meta-arago mailing list >> > meta-arago@arago-project.org >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >> _______________________________________________ >> meta-arago mailing list >> meta-arago@arago-project.org >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-23 15:34 ` Maupin, Chase @ 2013-09-23 17:55 ` Denys Dmytriyenko 2013-09-23 20:12 ` Cooper Jr., Franklin 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-09-23 17:55 UTC (permalink / raw) To: Maupin, Chase; +Cc: meta-arago@arago-project.org, Cooper Jr., Franklin On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote: > >-----Original Message----- > >From: Dmytriyenko, Denys > >Sent: Friday, September 20, 2013 4:53 PM > >To: Cooper Jr., Franklin > >Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org > >Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference > >symlinks when packaging data to avoid breakage > > > >On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin > >wrote: > >> > >> > >> > -----Original Message----- > >> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >> > bounces@arago-project.org] On Behalf Of Maupin, Chase > >> > Sent: Friday, September 20, 2013 3:31 PM > >> > To: Denys Dmytriyenko > >> > Cc: meta-arago@arago-project.org > >> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not > >dereference symlinks > >> > when packaging data to avoid breakage > >> > > >> > Will this still package things like the patches applied on top > >of the kernel in the > >> > kernel sources? > >> > >> [Franklin] Good call. Your right it doesn't. I gave it a shot > >and the > >> symbolic link remains but of course the link is broken if it is > >used on a > >> different machine. > > > >Yeah, I had the same question originally. Unfortunately, you > >cannot assume > >there are no broken links in the sources to begin with. And those > >broken > >symlinks cannot be dereferenced w/o breaking the entire tar > >command and hence > >the build. That is what we discussed couple days ago - kernel now > >has a broken > >symlink that kills our sourceipk... > > > >Why do patches symlinked and not copied? Can we fix that step > >instead of doing > >it in tar command? > > For most builds I think the idea is not to have multiple copies of the > patches. But we wanted to provide those patches in the sources we ship. > That was why the symlink we dereferenced to provide the real file and not a > pointer to the patch. So I'm not sure that it is a good idea to always copy > patches instead of symlink as most people probably won't care. This paragraph is somewhat confusing. It sounds like the patch handling is done by sourceipk class, which is not. Anyway, the ${S}/patches/ directory gets created and patches are symlinked there by the core framework to make quilt happy. Unfortunately, there are no flags or variables to copy patches instead of symlinking them, or affect that code in other way. So, sourceipk class just piggy-backs on the above code to prep quilt series. > Is there a way to bypass the error? Maybe something like > --ignore-command-error? I'm not sure what changed that created this issue > so I'm not sure if this applies. Unfortunately, no, that flag doesn't help. What changed is that kernel sources now contain a symlink that is currently broken. But I'm arguing that it's not kernel's fault, as having symlinks pointing nowhere in package sources should be allowed. In other words, symlinks in patches/ directory is a special case and handling them by dereferencing should not extend on the rest of the sources. So, I'm thinking on possible ways to solve this - either patch the framework to copy patches instead of symlinking them or prep the patches/ directory before tarring up the sources for the sourceipk case... -- Denys > >> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" > ><denis@denix.org> wrote: > >> > > >> > > From: Denys Dmytriyenko <denys@ti.com> > >> > > > >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > >> > > --- > >> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > >> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass > >b/meta-arago- > >> > distro/classes/sourceipk.bbclass > >> > > index 1ea0577..777cb4f 100644 > >> > > --- a/meta-arago-distro/classes/sourceipk.bbclass > >> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > >> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > >> > > fi > >> > > > >> > > #Write the data tarball > >> > > - tar -C $tmp_dir --owner=0 --group=0 -chzf > >$srcipk_dir/data.tar.gz . > >> > > + tar -C $tmp_dir --owner=0 --group=0 -czf > >$srcipk_dir/data.tar.gz . > >> > > > >> > > # Create the debian-binary file > >> > > echo "2.0" > $srcipk_dir/debian-binary > >> > > -- > >> > > 1.8.3.2 > >> > > > >> > > _______________________________________________ > >> > > meta-arago mailing list > >> > > meta-arago@arago-project.org > >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > >> > _______________________________________________ > >> > meta-arago mailing list > >> > meta-arago@arago-project.org > >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > >> _______________________________________________ > >> meta-arago mailing list > >> meta-arago@arago-project.org > >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-23 17:55 ` Denys Dmytriyenko @ 2013-09-23 20:12 ` Cooper Jr., Franklin 2013-09-23 21:37 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-09-23 20:12 UTC (permalink / raw) To: Dmytriyenko, Denys, Maupin, Chase; +Cc: meta-arago@arago-project.org > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Monday, September 23, 2013 12:56 PM > To: Maupin, Chase > Cc: Cooper Jr., Franklin; meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > when packaging data to avoid breakage > > On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote: > > >-----Original Message----- > > >From: Dmytriyenko, Denys > > >Sent: Friday, September 20, 2013 4:53 PM > > >To: Cooper Jr., Franklin > > >Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org > > >Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference > > >symlinks when packaging data to avoid breakage > > > > > >On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin > > >wrote: > > >> > > >> > > >> > -----Original Message----- > > >> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > >> > bounces@arago-project.org] On Behalf Of Maupin, Chase > > >> > Sent: Friday, September 20, 2013 3:31 PM > > >> > To: Denys Dmytriyenko > > >> > Cc: meta-arago@arago-project.org > > >> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not > > >dereference symlinks > > >> > when packaging data to avoid breakage > > >> > > > >> > Will this still package things like the patches applied on top > > >of the kernel in the > > >> > kernel sources? > > >> > > >> [Franklin] Good call. Your right it doesn't. I gave it a shot > > >and the > > >> symbolic link remains but of course the link is broken if it is > > >used on a > > >> different machine. > > > > > >Yeah, I had the same question originally. Unfortunately, you cannot > > >assume there are no broken links in the sources to begin with. And > > >those broken symlinks cannot be dereferenced w/o breaking the entire > > >tar command and hence the build. That is what we discussed couple > > >days ago - kernel now has a broken symlink that kills our > > >sourceipk... > > > > > >Why do patches symlinked and not copied? Can we fix that step instead > > >of doing it in tar command? > > > > For most builds I think the idea is not to have multiple copies of the > > patches. But we wanted to provide those patches in the sources we ship. > > That was why the symlink we dereferenced to provide the real file and > > not a pointer to the patch. So I'm not sure that it is a good idea to > > always copy patches instead of symlink as most people probably won't care. > > This paragraph is somewhat confusing. It sounds like the patch handling is done > by sourceipk class, which is not. > > Anyway, the ${S}/patches/ directory gets created and patches are symlinked > there by the core framework to make quilt happy. Unfortunately, there are no > flags or variables to copy patches instead of symlinking them, or affect that code > in other way. So, sourceipk class just piggy-backs on the above code to prep > quilt series. > > > Is there a way to bypass the error? Maybe something like > > --ignore-command-error? I'm not sure what changed that created this > > issue so I'm not sure if this applies. > > Unfortunately, no, that flag doesn't help. What changed is that kernel sources > now contain a symlink that is currently broken. But I'm arguing that it's not > kernel's fault, as having symlinks pointing nowhere in package sources should be > allowed. In other words, symlinks in patches/ directory is a special case and > handling them by dereferencing should not extend on the rest of the sources. > > So, I'm thinking on possible ways to solve this - either patch the framework to > copy patches instead of symlinking them or prep the patches/ directory before > tarring up the sources for the sourceipk case... [Franklin] I didn't notice before but sourceipk copies the sources in a completely different directory before the tar command is ran. So how about simply searching for broken symlink and then deleting them. Afterwards the tar command can run as is. > > -- > Denys > > > > >> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" > > ><denis@denix.org> wrote: > > >> > > > >> > > From: Denys Dmytriyenko <denys@ti.com> > > >> > > > > >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > >> > > --- > > >> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > > > >> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass > > >b/meta-arago- > > >> > distro/classes/sourceipk.bbclass > > >> > > index 1ea0577..777cb4f 100644 > > >> > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > >> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > >> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > >> > > fi > > >> > > > > >> > > #Write the data tarball > > >> > > - tar -C $tmp_dir --owner=0 --group=0 -chzf > > >$srcipk_dir/data.tar.gz . > > >> > > + tar -C $tmp_dir --owner=0 --group=0 -czf > > >$srcipk_dir/data.tar.gz . > > >> > > > > >> > > # Create the debian-binary file > > >> > > echo "2.0" > $srcipk_dir/debian-binary > > >> > > -- > > >> > > 1.8.3.2 > > >> > > > > >> > > _______________________________________________ > > >> > > meta-arago mailing list > > >> > > meta-arago@arago-project.org > > >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > >> > _______________________________________________ > > >> > meta-arago mailing list > > >> > meta-arago@arago-project.org > > >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > >> _______________________________________________ > > >> meta-arago mailing list > > >> meta-arago@arago-project.org > > >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-23 20:12 ` Cooper Jr., Franklin @ 2013-09-23 21:37 ` Denys Dmytriyenko 2013-09-23 22:09 ` Cooper Jr., Franklin 0 siblings, 1 reply; 13+ messages in thread From: Denys Dmytriyenko @ 2013-09-23 21:37 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Mon, Sep 23, 2013 at 04:12:37PM -0400, Cooper Jr., Franklin wrote: > > > > -----Original Message----- > > From: Dmytriyenko, Denys > > Sent: Monday, September 23, 2013 12:56 PM > > To: Maupin, Chase > > Cc: Cooper Jr., Franklin; meta-arago@arago-project.org > > Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > > when packaging data to avoid breakage > > > > On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote: > > > >-----Original Message----- > > > >From: Dmytriyenko, Denys > > > >Sent: Friday, September 20, 2013 4:53 PM > > > >To: Cooper Jr., Franklin > > > >Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org > > > >Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference > > > >symlinks when packaging data to avoid breakage > > > > > > > >On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin > > > >wrote: > > > >> > > > >> > > > >> > -----Original Message----- > > > >> > From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > > > >> > bounces@arago-project.org] On Behalf Of Maupin, Chase > > > >> > Sent: Friday, September 20, 2013 3:31 PM > > > >> > To: Denys Dmytriyenko > > > >> > Cc: meta-arago@arago-project.org > > > >> > Subject: Re: [meta-arago] [PATCH] sourceipk: do not > > > >dereference symlinks > > > >> > when packaging data to avoid breakage > > > >> > > > > >> > Will this still package things like the patches applied on top > > > >of the kernel in the > > > >> > kernel sources? > > > >> > > > >> [Franklin] Good call. Your right it doesn't. I gave it a shot > > > >and the > > > >> symbolic link remains but of course the link is broken if it is > > > >used on a > > > >> different machine. > > > > > > > >Yeah, I had the same question originally. Unfortunately, you cannot > > > >assume there are no broken links in the sources to begin with. And > > > >those broken symlinks cannot be dereferenced w/o breaking the entire > > > >tar command and hence the build. That is what we discussed couple > > > >days ago - kernel now has a broken symlink that kills our > > > >sourceipk... > > > > > > > >Why do patches symlinked and not copied? Can we fix that step instead > > > >of doing it in tar command? > > > > > > For most builds I think the idea is not to have multiple copies of the > > > patches. But we wanted to provide those patches in the sources we ship. > > > That was why the symlink we dereferenced to provide the real file and > > > not a pointer to the patch. So I'm not sure that it is a good idea to > > > always copy patches instead of symlink as most people probably won't care. > > > > This paragraph is somewhat confusing. It sounds like the patch handling is done > > by sourceipk class, which is not. > > > > Anyway, the ${S}/patches/ directory gets created and patches are symlinked > > there by the core framework to make quilt happy. Unfortunately, there are no > > flags or variables to copy patches instead of symlinking them, or affect that code > > in other way. So, sourceipk class just piggy-backs on the above code to prep > > quilt series. > > > > > Is there a way to bypass the error? Maybe something like > > > --ignore-command-error? I'm not sure what changed that created this > > > issue so I'm not sure if this applies. > > > > Unfortunately, no, that flag doesn't help. What changed is that kernel sources > > now contain a symlink that is currently broken. But I'm arguing that it's not > > kernel's fault, as having symlinks pointing nowhere in package sources should be > > allowed. In other words, symlinks in patches/ directory is a special case and > > handling them by dereferencing should not extend on the rest of the sources. > > > > So, I'm thinking on possible ways to solve this - either patch the framework to > > copy patches instead of symlinking them or prep the patches/ directory before > > tarring up the sources for the sourceipk case... > [Franklin] I didn't notice before but sourceipk copies the sources in a > completely different directory before the tar command is ran. So how about > simply searching for broken symlink and then deleting them. Afterwards the > tar command can run as is. You are missing the point - it _may_ be valid to have broken symlinks in the source tree. We should not fail while packaging those and we should not deliberately remove them. -- Denys > > > >> > On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" > > > ><denis@denix.org> wrote: > > > >> > > > > >> > > From: Denys Dmytriyenko <denys@ti.com> > > > >> > > > > > >> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com> > > > >> > > --- > > > >> > > meta-arago-distro/classes/sourceipk.bbclass | 2 +- > > > >> > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >> > > > > > >> > > diff --git a/meta-arago-distro/classes/sourceipk.bbclass > > > >b/meta-arago- > > > >> > distro/classes/sourceipk.bbclass > > > >> > > index 1ea0577..777cb4f 100644 > > > >> > > --- a/meta-arago-distro/classes/sourceipk.bbclass > > > >> > > +++ b/meta-arago-distro/classes/sourceipk.bbclass > > > >> > > @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > > > >> > > fi > > > >> > > > > > >> > > #Write the data tarball > > > >> > > - tar -C $tmp_dir --owner=0 --group=0 -chzf > > > >$srcipk_dir/data.tar.gz . > > > >> > > + tar -C $tmp_dir --owner=0 --group=0 -czf > > > >$srcipk_dir/data.tar.gz . > > > >> > > > > > >> > > # Create the debian-binary file > > > >> > > echo "2.0" > $srcipk_dir/debian-binary > > > >> > > -- > > > >> > > 1.8.3.2 > > > >> > > > > > >> > > _______________________________________________ > > > >> > > meta-arago mailing list > > > >> > > meta-arago@arago-project.org > > > >> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > > >> > _______________________________________________ > > > >> > meta-arago mailing list > > > >> > meta-arago@arago-project.org > > > >> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > > > >> _______________________________________________ > > > >> meta-arago mailing list > > > >> meta-arago@arago-project.org > > > >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-23 21:37 ` Denys Dmytriyenko @ 2013-09-23 22:09 ` Cooper Jr., Franklin 2013-09-24 0:44 ` Denys Dmytriyenko 0 siblings, 1 reply; 13+ messages in thread From: Cooper Jr., Franklin @ 2013-09-23 22:09 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org > On Sep 23, 2013, at 4:37 PM, "Dmytriyenko, Denys" <denys@ti.com> wrote: > >> On Mon, Sep 23, 2013 at 04:12:37PM -0400, Cooper Jr., Franklin wrote: >> >> >>> -----Original Message----- >>> From: Dmytriyenko, Denys >>> Sent: Monday, September 23, 2013 12:56 PM >>> To: Maupin, Chase >>> Cc: Cooper Jr., Franklin; meta-arago@arago-project.org >>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks >>> when packaging data to avoid breakage >>> >>> On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote: >>>>> -----Original Message----- >>>>> From: Dmytriyenko, Denys >>>>> Sent: Friday, September 20, 2013 4:53 PM >>>>> To: Cooper Jr., Franklin >>>>> Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org >>>>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference >>>>> symlinks when packaging data to avoid breakage >>>>> >>>>> On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin >>>>> wrote: >>>>>> >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago- >>>>>>> bounces@arago-project.org] On Behalf Of Maupin, Chase >>>>>>> Sent: Friday, September 20, 2013 3:31 PM >>>>>>> To: Denys Dmytriyenko >>>>>>> Cc: meta-arago@arago-project.org >>>>>>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not >>>>> dereference symlinks >>>>>>> when packaging data to avoid breakage >>>>>>> >>>>>>> Will this still package things like the patches applied on top >>>>> of the kernel in the >>>>>>> kernel sources? >>>>>> >>>>>> [Franklin] Good call. Your right it doesn't. I gave it a shot >>>>> and the >>>>>> symbolic link remains but of course the link is broken if it is >>>>> used on a >>>>>> different machine. >>>>> >>>>> Yeah, I had the same question originally. Unfortunately, you cannot >>>>> assume there are no broken links in the sources to begin with. And >>>>> those broken symlinks cannot be dereferenced w/o breaking the entire >>>>> tar command and hence the build. That is what we discussed couple >>>>> days ago - kernel now has a broken symlink that kills our >>>>> sourceipk... >>>>> >>>>> Why do patches symlinked and not copied? Can we fix that step instead >>>>> of doing it in tar command? >>>> >>>> For most builds I think the idea is not to have multiple copies of the >>>> patches. But we wanted to provide those patches in the sources we ship. >>>> That was why the symlink we dereferenced to provide the real file and >>>> not a pointer to the patch. So I'm not sure that it is a good idea to >>>> always copy patches instead of symlink as most people probably won't care. >>> >>> This paragraph is somewhat confusing. It sounds like the patch handling is done >>> by sourceipk class, which is not. >>> >>> Anyway, the ${S}/patches/ directory gets created and patches are symlinked >>> there by the core framework to make quilt happy. Unfortunately, there are no >>> flags or variables to copy patches instead of symlinking them, or affect that code >>> in other way. So, sourceipk class just piggy-backs on the above code to prep >>> quilt series. >>> >>>> Is there a way to bypass the error? Maybe something like >>>> --ignore-command-error? I'm not sure what changed that created this >>>> issue so I'm not sure if this applies. >>> >>> Unfortunately, no, that flag doesn't help. What changed is that kernel sources >>> now contain a symlink that is currently broken. But I'm arguing that it's not >>> kernel's fault, as having symlinks pointing nowhere in package sources should be >>> allowed. In other words, symlinks in patches/ directory is a special case and >>> handling them by dereferencing should not extend on the rest of the sources. >>> >>> So, I'm thinking on possible ways to solve this - either patch the framework to >>> copy patches instead of symlinking them or prep the patches/ directory before >>> tarring up the sources for the sourceipk case... > >> [Franklin] I didn't notice before but sourceipk copies the sources in a >> completely different directory before the tar command is ran. So how about >> simply searching for broken symlink and then deleting them. Afterwards the >> tar command can run as is. > > You are missing the point - it _may_ be valid to have broken symlinks in the > source tree. We should not fail while packaging those and we should not > deliberately remove them I'll take your word for it then since I don't understand why anyone would want to do that. I think prepping the patches directory would be the best solution. > > -- > Denys > > >>>>>>> On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" >>>>> <denis@denix.org> wrote: >>>>>>> >>>>>>>> From: Denys Dmytriyenko <denys@ti.com> >>>>>>>> >>>>>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com> >>>>>>>> --- >>>>>>>> meta-arago-distro/classes/sourceipk.bbclass | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/meta-arago-distro/classes/sourceipk.bbclass >>>>> b/meta-arago- >>>>>>> distro/classes/sourceipk.bbclass >>>>>>>> index 1ea0577..777cb4f 100644 >>>>>>>> --- a/meta-arago-distro/classes/sourceipk.bbclass >>>>>>>> +++ b/meta-arago-distro/classes/sourceipk.bbclass >>>>>>>> @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { >>>>>>>> fi >>>>>>>> >>>>>>>> #Write the data tarball >>>>>>>> - tar -C $tmp_dir --owner=0 --group=0 -chzf >>>>> $srcipk_dir/data.tar.gz . >>>>>>>> + tar -C $tmp_dir --owner=0 --group=0 -czf >>>>> $srcipk_dir/data.tar.gz . >>>>>>>> >>>>>>>> # Create the debian-binary file >>>>>>>> echo "2.0" > $srcipk_dir/debian-binary >>>>>>>> -- >>>>>>>> 1.8.3.2 >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> meta-arago mailing list >>>>>>>> meta-arago@arago-project.org >>>>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >>>>>>> _______________________________________________ >>>>>>> meta-arago mailing list >>>>>>> meta-arago@arago-project.org >>>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago >>>>>> _______________________________________________ >>>>>> meta-arago mailing list >>>>>> meta-arago@arago-project.org >>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage 2013-09-23 22:09 ` Cooper Jr., Franklin @ 2013-09-24 0:44 ` Denys Dmytriyenko 0 siblings, 0 replies; 13+ messages in thread From: Denys Dmytriyenko @ 2013-09-24 0:44 UTC (permalink / raw) To: Cooper Jr., Franklin; +Cc: meta-arago@arago-project.org On Mon, Sep 23, 2013 at 06:09:02PM -0400, Cooper Jr., Franklin wrote: > > > > On Sep 23, 2013, at 4:37 PM, "Dmytriyenko, Denys" <denys@ti.com> wrote: > > > >> On Mon, Sep 23, 2013 at 04:12:37PM -0400, Cooper Jr., Franklin wrote: > >> > >> > >>> -----Original Message----- > >>> From: Dmytriyenko, Denys > >>> Sent: Monday, September 23, 2013 12:56 PM > >>> To: Maupin, Chase > >>> Cc: Cooper Jr., Franklin; meta-arago@arago-project.org > >>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference symlinks > >>> when packaging data to avoid breakage > >>> > >>> On Mon, Sep 23, 2013 at 11:34:46AM -0400, Maupin, Chase wrote: > >>>>> -----Original Message----- > >>>>> From: Dmytriyenko, Denys > >>>>> Sent: Friday, September 20, 2013 4:53 PM > >>>>> To: Cooper Jr., Franklin > >>>>> Cc: Maupin, Chase; Denys Dmytriyenko; meta-arago@arago-project.org > >>>>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not dereference > >>>>> symlinks when packaging data to avoid breakage > >>>>> > >>>>> On Fri, Sep 20, 2013 at 08:49:00PM +0000, Cooper Jr., Franklin > >>>>> wrote: > >>>>>> > >>>>>> > >>>>>>> -----Original Message----- > >>>>>>> From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >>>>>>> bounces@arago-project.org] On Behalf Of Maupin, Chase > >>>>>>> Sent: Friday, September 20, 2013 3:31 PM > >>>>>>> To: Denys Dmytriyenko > >>>>>>> Cc: meta-arago@arago-project.org > >>>>>>> Subject: Re: [meta-arago] [PATCH] sourceipk: do not > >>>>> dereference symlinks > >>>>>>> when packaging data to avoid breakage > >>>>>>> > >>>>>>> Will this still package things like the patches applied on top > >>>>> of the kernel in the > >>>>>>> kernel sources? > >>>>>> > >>>>>> [Franklin] Good call. Your right it doesn't. I gave it a shot > >>>>> and the > >>>>>> symbolic link remains but of course the link is broken if it is > >>>>> used on a > >>>>>> different machine. > >>>>> > >>>>> Yeah, I had the same question originally. Unfortunately, you cannot > >>>>> assume there are no broken links in the sources to begin with. And > >>>>> those broken symlinks cannot be dereferenced w/o breaking the entire > >>>>> tar command and hence the build. That is what we discussed couple > >>>>> days ago - kernel now has a broken symlink that kills our > >>>>> sourceipk... > >>>>> > >>>>> Why do patches symlinked and not copied? Can we fix that step instead > >>>>> of doing it in tar command? > >>>> > >>>> For most builds I think the idea is not to have multiple copies of the > >>>> patches. But we wanted to provide those patches in the sources we ship. > >>>> That was why the symlink we dereferenced to provide the real file and > >>>> not a pointer to the patch. So I'm not sure that it is a good idea to > >>>> always copy patches instead of symlink as most people probably won't care. > >>> > >>> This paragraph is somewhat confusing. It sounds like the patch handling is done > >>> by sourceipk class, which is not. > >>> > >>> Anyway, the ${S}/patches/ directory gets created and patches are symlinked > >>> there by the core framework to make quilt happy. Unfortunately, there are no > >>> flags or variables to copy patches instead of symlinking them, or affect that code > >>> in other way. So, sourceipk class just piggy-backs on the above code to prep > >>> quilt series. > >>> > >>>> Is there a way to bypass the error? Maybe something like > >>>> --ignore-command-error? I'm not sure what changed that created this > >>>> issue so I'm not sure if this applies. > >>> > >>> Unfortunately, no, that flag doesn't help. What changed is that kernel sources > >>> now contain a symlink that is currently broken. But I'm arguing that it's not > >>> kernel's fault, as having symlinks pointing nowhere in package sources should be > >>> allowed. In other words, symlinks in patches/ directory is a special case and > >>> handling them by dereferencing should not extend on the rest of the sources. > >>> > >>> So, I'm thinking on possible ways to solve this - either patch the framework to > >>> copy patches instead of symlinking them or prep the patches/ directory before > >>> tarring up the sources for the sourceipk case... > > > >> [Franklin] I didn't notice before but sourceipk copies the sources in a > >> completely different directory before the tar command is ran. So how about > >> simply searching for broken symlink and then deleting them. Afterwards the > >> tar command can run as is. > > > > You are missing the point - it _may_ be valid to have broken symlinks in the > > source tree. We should not fail while packaging those and we should not > > deliberately remove them > I'll take your word for it then since I don't understand why anyone would > want to do that. > > I think prepping the patches directory would be the best solution. I'm not saying it is correct or desirable to have a broken symlink in the sources directory. I'm just saying we should not mangle the sources at all - keep them as they are, even if there are broken symlinks in them. Since the patches/ directory is added externally and that's the one we care about, we should dereference just that with inside patches and leave the rest untouched. -- Denys > >>>>>>> On Sep 20, 2013, at 2:00 PM, "Denys Dmytriyenko" > >>>>> <denis@denix.org> wrote: > >>>>>>> > >>>>>>>> From: Denys Dmytriyenko <denys@ti.com> > >>>>>>>> > >>>>>>>> Signed-off-by: Denys Dmytriyenko <denys@ti.com> > >>>>>>>> --- > >>>>>>>> meta-arago-distro/classes/sourceipk.bbclass | 2 +- > >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>>>>>> > >>>>>>>> diff --git a/meta-arago-distro/classes/sourceipk.bbclass > >>>>> b/meta-arago- > >>>>>>> distro/classes/sourceipk.bbclass > >>>>>>>> index 1ea0577..777cb4f 100644 > >>>>>>>> --- a/meta-arago-distro/classes/sourceipk.bbclass > >>>>>>>> +++ b/meta-arago-distro/classes/sourceipk.bbclass > >>>>>>>> @@ -167,7 +167,7 @@ sourceipk_do_create_srcipk() { > >>>>>>>> fi > >>>>>>>> > >>>>>>>> #Write the data tarball > >>>>>>>> - tar -C $tmp_dir --owner=0 --group=0 -chzf > >>>>> $srcipk_dir/data.tar.gz . > >>>>>>>> + tar -C $tmp_dir --owner=0 --group=0 -czf > >>>>> $srcipk_dir/data.tar.gz . > >>>>>>>> > >>>>>>>> # Create the debian-binary file > >>>>>>>> echo "2.0" > $srcipk_dir/debian-binary > >>>>>>>> -- > >>>>>>>> 1.8.3.2 > >>>>>>>> > >>>>>>>> _______________________________________________ > >>>>>>>> meta-arago mailing list > >>>>>>>> meta-arago@arago-project.org > >>>>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > >>>>>>> _______________________________________________ > >>>>>>> meta-arago mailing list > >>>>>>> meta-arago@arago-project.org > >>>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > >>>>>> _______________________________________________ > >>>>>> meta-arago mailing list > >>>>>> meta-arago@arago-project.org > >>>>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-09-24 0:44 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-09-20 18:59 [PATCH] sourceipk: do not dereference symlinks when packaging data to avoid breakage Denys Dmytriyenko 2013-09-20 19:28 ` Cooper Jr., Franklin 2013-09-20 19:31 ` Denys Dmytriyenko 2013-09-20 19:40 ` Cooper Jr., Franklin 2013-09-20 20:31 ` Maupin, Chase 2013-09-20 20:49 ` Cooper Jr., Franklin 2013-09-20 20:53 ` Denys Dmytriyenko 2013-09-23 15:34 ` Maupin, Chase 2013-09-23 17:55 ` Denys Dmytriyenko 2013-09-23 20:12 ` Cooper Jr., Franklin 2013-09-23 21:37 ` Denys Dmytriyenko 2013-09-23 22:09 ` Cooper Jr., Franklin 2013-09-24 0:44 ` Denys Dmytriyenko
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.