From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sonic Zhang <sonic.adi@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
sfr@canb.auug.org.au, LKML <linux-kernel@vger.kernel.org>,
adi-buildroot-devel@lists.sourceforge.net,
Sonic Zhang <sonic.zhang@analog.com>
Subject: Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.
Date: Mon, 23 Sep 2013 10:45:08 +0300 [thread overview]
Message-ID: <20130923074508.GF6247@mwanda> (raw)
In-Reply-To: <1379908620-4036-1-git-send-email-sonic.adi@gmail.com>
The other two Coccinelle warnings were real bugs as well:
drivers/pinctrl/pinctrl-adi2.c:250:1-18: ERROR: nested lock+irqsave that reuses flags from line 249.
The second spinlock_irq_save() should just be a spinlock.
drivers/pinctrl/pinctrl-adi2.c:326:16-19: ERROR: port is NULL but dereferenced.
The error message dereferences a NULL pointer.
regards,
dan carpenter
prev parent reply other threads:[~2013-09-23 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 3:57 [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig Sonic Zhang
2013-09-23 7:43 ` Linus Walleij
2013-09-23 7:45 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923074508.GF6247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=sonic.adi@gmail.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.