* [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.
@ 2013-09-23 3:57 Sonic Zhang
2013-09-23 7:43 ` Linus Walleij
2013-09-23 7:45 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Sonic Zhang @ 2013-09-23 3:57 UTC (permalink / raw)
To: Linus Walleij, dan.carpenter, sfr; +Cc: LKML, adi-buildroot-devel, Sonic Zhang
From: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 08b8337..9bb6efb 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -51,6 +51,7 @@ config PINCTRL_AB8505
config PINCTRL_ADI2
bool "ADI pin controller driver"
+ depends on BLACKFIN
select PINMUX
select IRQ_DOMAIN
help
--
1.8.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.
2013-09-23 3:57 [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig Sonic Zhang
@ 2013-09-23 7:43 ` Linus Walleij
2013-09-23 7:45 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-09-23 7:43 UTC (permalink / raw)
To: Sonic Zhang
Cc: Dan Carpenter, Stephen Rothwell, LKML, adi-buildroot-devel,
Sonic Zhang
On Mon, Sep 23, 2013 at 5:57 AM, Sonic Zhang <sonic.adi@gmail.com> wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Patch applied, will push immediately so linux-next builds.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig.
2013-09-23 3:57 [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig Sonic Zhang
2013-09-23 7:43 ` Linus Walleij
@ 2013-09-23 7:45 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-09-23 7:45 UTC (permalink / raw)
To: Sonic Zhang; +Cc: Linus Walleij, sfr, LKML, adi-buildroot-devel, Sonic Zhang
The other two Coccinelle warnings were real bugs as well:
drivers/pinctrl/pinctrl-adi2.c:250:1-18: ERROR: nested lock+irqsave that reuses flags from line 249.
The second spinlock_irq_save() should just be a spinlock.
drivers/pinctrl/pinctrl-adi2.c:326:16-19: ERROR: port is NULL but dereferenced.
The error message dereferences a NULL pointer.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-23 7:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-23 3:57 [PATCH] pinctrl: pinctrl-adi2: Add dependency to arch BLACKFIN in Kconfig Sonic Zhang
2013-09-23 7:43 ` Linus Walleij
2013-09-23 7:45 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.