From: Liu Bo <bo.li.liu@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstest/btrfs/001: fix the misuse of subvolume set-default
Date: Mon, 23 Sep 2013 22:37:56 +0800 [thread overview]
Message-ID: <20130923143755.GC18072@localhost.localdomain> (raw)
In-Reply-To: <20130923131746.GA18681@localhost.localdomain>
On Mon, Sep 23, 2013 at 09:17:46AM -0400, Josef Bacik wrote:
> On Mon, Sep 23, 2013 at 04:47:29PM +0800, Liu Bo wrote:
> > The command is
> > btrfs subvolume set-default <subvolid> <path>.
> >
> > It uses @subvolid to control the default subvolume and
> > @subvolid=0 has always been parsed into FS_TREE no matter
> > what subvolume @path points to.
> >
> > So in order to set a subvolume to the default one, we need
> > to get the id of this subvolume first.
> >
> > Also fix a typo:
> > s/sbuvolid/subvolid/g
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
>
> Sent a patch for this already. Thanks,
oops, sorry I should have noticed that, any chance to fold the typo fix
into your patch?
-liubo
WARNING: multiple messages have this Message-ID (diff)
From: Liu Bo <bo.li.liu@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstest/btrfs/001: fix the misuse of subvolume set-default
Date: Mon, 23 Sep 2013 22:37:56 +0800 [thread overview]
Message-ID: <20130923143755.GC18072@localhost.localdomain> (raw)
In-Reply-To: <20130923131746.GA18681@localhost.localdomain>
On Mon, Sep 23, 2013 at 09:17:46AM -0400, Josef Bacik wrote:
> On Mon, Sep 23, 2013 at 04:47:29PM +0800, Liu Bo wrote:
> > The command is
> > btrfs subvolume set-default <subvolid> <path>.
> >
> > It uses @subvolid to control the default subvolume and
> > @subvolid=0 has always been parsed into FS_TREE no matter
> > what subvolume @path points to.
> >
> > So in order to set a subvolume to the default one, we need
> > to get the id of this subvolume first.
> >
> > Also fix a typo:
> > s/sbuvolid/subvolid/g
> >
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
>
> Sent a patch for this already. Thanks,
oops, sorry I should have noticed that, any chance to fold the typo fix
into your patch?
-liubo
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-23 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 8:47 [PATCH] xfstest/btrfs/001: fix the misuse of subvolume set-default Liu Bo
2013-09-23 8:47 ` Liu Bo
2013-09-23 13:17 ` Josef Bacik
2013-09-23 13:17 ` Josef Bacik
2013-09-23 14:37 ` Liu Bo [this message]
2013-09-23 14:37 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923143755.GC18072@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.