From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Cc: "Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Sakari Ailus" <sakari.ailus-X3B1VOXEql0@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: OMAP2: HACK: hardcode hsmmc2 input clock source for N950/N9
Date: Mon, 23 Sep 2013 10:38:43 -0700 [thread overview]
Message-ID: <20130923173843.GI2684@atomide.com> (raw)
In-Reply-To: <1379771142-29087-2-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
* Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org> [130921 06:56]:
> Without this the eMMC (root file system) cannot be used on N950/N9.
> Any ideas for a proper solution?
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
> ---
> arch/arm/mach-omap2/board-generic.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 39c7838..8be49b3 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -20,6 +20,7 @@
> #include <asm/mach/arch.h>
>
> #include "common.h"
> +#include "control.h"
> #include "common-board-devices.h"
> #include "dss-common.h"
>
> @@ -51,12 +52,26 @@ static void __init legacy_init_ehci_clk(char *clkname)
> }
> }
>
> +static void __init hsmmc2_input_clk(void)
> +{
> + u32 reg;
> +
> + reg = omap_ctrl_readl(OMAP343X_CONTROL_DEVCONF1);
> + reg |= OMAP2_MMCSDIO2ADPCLKISEL;
> + omap_ctrl_writel(reg, OMAP343X_CONTROL_DEVCONF1);
> +}
> +
> static void __init omap_generic_init(void)
> {
> omap_sdrc_init(NULL, NULL);
>
> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
>
> + /* HACK: Configure the MMC input clock source on N950/N9. */
> + if (of_machine_is_compatible("nokia,omap3-n950") ||
> + of_machine_is_compatible("nokia,omap3-n9"))
> + hsmmc2_input_clk();
> +
> /*
> * HACK: call display setup code for selected boards to enable omapdss.
> * This will be removed when omapdss supports DT.
>
Can you please update this patch on the quirks series I posted
few days ago?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: OMAP2: HACK: hardcode hsmmc2 input clock source for N950/N9
Date: Mon, 23 Sep 2013 10:38:43 -0700 [thread overview]
Message-ID: <20130923173843.GI2684@atomide.com> (raw)
In-Reply-To: <1379771142-29087-2-git-send-email-aaro.koskinen@iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [130921 06:56]:
> Without this the eMMC (root file system) cannot be used on N950/N9.
> Any ideas for a proper solution?
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> arch/arm/mach-omap2/board-generic.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 39c7838..8be49b3 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -20,6 +20,7 @@
> #include <asm/mach/arch.h>
>
> #include "common.h"
> +#include "control.h"
> #include "common-board-devices.h"
> #include "dss-common.h"
>
> @@ -51,12 +52,26 @@ static void __init legacy_init_ehci_clk(char *clkname)
> }
> }
>
> +static void __init hsmmc2_input_clk(void)
> +{
> + u32 reg;
> +
> + reg = omap_ctrl_readl(OMAP343X_CONTROL_DEVCONF1);
> + reg |= OMAP2_MMCSDIO2ADPCLKISEL;
> + omap_ctrl_writel(reg, OMAP343X_CONTROL_DEVCONF1);
> +}
> +
> static void __init omap_generic_init(void)
> {
> omap_sdrc_init(NULL, NULL);
>
> of_platform_populate(NULL, omap_dt_match_table, NULL, NULL);
>
> + /* HACK: Configure the MMC input clock source on N950/N9. */
> + if (of_machine_is_compatible("nokia,omap3-n950") ||
> + of_machine_is_compatible("nokia,omap3-n9"))
> + hsmmc2_input_clk();
> +
> /*
> * HACK: call display setup code for selected boards to enable omapdss.
> * This will be removed when omapdss supports DT.
>
Can you please update this patch on the quirks series I posted
few days ago?
Regards,
Tony
next prev parent reply other threads:[~2013-09-23 17:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 13:45 [PATCH 0/3] ARM: OMAP: convert N950/N9 to DT Aaro Koskinen
2013-09-21 13:45 ` Aaro Koskinen
2013-09-21 13:45 ` [PATCH 1/3] ARM: OMAP2: HACK: hardcode hsmmc2 input clock source for N950/N9 Aaro Koskinen
2013-09-21 13:45 ` Aaro Koskinen
[not found] ` <1379771142-29087-2-git-send-email-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2013-09-23 17:38 ` Tony Lindgren [this message]
2013-09-23 17:38 ` Tony Lindgren
2013-09-23 18:03 ` Aaro Koskinen
2013-09-23 18:03 ` Aaro Koskinen
2013-09-21 13:45 ` [PATCH 2/3] ARM: dts: add minimal DT support for Nokia N950 & N9 phones Aaro Koskinen
2013-09-21 13:45 ` Aaro Koskinen
2013-09-21 13:45 ` [PATCH 3/3] ARM: OMAP2: delete board-rm680 Aaro Koskinen
2013-09-21 13:45 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923173843.GI2684@atomide.com \
--to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sakari.ailus-X3B1VOXEql0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.