From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports
Date: Tue, 24 Sep 2013 08:59:42 +0200 [thread overview]
Message-ID: <201309240859.43105.marex@denx.de> (raw)
In-Reply-To: <CAPnjgZ2sNAsuK4WqOrx-b0RYgJY7pq5ZNf5Kh3g_A2rye9Pn3g@mail.gmail.com>
Dear Simon Glass,
> Hi Julius,
>
> On Mon, Sep 23, 2013 at 8:55 PM, Julius Werner <jwerner@chromium.org> wrote:
> > Hi Simon,
> >
> > > It seems like you could do something like
> > >
> > > /*
> > >
> > > * This is the delay for ...the spec requires a minimum of ...
> > > */
> > >
> > > #define SOME_SUITABLE_NAME 8000
> > >
> > > at the top of the file and then use it twice in your function.
> >
> > The file contains a dozen handshake() calls that have a literal "100 *
> > 1000" in there, and none of them have any special meaning in regards
> > to the spec... it's all just a random guess. I'd be happy to change
> > the timeouts in my patch to 100 for consistency, but it really doesn't
> > make sense to single this one out with a #define. (Maybe we should
> > make it a #define DEFAULT_TIMEOUT 100000 for all of them, but not in
> > this patch.)
>
> I guess we are trying to distinguish between how the code is and how we
> would like it to me. From that point of view your patch is independent of
> the existing code. Since you have a clear reason for the timeout you have
> chose, you can document that and set a good example for others!
ACK on that. We should focus on improvement, not stagnate.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-09-24 6:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 0:29 [U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports Julius Werner
2013-09-18 2:13 ` Simon Glass
2013-09-18 14:44 ` Marek Vasut
2013-09-18 17:16 ` Julius Werner
2013-09-19 21:48 ` Marek Vasut
2013-09-20 1:39 ` Julius Werner
2013-09-20 5:12 ` Simon Glass
2013-09-24 2:55 ` Julius Werner
2013-09-24 4:06 ` Simon Glass
2013-09-24 6:59 ` Marek Vasut [this message]
2013-09-24 17:53 ` [U-Boot] [PATCH v2] " Julius Werner
2013-09-26 23:30 ` Simon Glass
2013-09-27 14:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309240859.43105.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.